Received-SPF: pass (google.com: domain of linux-kernel+bounces-104443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240315121315.406601-1-sunil.khatri@amd.com>
In-Reply-To: <20240315121315.406601-1-sunil.khatri@amd.com>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Fri, 15 Mar 2024 09:15:04 -0400
Message-ID: <CADnq5_NsqSWknj5x0v22iF2_UPCEFO7gnj4BV5j22x-jitO1=g@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's
To: Sunil Khatri <sunil.khatri@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, 
	=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	Shashank Sharma <shashank.sharma@amd.com>, amd-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 15, 2024 at 8:13=E2=80=AFAM Sunil Khatri <sunil.khatri@amd.com>=
 wrote:
>
> Add all the IP's version information on a SOC to the
> devcoredump.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

This looks great.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/=
amd/amdgpu/amdgpu_reset.c
> index a0dbccad2f53..3d4bfe0a5a7c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> @@ -29,6 +29,43 @@
>  #include "sienna_cichlid.h"
>  #include "smu_v13_0_10.h"
>
> +const char *hw_ip_names[MAX_HWIP] =3D {
> +       [GC_HWIP]               =3D "GC",
> +       [HDP_HWIP]              =3D "HDP",
> +       [SDMA0_HWIP]            =3D "SDMA0",
> +       [SDMA1_HWIP]            =3D "SDMA1",
> +       [SDMA2_HWIP]            =3D "SDMA2",
> +       [SDMA3_HWIP]            =3D "SDMA3",
> +       [SDMA4_HWIP]            =3D "SDMA4",
> +       [SDMA5_HWIP]            =3D "SDMA5",
> +       [SDMA6_HWIP]            =3D "SDMA6",
> +       [SDMA7_HWIP]            =3D "SDMA7",
> +       [LSDMA_HWIP]            =3D "LSDMA",
> +       [MMHUB_HWIP]            =3D "MMHUB",
> +       [ATHUB_HWIP]            =3D "ATHUB",
> +       [NBIO_HWIP]             =3D "NBIO",
> +       [MP0_HWIP]              =3D "MP0",
> +       [MP1_HWIP]              =3D "MP1",
> +       [UVD_HWIP]              =3D "UVD/JPEG/VCN",
> +       [VCN1_HWIP]             =3D "VCN1",
> +       [VCE_HWIP]              =3D "VCE",
> +       [VPE_HWIP]              =3D "VPE",
> +       [DF_HWIP]               =3D "DF",
> +       [DCE_HWIP]              =3D "DCE",
> +       [OSSSYS_HWIP]           =3D "OSSSYS",
> +       [SMUIO_HWIP]            =3D "SMUIO",
> +       [PWR_HWIP]              =3D "PWR",
> +       [NBIF_HWIP]             =3D "NBIF",
> +       [THM_HWIP]              =3D "THM",
> +       [CLK_HWIP]              =3D "CLK",
> +       [UMC_HWIP]              =3D "UMC",
> +       [RSMU_HWIP]             =3D "RSMU",
> +       [XGMI_HWIP]             =3D "XGMI",
> +       [DCI_HWIP]              =3D "DCI",
> +       [PCIE_HWIP]             =3D "PCIE",
> +};
> +
> +
>  int amdgpu_reset_init(struct amdgpu_device *adev)
>  {
>         int ret =3D 0;
> @@ -196,6 +233,31 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset,=
 size_t count,
>                            coredump->reset_task_info.process_name,
>                            coredump->reset_task_info.pid);
>
> +       /* GPU IP's information of the SOC */
> +       if (coredump->adev) {
> +
> +               drm_printf(&p, "\nIP Information\n");
> +               drm_printf(&p, "SOC Family: %d\n", coredump->adev->family=
);
> +               drm_printf(&p, "SOC Revision id: %d\n", coredump->adev->r=
ev_id);
> +               drm_printf(&p, "SOC External Revision id: %d\n",
> +                          coredump->adev->external_rev_id);
> +
> +               for (int i =3D 1; i < MAX_HWIP; i++) {
> +                       for (int j =3D 0; j < HWIP_MAX_INSTANCE; j++) {
> +                               int ver =3D coredump->adev->ip_versions[i=
][j];
> +
> +                               if (ver)
> +                                       drm_printf(&p, "HWIP: %s[%d][%d]:=
 v%d.%d.%d.%d.%d\n",
> +                                                  hw_ip_names[i], i, j,
> +                                                  IP_VERSION_MAJ(ver),
> +                                                  IP_VERSION_MIN(ver),
> +                                                  IP_VERSION_REV(ver),
> +                                                  IP_VERSION_VARIANT(ver=
),
> +                                                  IP_VERSION_SUBREV(ver)=
);
> +                       }
> +               }
> +       }
> +
>         if (coredump->ring) {
>                 drm_printf(&p, "\nRing timed out details\n");
>                 drm_printf(&p, "IP Type: %d Ring Name: %s\n",
> --
> 2.34.1
>