Received-SPF: pass (google.com: domain of linux-kernel+bounces-104445-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3db5a50d-f695-4319-a254-5a5bccde1601@amd.com>
Date: Fri, 15 Mar 2024 18:47:53 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's
Content-Language: en-US
To: Alex Deucher <alexdeucher@gmail.com>, Sunil Khatri <sunil.khatri@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 Shashank Sharma <shashank.sharma@amd.com>, amd-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20240315121315.406601-1-sunil.khatri@amd.com>
 <CADnq5_NsqSWknj5x0v22iF2_UPCEFO7gnj4BV5j22x-jitO1=g@mail.gmail.com>
From: "Khatri, Sunil" <sukhatri@amd.com>
In-Reply-To: <CADnq5_NsqSWknj5x0v22iF2_UPCEFO7gnj4BV5j22x-jitO1=g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RzVlRmN6MG9idlBLNFkwa2tzbFNWTU43OFpNQld5ZnFkVDE3VnFtaHJISmVy?=
 =?utf-8?B?QzJFRFZ6a1hnbTV5L25sU0N6S2V5bUc1OU95VUdYQ2VMM2w4QW9sSlAzYlor?=
 =?utf-8?B?VzBTZWRlUDhIWW5zQlo0WndmNkROd0F2ZWQyYmxyYUcwR2VWZzE3ZCt6b2Zm?=
 =?utf-8?B?T1B6SHg1Z1FkMS94MWt6UlhNSVJpUmpQLzJESU0wQlQ5R2hYdXQ4YXc2QnE2?=
 =?utf-8?B?ZitIWWEzS3VCdEc2cWlINEw1dTlxK1lnUldBWUZIa2c5NUZORitXc3kvdmFG?=
 =?utf-8?B?enYrckVZYTNIMUVMSVFzR2Y4UVNNSWZESWp5Z1RwTXZnek1GYkJOcTA2T20w?=
 =?utf-8?B?NElUeU9kdVRvMm9wdmVpUS8xUFc2Vkw3OEZQNDVqSGYzL1c4VUYySDYzZ1N4?=
 =?utf-8?B?cE5OMGZaV0JoU0Fud3N5dGlSM0NFdkZINFQ0eHBiVDdycUZwVERKVW9wQ3Nj?=
 =?utf-8?B?ekxXcjN2L0N2dmFhTHFSaGVUU3RCSEl2THhjaUYzbHYyMmY5QlpLSDh5dWJE?=
 =?utf-8?B?NXZxZjd2YUhQVDZ4Mmg1OEJsaDlaS2YzdHVhSktFZ1l2NUpoUEVJdDAvdVpX?=
 =?utf-8?B?OXhWc2o1WUtrN1kwSW5ldkVNa1BjRENRNnVTMmtMMXFRQzdJMnZIRmZpMUtk?=
 =?utf-8?B?NFJtcEx6ZFhFZmR0T21ZeVJnYkszVWVub1NjdjNpU014dDM5YWRBcDZaZXlY?=
 =?utf-8?B?MFJERm8xUkM5SVJOQUlWc1hZVWNpSzdDTUpSeVZZaEh4RHJXSWpzUm5uWW01?=
 =?utf-8?B?QUxROXlhNGJhNklqRXhTQ3BlTG9OMmUrZUkwbjk0anB4MFluYnRpUjlUQ1dh?=
 =?utf-8?B?dXFUa1crT1hDeEhTZDkzUEp3Q1haZk1NQURNdUxkc2cwdE1hR0dsdlpTVlcv?=
 =?utf-8?B?cUVXTG16R29tSWtPMllTT2d3aG54aU1JSzJTc3k5RW5YdnN5ckx2TGdnRS9i?=
 =?utf-8?B?UGFndUVTS1ZNWlA1Tkh2VEJ6V2R2MTJpRFRUaGZVcmlJU1c4UUtaNk9ySEpx?=
 =?utf-8?B?ZHlZZlRGSEx3bXIvK3FSZWc3M1UxR2E3UXRjT0h5ekZXVzhjRm5Rd2dwMS9K?=
 =?utf-8?B?Z29TWVR4dGFCby8yTlRjY2ppaEsvK2I4ZWlKQ3hyb0M1NytaSnlCWjg4NnZo?=
 =?utf-8?B?REVCa25HU0pMM0ltN0lQVjh5elRxL2NJM1JGQlNKTlROd1M5NGp6dmlMUng0?=
 =?utf-8?B?TjUyOUt2bzh4RFo4R0xHQzMxeHVKa0Y4OEpWK2xRRHl3b0hEN0N2VjRmNFcx?=
 =?utf-8?B?dzkzNGRuM0cwSFEzc2FpRkd0WG9IdDBQdzM1eHJkaVpWNDF6YTRDRFhTY2Fk?=
 =?utf-8?B?K213M09wRE8wdW5xTTZidUZ5a1l6RjRROVF5Ny83bUlzbkJiZmt1R0l0NFFu?=
 =?utf-8?B?YlRnVEY2K2NwR1F2Qkp6M1pZaWppcUkvQm5NT2NwTmtRaElFRXhhM2ZUMmQ3?=
 =?utf-8?B?TEp6aXdwa0JyRDZDNXJZUHdBZ1dhb0RNaERBL3FyTStHeVdqVlNkaklWYmpU?=
 =?utf-8?B?bGtvWWkrUDgycGt6NjB4SFcyaVl2bzRUcTEzYW1PdE5GWEM5Sys3OEh3YUR1?=
 =?utf-8?B?K052RzBKd2dtK2FsN3FwTngwRmkxY0wxdG9LMHhROGJ6ZEFEeWM1akRHSmRR?=
 =?utf-8?B?Tnd6R3lwMWc0em15VEtETVh4M1RJdzRlUUQ0cy9sSHhMaTY1bjg5UkdER09D?=
 =?utf-8?B?WCtHSUVSVkJMcjcyZ0lzK2FPb1VXQlpxTHBLN1NhOSt6MTdzZ2JOWUxJdEdj?=
 =?utf-8?B?MjlSM21DUDlnU3AyRitYdnRXc3VyQTFwUlpoK3VRN2gvRGtoZkRzR3ZXV09p?=
 =?utf-8?B?dVdJVExhQ2Y4SVNnaXVieisxd1J4Z0diY0M3MWRKY0FaMUk1VE5VQ3A0S0Vk?=
 =?utf-8?B?eGFncE9wTVNMZldBUjlBRGxTSTBzbUpYU3lwV2RocEttRUlMMTkzSkJtc0hX?=
 =?utf-8?B?cSt5ZEo1L2ppZjlJZjdkbW1tTzgyTy9tQmpSTWRQTWU4eXUyVlpsWnQwMUpj?=
 =?utf-8?B?TkJ6dTlQd2l5dDRNcEtyc2RQaFhlazdOVVduQ2tYNE5NS0xyTitPWFFwb0g2?=
 =?utf-8?B?NUwvQ3pKRTFPOTJTQ3B6ZlY4eDRtWkE2OUZUQjhBYU1jdXpqenJnY21CSCtz?=
 =?utf-8?Q?/8GSDIc6MH4HgmrwB9EDbpWzN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb33042f-9df2-4cce-d05f-08dc44f2577e
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5596.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 13:18:02.4100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NgrwKMp5lEcxQk2RJAn5uii1I12jfHFov7s72+15/QVN4rMQG7/ikOghYcw8b7ecDPHFfdnJU9QApjT4CwnTVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6634


On 3/15/2024 6:45 PM, Alex Deucher wrote:
> On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>> Add all the IP's version information on a SOC to the
>> devcoredump.
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> This looks great.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Thanks Alex

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++++++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
>> index a0dbccad2f53..3d4bfe0a5a7c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
>> @@ -29,6 +29,43 @@
>>   #include "sienna_cichlid.h"
>>   #include "smu_v13_0_10.h"
>>
>> +const char *hw_ip_names[MAX_HWIP] = {
>> +       [GC_HWIP]               = "GC",
>> +       [HDP_HWIP]              = "HDP",
>> +       [SDMA0_HWIP]            = "SDMA0",
>> +       [SDMA1_HWIP]            = "SDMA1",
>> +       [SDMA2_HWIP]            = "SDMA2",
>> +       [SDMA3_HWIP]            = "SDMA3",
>> +       [SDMA4_HWIP]            = "SDMA4",
>> +       [SDMA5_HWIP]            = "SDMA5",
>> +       [SDMA6_HWIP]            = "SDMA6",
>> +       [SDMA7_HWIP]            = "SDMA7",
>> +       [LSDMA_HWIP]            = "LSDMA",
>> +       [MMHUB_HWIP]            = "MMHUB",
>> +       [ATHUB_HWIP]            = "ATHUB",
>> +       [NBIO_HWIP]             = "NBIO",
>> +       [MP0_HWIP]              = "MP0",
>> +       [MP1_HWIP]              = "MP1",
>> +       [UVD_HWIP]              = "UVD/JPEG/VCN",
>> +       [VCN1_HWIP]             = "VCN1",
>> +       [VCE_HWIP]              = "VCE",
>> +       [VPE_HWIP]              = "VPE",
>> +       [DF_HWIP]               = "DF",
>> +       [DCE_HWIP]              = "DCE",
>> +       [OSSSYS_HWIP]           = "OSSSYS",
>> +       [SMUIO_HWIP]            = "SMUIO",
>> +       [PWR_HWIP]              = "PWR",
>> +       [NBIF_HWIP]             = "NBIF",
>> +       [THM_HWIP]              = "THM",
>> +       [CLK_HWIP]              = "CLK",
>> +       [UMC_HWIP]              = "UMC",
>> +       [RSMU_HWIP]             = "RSMU",
>> +       [XGMI_HWIP]             = "XGMI",
>> +       [DCI_HWIP]              = "DCI",
>> +       [PCIE_HWIP]             = "PCIE",
>> +};
>> +
>> +
>>   int amdgpu_reset_init(struct amdgpu_device *adev)
>>   {
>>          int ret = 0;
>> @@ -196,6 +233,31 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>>                             coredump->reset_task_info.process_name,
>>                             coredump->reset_task_info.pid);
>>
>> +       /* GPU IP's information of the SOC */
>> +       if (coredump->adev) {
>> +
>> +               drm_printf(&p, "\nIP Information\n");
>> +               drm_printf(&p, "SOC Family: %d\n", coredump->adev->family);
>> +               drm_printf(&p, "SOC Revision id: %d\n", coredump->adev->rev_id);
>> +               drm_printf(&p, "SOC External Revision id: %d\n",
>> +                          coredump->adev->external_rev_id);
>> +
>> +               for (int i = 1; i < MAX_HWIP; i++) {
>> +                       for (int j = 0; j < HWIP_MAX_INSTANCE; j++) {
>> +                               int ver = coredump->adev->ip_versions[i][j];
>> +
>> +                               if (ver)
>> +                                       drm_printf(&p, "HWIP: %s[%d][%d]: v%d.%d.%d.%d.%d\n",
>> +                                                  hw_ip_names[i], i, j,
>> +                                                  IP_VERSION_MAJ(ver),
>> +                                                  IP_VERSION_MIN(ver),
>> +                                                  IP_VERSION_REV(ver),
>> +                                                  IP_VERSION_VARIANT(ver),
>> +                                                  IP_VERSION_SUBREV(ver));
>> +                       }
>> +               }
>> +       }
>> +
>>          if (coredump->ring) {
>>                  drm_printf(&p, "\nRing timed out details\n");
>>                  drm_printf(&p, "IP Type: %d Ring Name: %s\n",
>> --
>> 2.34.1
>>