Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp786856lqb; Fri, 15 Mar 2024 06:37:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX0BeIQgmxLlpex/OLSC+HpNPZTVNVKQ/LLqbcuAa5UZh3S6P/L46S3dP9XEuMPLMatsQhGZkCKUCh0MNlufu4daGr9mKErczTHDMQn9A== X-Google-Smtp-Source: AGHT+IHtiExSVsLg7eep5XBwMMdwi3D4eZJsBNkj1XBXUyymtw5DZETH/GDr/5Ev5ePn6g2Og+14 X-Received: by 2002:a05:620a:4384:b0:789:e524:933b with SMTP id a4-20020a05620a438400b00789e524933bmr1836646qkp.31.1710509825265; Fri, 15 Mar 2024 06:37:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710509825; cv=pass; d=google.com; s=arc-20160816; b=ADF49d+Srz+n2kEFg8OhOyUEOh+PM2Zxf8OW+DDX5o9eSp3d/Z3goDSfdxLDJnYudT O0JP93e4D/a1hNOEs6mSgOdtiB0fngaeDc6v9PiNHNgExQV4u3wh3ZEAHzHRKba9p+Ls Q/l4kfVCpO9uFtF3h/gpBF3n2eC7RxOFsvu+BzBHHtIicBkdVTlfFqEC7YIykjxOYAqU BUvmbY0PhQyr2Y1h/akJPQhi2XWasLySjwf55EjfK8b7GAxkTzaST1ImGhuYHpJUgiJV BXE+2/sJP/Gem1D5NXCXrTpsRjevMlfQTORAyRLeFimdT6Pj6e88xFJYU2YSY9cc5jIw mZQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lIsQyR/BMROFDDKneoMkFqijlMuWk5aAzJUFPESuMbY=; fh=U+ASR9UV1HIqj+u5s7M55SUZ/iUeuFZkwz3JAkiJnzc=; b=VTx+dpQB5VcyJu/+vnOyltldUXLHBgisjRDC13nCsakaX7XfSXb4PhRjMPQFbjmwCl dFbOU6uVrbK39P9oZ0e3thAeEitng3HLbezu+NxPKmkBK57JI8cgd50A3WdHLH3RarLi 1B0UryzGX0yeLwbisnRZZbq4Dgdd4/mA2Hi9UrPQimHFna8S9+8ScF5uefdcp+YQm4vz wefRgGqunYAKgPdYJ0eFpB7lG5s66Hua7mOASOmprSQGfG9OTTmlni7ETdmB2yJ1/2HP OV8ru5E0bIq1kvn9bit/UuGcsXIUroWBRR91jvnz0EJpr7HpKssIkYWhQwl7kGAkbGJT MfYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBikQgWF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-104459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id os6-20020a05620a810600b0078838fee369si3669181qkn.75.2024.03.15.06.37.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 06:37:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-104459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBikQgWF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-104459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E49251C210AD for ; Fri, 15 Mar 2024 13:37:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE5492E634; Fri, 15 Mar 2024 13:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WBikQgWF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E8236AED; Fri, 15 Mar 2024 13:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710509816; cv=none; b=QW1Dtb2yFi7mOa+9a+USvlQ3PxK+lGMgTlQsF17mUFik2YOtm8/z6icdGnDo9R361nRuS+iAmyfOZ4+aKrRBu1CkRbQDL4yBEym5tUdzK7h1y25FOXhCHzsXGMSIWkA98ivmwvjeW3aBhqw/hykvWEmXsGyLFN/tXnJjUy7zB1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710509816; c=relaxed/simple; bh=mnKx/USIAWKFowB3UECi37soYZOTeSdjE7YC6dui0gY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nQbgdKYHyu/lcRDgYQy6/uQJdqrpI4ceH+tiMPMEm6idfyntRHVuH1+X4ZOArh+vH/8k4mj9ZYLXQV4HzTQ1NV7TTu/sRC7lYSXudSWGR7JfhKVA8y1ACxJEyNKXsSIvKsyf6MhbSW+rgSwgBSeE/OUBd+rpL/oR24uuRUAL4nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WBikQgWF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B990C433F1; Fri, 15 Mar 2024 13:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710509815; bh=mnKx/USIAWKFowB3UECi37soYZOTeSdjE7YC6dui0gY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WBikQgWFYtKFSQn7AJHJtgle7tDUdFM0GNQ/6JqxAf0lxH6kRfm2hxTIXdG5E6Egy YAzTuwY1PjSj0ojy2bfIUYwcULJe3/38mYLHr+20Nw39reMae5OEJudFQOAYqJS1cG mjHGzUI/L69hkyZrBEUsb8oCQhOHCT3JZQ44vfSkw/OskPHgcBcH2rCpWA6LWBCF5E diWwtCdzYwAdPO346YhitMreYA0mq7RAR0VnKsuUT5V6yoGUgrZLjFm21Xpp4uFg52 3KzbWdPKyTbVDmpXxzm5MDzWsiHQEt7QAGwNh5hjZUGzrkEU44uZ9fAbLix7zN5tme 8jjsI9jEx/Dhw== Date: Fri, 15 Mar 2024 13:36:48 +0000 From: Mark Brown To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 12/25] ASoC: meson: t9015: add support for A1 SoC family Message-ID: <5f8e8cd2-f9c4-4961-a85d-a0f3217294e6@sirena.org.uk> References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-13-jan.dakinevich@salutedevices.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4AHceM7kGoMGggFJ" Content-Disposition: inline In-Reply-To: <20240314232201.2102178-13-jan.dakinevich@salutedevices.com> X-Cookie: A well-known friend is a treasure. --4AHceM7kGoMGggFJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 15, 2024 at 02:21:48AM +0300, Jan Dakinevich wrote: > +static const char * const a1_adc_mic_bias_level_txt[] = { "2.0V", "2.1V", > + "2.3V", "2.5V", "2.8V" }; > +static const unsigned int a1_adc_mic_bias_level_values[] = { 0, 1, 2, 3, 7 }; Why would this be varied at runtime rather than being something fixed when the system is designed? > +static const char * const a1_adc_pga_txt[] = { "None", "Differential", > + "Positive", "Negative" }; > +static const unsigned int a1_adc_pga_right_values[] = { 0, PGAR_DIFF, > + PGAR_POSITIVE, PGAR_NEGATIVE }; > +static const unsigned int a1_adc_pga_left_values[] = { 0, PGAL_DIFF, > + PGAL_POSITIVE, PGAL_NEGATIVE }; Similarly here. > + SOC_SINGLE("ADC Mic Bias Switch", LINEIN_CFG, MICBIAS_EN, 1, 0), > + SOC_ENUM("ADC Mic Bias Level", a1_adc_mic_bias_level), Why would micbias be user controlled rather than a DAPM widget as normal? --4AHceM7kGoMGggFJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX0Tu8ACgkQJNaLcl1U h9B7RQf/eYxVKAjAigpYP4vgwBWRE/HosjdaaB5ogMo8PMSiXfacGnLx0ZtIpWa9 i6saOA5iW9E/n7Et4JpmJ0J/fYdN7d5TkSlgYGwYP/ojBAChias0hOS7f+fHKvdM qH8C+20ovZC5RpNOZUjLmiwJ1WMJQrXgjYVTLpBHn23XPsf8fV3i+B5JEQzBJtXI px2DiSaV2iQ+nBmrZQEQo7KnJsQiLahPLQgr81xq5322lUfLN0+kRHrNGnqMU/Aw BW++2BV+mf6HXT8WKXrn2DeQByMpBN+jc7eeRDI7xIiB4iAWwpDL9Cn5HsSuYYvI ZdU3lU/s6CaDa3e5AyxYVatZ42Rx4Q== =sm4b -----END PGP SIGNATURE----- --4AHceM7kGoMGggFJ--