Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp820080lqb; Fri, 15 Mar 2024 07:22:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWHy6qryh4AzNFs8sOPBAY0JaUcTPLF8p6QN47ZaeHD6uO6cyYrV4jMyCInsXD980gExYrjmUawGwbi74oIpesmi2lWhmdK79Dz8fz5Uw== X-Google-Smtp-Source: AGHT+IEll82t8VSWV+NXu1coDH0kWPMkwEWEINAIhpRXDNowGxy9K47QevweJanL1YAkLBEuZe9b X-Received: by 2002:a17:906:40c5:b0:a46:9bea:7c9e with SMTP id a5-20020a17090640c500b00a469bea7c9emr233138ejk.30.1710512566662; Fri, 15 Mar 2024 07:22:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710512566; cv=pass; d=google.com; s=arc-20160816; b=qA/NDbEM8xQS7cjSfCtquAyPzv9qpw21LhXahi2tBGdmgtC6vaB16TSvpMJE/wjfll EBbMZGpVLyAxqzn23CLHRlZTOFJYDmVtKwBR8vVpRuwPJcrvYZ+XHCLt+FlDNEARaCHN bZ+qGe3qEM2zJdLlwgoBheE0yDsw1RuFYgVvTZFYAcu9mnFnoxmLo0RzInVI2qOTGt+g Oy/euSSpDJJbZZDx661WOovsSpM+KCzsqdyI77LWAB+k7oIjQZ69jNBzvMGe0KT55wA3 kqD8aE0Ih4zofGBOuc8JUvT8CR8KchNcKeQ9NzubH08Nh636IO4DNVxwjx/GiN33QTY5 JTUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=SDA528aF98oL35+Fllk9UtX8s0WuohToC3q155PcHes=; fh=KcGjIoJNv7WUo27TLb2OhjJKp0Z1b3VBYkX4hi2yHIE=; b=ui8RHDC0gVQpEH8J/LjGIKCGYAXd1Nro2ejMoBd2rsj/kGsPsNMGMF1vIvKxRJzJlQ Yv3NqLn7cK8fvHL05VcWKLL0wlKWF3R1oe62wU0bvf2+5AbDWSvvQPD8fIzsZZQWJ/kn eRMWhlwsipxviwqtaED6xQRwXRpCgP17M8wK6hBn++e69ycXfDnY99+6hhFy2lL/bZZP J9wK37J3hMBo5CcxNEGpmL6TqeN83FQSRowTkD07QKHjhLmS0b1BcRYSrw+ekShnyBWk R0rbZLoV+r+AuRhLixA2TX9Di+aJTcU2iMu2MCldlntSFuy5S9ryXud5/CK5ULNjE4KZ aX5A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-104488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c6-20020a170906340600b00a46651a4e62si1702873ejb.42.2024.03.15.07.22.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 07:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-104488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-104488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 675871F22836 for ; Fri, 15 Mar 2024 14:22:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78307376F3; Fri, 15 Mar 2024 14:22:38 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A22A1A38DA; Fri, 15 Mar 2024 14:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710512558; cv=none; b=YiSkLHLjPHgcgtViil62YhlSk2OSVEP7g7Wp07RQcO1wKyPN0W2Y6jmK5LtR3RYPnW9brg/H75no8b8i6wSdRRXsX56apnfX495yjrdcl6hH0I47JhFlkdciKFv22i4mgVi31GnKeO5WGYAwFkLWP5MdYbrFqneTLoPJmyUbBVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710512558; c=relaxed/simple; bh=toIEnnzYNiwyWD6Gb0TYT5sbPnu9iUMI7CYXzC9b3+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t7382VyWhULKTok1qlpCDmBwj1q+oaYhHJfyWYhGZmJIQD9ktv/redgps4drYgyGI0dSbCaJLXRhrpsk2D1Ro+Q8M+b7aNyYRyBDixIbmb/q0s/BDppsTmGhmXzc1U4MW4XoJyeN19WtQsXK3FOTq727+oWUkZ58H/irYTzghzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D1B81C15; Fri, 15 Mar 2024 07:23:09 -0700 (PDT) Received: from e130802.arm.com (e130802.arm.com [10.1.34.31]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03D5D3F73F; Fri, 15 Mar 2024 07:22:30 -0700 (PDT) Date: Fri, 15 Mar 2024 14:22:22 +0000 From: Abdellatif El Khlifi To: Sudeep Holla Cc: Robin Murphy , Bjorn Andersson , Sudeep Holla , Mathieu Poirier , Rob Herring , Liviu Dudau , Lorenzo Pieralisi , Krzysztof Kozlowski , Conor Dooley , Drew.Reed@arm.com, Adam.Johnston@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: remoteproc: Add Arm remoteproc Message-ID: <20240315142222.GA38748@e130802.arm.com> References: <20240301164227.339208-1-abdellatif.elkhlifi@arm.com> <20240301164227.339208-4-abdellatif.elkhlifi@arm.com> <8c784016-9257-4d8a-b956-a0a406746c76@arm.com> <20240314134928.GA27077@e130802.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Sudeep, On Thu, Mar 14, 2024 at 03:19:13PM +0000, Sudeep Holla wrote: > > The plan for the driver is as follows: > > > > Step 1: provide a foundation driver capable of turning the core on/off > > Step 2: provide mailbox support for comms > > Step 3: provide FW reload capability > > > > Steps 2 & 3 are waiting for a HW update so the Cortex-A35 (running Linux) can > > share memory with the remote core. > > > > Honestly, I would prefer to know the overall design before pushing any partial > solution. If you know the final complete solution, present the same with > the complete device tree binding for better understanding and review. Sounds good to me. I'll make the binding as complete as possible. > Agreed, but it is part of a bigger block with other functionality in place. > MFD/syscon might be better way to use these registers. You never know in > future you might want to use another set of 2-4 registers with a different > functionality in another driver. > > > It makes sense to me to use a mapped region of 8 bytes for both registers rather > > than individual registers (since they are consecutive). > > Not exactly. Are you sure, Linux will not have to use another other registers > in that block ? Will you keep creating such (random if I may call it so) > bindings for a smaller sets of register under "Host Base System Control > registers". > > I would see if it makes sense to put together a single binding for > this "Host Base System Control" register(not sure what exactly that means). > Use MFD/regmap you access parts of this block. The remoteproc driver can > then be semi-generic(meaning applicable to group of similar platforms) > based on the platform compatible and use this regmap to provide the > functionality needed. I like the idea of using syscon/regmap to represent the "Host Base System Control registers" area. Thank you for suggesting that. I think syscon is the way to go (rather than MFD). With syscon we can use the generic syscon driver that converts a set of MMIO registers to a regmap, allowing it to be accessed from multiple device drivers. In our case these MMIO registers will be the "Host Base System Control registers". remoteproc will be a child node under sysctrl node. Cheers, Abdellatif