Received-SPF: pass (google.com: domain of linux-kernel+bounces-104540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e03d0f75-b9bc-4f60-9824-d827df840425@kernel.dk>
Date: Fri, 15 Mar 2024 08:49:33 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 6.1 00/71] 6.1.82-rc1 review
To: Sasha Levin <sashal@kernel.org>
Cc: =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= <mat.jonczyk@o2.pl>,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org,
 Christoph Hellwig <hch@lst.de>, torvalds@linux-foundation.org,
 akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
 patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
 Andreas Herrmann <aherrmann@suse.de>, Tejun Heo <tj@kernel.org>
References: <20240313163957.615276-1-sashal@kernel.org>
 <73072bdd-590a-44b4-8e6d-34bd17073bb5@o2.pl>
 <ecb0b6a1-a8e7-4645-9a2c-56ada368f733@o2.pl>
 <ba297ed4-a74a-4786-a303-ce617b2de09b@o2.pl>
 <38563683-300a-487b-81c6-b2ea4dbb925c@kernel.dk> <ZfN7wtnVeb9vOL1H@sashalap>
 <267b0000-fba0-4dcf-945d-72b8ca4704c8@kernel.dk> <ZfQ7wRX06R-d3X7F@sashalap>
 <ZfReb38_gCrKno7A@sashalap>
Content-Language: en-US
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <ZfReb38_gCrKno7A@sashalap>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/15/24 8:42 AM, Sasha Levin wrote:
> On Fri, Mar 15, 2024 at 08:14:57AM -0400, Sasha Levin wrote:
>> On Thu, Mar 14, 2024 at 04:40:53PM -0600, Jens Axboe wrote:
>>> On 3/14/24 4:35 PM, Sasha Levin wrote:
>>>> On Thu, Mar 14, 2024 at 04:04:59PM -0600, Jens Axboe wrote:
>>>>> On 3/14/24 3:12 PM, Mateusz Jo?czyk wrote:
>>>>>> W dniu 13.03.2024 o 22:27, Mateusz Jo?czyk pisze:
>>>>>>> W dniu 13.03.2024 o 21:13, Mateusz Jo?czyk pisze:
>>>>>>>> W dniu 13.03.2024 o 17:38, Sasha Levin pisze:
>>>>>>>>> This is the start of the stable review cycle for the 6.1.82 release.
>>>>>>>>> There are 71 patches in this series, all will be posted as a response
>>>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>>>> let me know.
>>>>>>>>>
>>>>>>>>> Responses should be made by Fri Mar 15 04:39:56 PM UTC 2024.
>>>>>>>>> Anything received after that time might be too late.
>>>>>>>>>
>>>>>>>>> The whole patch series can be found in one patch at:
>>>>>>>>>        https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-6.1.y&id2=v6.1.81
>>>>>>>>> or in the git tree and branch at:
>>>>>>>>>        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
>>>>>>>>> and the diffstat can be found below.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Sasha
>>>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Kernel hangs during early boot. No console messages, nothing in pstore.
>>>>>>>>
>>>>>>>> Tested on a HP 17-by0001nw laptop with an Intel Kaby Lake CPU (Intel i3-7020U) and Ubuntu 20.04.
>>>>>>>>
>>>>>>>> This CPU is not affected by RFDS (at least according to the Kconfig message), so I have set
>>>>>>>>
>>>>>>>> CONFIG_MITIGATION_RFDS=n
>>>>>>>>
>>>>>>>> in Kconfig. I do not have any updated microcode (if any will be provided at all for this CPU).
>>>>>>>>
>>>>>>>> Greetings,
>>>>>>>>
>>>>>>>> Mateusz
>>>>>>>>
>>>>>>> [snip]
>>>>>>
>>>>>> Bisected down to
>>>>>>
>>>>>> commit d3d517a95e83a7d89e1ff511da1a0a31c9234155
>>>>>> Author: Christoph Hellwig <hch@lst.de>
>>>>>> Date:   Fri Feb 3 16:03:54 2023 +0100
>>>>>>
>>>>>>    blk-rq-qos: make rq_qos_add and rq_qos_del more useful
>>>>>
>>>>> Do you have:
>>>>>
>>>>> commit e33b93650fc5364f773985a3e961e24349330d97
>>>>> Author: Breno Leitao <leitao@debian.org>
>>>>> Date:   Tue Feb 28 03:16:54 2023 -0800
>>>>>
>>>>>   blk-iocost: Pass gendisk to ioc_refresh_params
>>>>>
>>>>> in there?
>>>>
>>>> It's not in the 6.1 tree, do we need it?
>>>
>>> If the bisected commit is in there, then yes we need it. It's marked as
>>> fixes that, so puzzled why it isn't in there?
>>
>> Sorry, I take it back - both e33b93650fc5 ("blk-iocost: Pass gendisk to
>> ioc_refresh_params") and d3d517a95e83 ("blk-rq-qos: make rq_qos_add and
>> rq_qos_del more useful") are currently in the 6.1 tree.

I didn't see e33b93650fc5 in there, but maybe it was part of the series
that this is about.

> I'll go ahead and drop the backport of f814bdda774c ("blk-wbt: Fix
> detection of dirty-throttled tasks") as well as the dependencies (which
> is where this issue bisected to), and all follow-up fixes.
> 
> We can revisit this for the next release.

Sounds reasonable.

-- 
Jens Axboe