Received-SPF: pass (google.com: domain of linux-kernel+bounces-104544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 15 Mar 2024 14:54:51 +0000
From: Mark Brown <broonie@kernel.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	herve.codina@bootlin.com, christophercordahi@nanometrics.ca
Subject: Re: [PATCH 09/13] ASoC: ti: davinci-i2s: Enable unexpected frame
 pulses detection
Message-ID: <9b3091e7-53ea-46f8-9dbc-a3896e920a97@sirena.org.uk>
References: <20240315112745.63230-1-bastien.curutchet@bootlin.com>
 <20240315112745.63230-10-bastien.curutchet@bootlin.com>
 <51866f62-460d-4035-bcf1-b9f03cf9be0b@sirena.org.uk>
 <13faa6c8-ad4f-4f81-935a-5ea74621d373@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2KhnnhvxjBoPFAUT"
Content-Disposition: inline
In-Reply-To: <13faa6c8-ad4f-4f81-935a-5ea74621d373@bootlin.com>


--2KhnnhvxjBoPFAUT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 15, 2024 at 03:45:24PM +0100, Bastien Curutchet wrote:
> On 3/15/24 15:09, Mark Brown wrote:
> > On Fri, Mar 15, 2024 at 12:27:41PM +0100, Bastien Curutchet wrote:

> > > McBSP can generate an SYNCERR when unexpected frame pulses are
> > > detected. The driver always disables this feature and ignore the
> > > unexpected frame pulses.

> > What does "unexpected" mean?

> Unexpected frame sync pulse is defined in datasheet as a sync pulse that
> occurs <N> bit clocks earlier than the last transmitted bit of the previous
> frame. The <N> can be configured through registers.

> > > Enable the generation of SYNCERR by the McBSP according to the
> > > 'ti,enable-sync-err' device-tree property.

> > Why would this be optional, and how is this reported - I'm not seeing
> > any interrupt handling updates?

> It is possible to deliberately ignore them and that is what is done today in
> the driver.
> This is reported as a status bit in a register. An interrupt can indeed be
> generated from this but I'm not using it (now at least).
> I use the fact that McBSP automatically drops previous element and starts a
> new reception when an unexpected frame pulse occurs.

That sounds like a very standard behaviour for incorrect clocking.  I
don't think this needs configuration at all, just enable this mode.

--2KhnnhvxjBoPFAUT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX0YToACgkQJNaLcl1U
h9DXzQf/SiZqlmZT6xmjS1bCVvJ6Goxl8aWHFYwkoXqqlqIa3nAeHYUUyXV05kI3
Q9wNkk5YWPwDi4hHCkO8/XTvDtnobNBT51YqIWsgLquWdHyHehjGdvhqMkxN/eGi
vJ2v+789u9CPM5hry0dMXgBTxlDG5G1b5GWoGe7rjYEdoCDDTNJo56JRpCk3T/GX
g001ZFQgk2tZUyaGgBEjF1cFzWY2WocYH5l5nhhALRHQ+H0zP75++neQ19ydZkC0
Y4R+CzYDoWn/jvgrf5ng/n+o66WW97stC12kMTjiodnTpaCWSF7Bk+qk1WqLoWAJ
uu2o1O7QEGyyJWz+4GuiRyuMupFGbw==
=aZq6
-----END PGP SIGNATURE-----

--2KhnnhvxjBoPFAUT--