Received-SPF: pass (google.com: domain of linux-kernel+bounces-104618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <162f5113-4eb6-dcea-f034-c81b9dc021b6@amd.com>
Date: Fri, 15 Mar 2024 11:17:21 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: 32bit resctrl? (was Re: [PATCH v2] fs/resctrl: fix domid loss
 precision issue)
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 Rex Nie <rex.nie@jaguarmicro.com>, james.morse@arm.com,
 "x86@kernel.org" <x86@kernel.org>, "Luck, Tony" <tony.luck@intel.com>,
 Babu Moger <babu.moger@amd.com>, Peter Newman <peternewman@google.com>,
 Borislav Petkov <bp@alien8.de>
Cc: fenghua.yu@intel.com, ilpo.jarvinen@linux.intel.com,
 linux-kernel@vger.kernel.org
References: <20240312075349.977-1-rex.nie@jaguarmicro.com>
 <fed6affb-c7f4-4992-8646-8f5a52c33966@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <fed6affb-c7f4-4992-8646-8f5a52c33966@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YmluWmNTbWwvMStEaldlYnMxdHE1Rzh0Y1dvYTR1SmYrWWtvWlJtL3pxL1F5?=
 =?utf-8?B?cUVyMTNPckozUkM1dDRIVjRxdDBzdXlLY2s3WVlLUjJzdzc5VFdORk1wdW9G?=
 =?utf-8?B?VmVvN1p4TGhFemROYTJYeUllREoySkR4dHJHVEhYdlJwM1ZTMVg3NjE4U1da?=
 =?utf-8?B?Rmhmd3lwb01iWjl4Nk4rSW5CdXh4OW1aWENhTUZVeGZQUHdXeHBzTHJMR1hH?=
 =?utf-8?B?RjlvaDltcHRUNGRTbEdvcnpxM2RLcG84V1lOUE04cTJxczNrcEV1cnpicE1s?=
 =?utf-8?B?SW9UVTY0cU1lMmVpbHBDSmdHWUR5TjVROFowWHcrZ0t6cVhFUCtDZld0bHVR?=
 =?utf-8?B?UFFqK1g5V0E5cGlCSWJYdnJlN3RCcFhZeWxwOUJiZC9EUGhQdmRFTTRqbmVR?=
 =?utf-8?B?QU1oNmJOVkx0UTM4L3h4dGs3NGpJdFRmakVpRkxpZnY4Ukk1cXo4cHY3YUN6?=
 =?utf-8?B?TEVtakFGOVJuKzJXRHJqa2pLRXpxU0RuUUEzNVo1b2pIRys3YS9FczBKUnlw?=
 =?utf-8?B?eGl4RWl2QTVLS0xwMVRPcXBQUFpmV1FCS2R2VXdEUFY0a29EUDZkd2g3Zm1v?=
 =?utf-8?B?eHJUejE5U1RxVWpwZmtCVTk2TXNJMll6eDBQNHdXOEVZQ2R4L1FuUlBMUDFQ?=
 =?utf-8?B?MyttQmVIMDRaWFIzMXFMeGk5cHBKcndUNnplTUhCeTg5Y0ZKSCtZNTV0c1d0?=
 =?utf-8?B?OUw5bGtxYjBJTUM1VVZ2MnZmd2pUajF5eEZURnR0RTlzbVBwazRlbzNCWmgw?=
 =?utf-8?B?ZXBIaXVFb0NvQTVBNXRQd1RMNGlqOTRvQmRuUnJuMDBzaXptTFY1dCtqWHdT?=
 =?utf-8?B?US9iRW1ObSs1NGRnczBrYmRDTVdRcnhpZjdiMzJGVWo5QThHUm9YcXJEMnVh?=
 =?utf-8?B?eENYNzMwZXRDblRqYnZOL0cwRE96NmtKRmxkVzdSbVVWUnRncmppZU0rNDZV?=
 =?utf-8?B?TFNYN2hXbzFBdjZoYkp5a2VaaDJTZDVtK210K3NZOW5CdHZwUlhoMjZOVU5F?=
 =?utf-8?B?OG00MEQzdHkyZE50ekU4dEVOdFE0dlJPYVlyTjh5bHJBblZOYTdYbEJ5cW9j?=
 =?utf-8?B?LytFUGVKNVdlK3ZDNjZGdjFSZUlJakV4b25rU2lJclA0aFI0a3FmaXlKNUg0?=
 =?utf-8?B?SGVsRDVLQ1J0ZXlGR3VOZ2Z0YW4wMnJZc1RsQWxzOExXbEpFdTdhMmtUTktU?=
 =?utf-8?B?dTA4cXFPMUMzMlQzVjE2aFcwN3RkS2lhYTBzSFk0VDVTN0JGYkJMVlRMdnBu?=
 =?utf-8?B?R0JFczZDYzd4K3JZN2FJdEJjb3V6STZXZjVoUENXankwT0VqbVNUOVdYbEVI?=
 =?utf-8?B?VmtQUFBHcUF0ODlHS1o2WVJGVHptdk5wMTdsVG9pVFVUSmQ1VkRPclhXTTRD?=
 =?utf-8?B?Y0wya1VWTS9DOUNKUUN4ek0xbnhhM29XWTIycWpWVytSZnRNRStuU2lWbEYw?=
 =?utf-8?B?QXVXTG5QVFBqWDdRaTBoUHJVSlhtekdNNjVFcDdQZjBuK2xTVjhWNmVnWnpJ?=
 =?utf-8?B?SFU0ajhZWnJicExkRE1tT2NMRnl2TWZEeFBUT3NhL1RGcElZR29XN3VxY0JH?=
 =?utf-8?B?WjRWUDU2UnFmRWhCYW5PUW1JNndBZjFSd3BUcWp6V0VESUlvQm9kL09RR1cr?=
 =?utf-8?B?RGFONGYyZEFxbENoU1d3ZXd1M1MvM3BaR0JXTFZhT0N5VllQK2Y2Z3pUeFI3?=
 =?utf-8?B?UTZsMWNydXJUckdCcTFIZFpoRk42aXpRclpKWm1Ob0k4Y3locjR1ekZ3VXlk?=
 =?utf-8?B?NXVycGJNRzU2VzV0Z3Q5eFNSaTJSZ0xkajI3M0VVL1loTGpLL1JrbExQUzRK?=
 =?utf-8?B?bUNtTlYvT2lFS2krQzFCeGtzV29kUHdCQzFOaGh6QlVnSmFYSUd5emVKbE85?=
 =?utf-8?B?Qkdta2xWSUlZTTBYZUpuS3lNR1ZzL3FOSXpGcmJ1WHlnZSt6aDhXT2czMCt0?=
 =?utf-8?B?b0dwckJDMVdueko0R1EwbWU5MjBMMHFqYThJYzl3RitXNGNOaGplbkQrOXJQ?=
 =?utf-8?B?T2RxdXVqTVVBMWdsSHJXVHVCVUJmeW9VSEhyaTk3VEszcnhWMUhHR2orcWVE?=
 =?utf-8?B?MEJhZ3htMzVRdjlzQ0NLdEZZMDdzeWpUc0JvOUxoN01ZdWYrSmRkVzU1cWwz?=
 =?utf-8?Q?eRts=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2f4de3-1b32-463a-600b-08dc450b6691
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 16:17:24.8623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: STo3/9eKYjDuNZeO5keKU4cot+DGHlwmW/Ur5K4ObxnObICQzcNyw5pZmF8fECyX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6636


On 3/14/2024 10:25 AM, Reinette Chatre wrote:
> +x86 maintainers, Tony, Babu, Peter
>
> Hi Everybody,
>
> On 3/12/2024 12:53 AM, Rex Nie wrote:
>> Below statement from mkdir_mondata_subdir function will loss precision,
>> because it assigns int to 14 bits bitfield.
>> 	priv.u.domid = d->id;
>>
>> On some platforms(e.g.,x86), the max cache_id is the amount of L3 caches,
>> so it is not in the range of 0x3fff. But some platforms use higher
>> cache_id, e.g., arm uses cache_id as locator for cache MSC. This will
>> cause below issue if cache_id > 0x3fff likes:
>> /sys/fs/resctrl/mon_groups/p1/mon_data/mon_L3_1048564 # cat llc_occupancy
>> cat: read error: No such file or directory
>>
>> This is the call trace when cat llc_occupancy:
>> rdtgroup_mondata_show()
>> 	domid = md.u.domid
>> 	d = resctrl_arch_find_domain(r, domid)
>>
>> d is null here because of lossing precision
>>
>> Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
>> ---
>>   fs/resctrl/internal.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h
>> index 7a6f46b4edd0..096317610949 100644
>> --- a/fs/resctrl/internal.h
>> +++ b/fs/resctrl/internal.h
>> @@ -94,7 +94,7 @@ union mon_data_bits {
>>   	struct {
>>   		unsigned int rid		: 10;
>>   		enum resctrl_event_id evtid	: 8;
>> -		unsigned int domid		: 14;
>> +		u32				domid;
>>   	} u;
>>   };
>>   
> resctrl currently supports 32bit builds. Fixing this issue* in this way

I have never bothered about 32bit builds.   Is Intel still testing 32bit 
builds?


> would first require that resctrl (the architecture independent fs part)
> depend on X86_64. Is this a change that everybody will be comfortable with?
>
> (Of course, there are other solutions available to address the issue mentioned
> in this patch that do not require depending on X86_64, but I would like
> to take this moment to understand the sentiment surrounding continuing support
> for 32bit resctrl.)

I am thinking we have bigger problem here.

The structure pointer "union mon_data_bits priv;" is created in stack 
and passed to create mondata directory. We are reading it later again in 
rdtgroup_mondata_show.

How is this pointer valid again?  Shouldn't we use static pointer or 
allocate memory for the pointer?

thanks

Babu


>
> Thank you.
>
> Reinette
>
> * Please note that this is not an urgent fix but instead a preparatory change
>    for future Arm support.
>