Received-SPF: pass (google.com: domain of linux-kernel+bounces-104620-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 15 Mar 2024 17:19:03 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v2] sysctl: drop unused argument set_ownership()::table
Message-ID: <20240315161903.cbz4jv5w23zh6yfx@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="dcq2itrqq6m5yonn"
Content-Disposition: inline
In-Reply-To: <838812fc-d1ee-4088-a704-8b8f15caab13@t-8ch.de>
CMS-TYPE: 201P
References: <CGME20240223155011eucas1p245e00a3dfd23f72997dac4952ebaeebf@eucas1p2.samsung.com>
	<20240223-sysctl-const-ownership-v2-1-f9ba1795aaf2@weissschuh.net>
	<20240315154134.5qfq6wucxid5kfmc@joelS2.panther.com>
	<838812fc-d1ee-4088-a704-8b8f15caab13@t-8ch.de>

--dcq2itrqq6m5yonn
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 15, 2024 at 04:56:54PM +0100, Thomas Wei=C3=9Fschuh wrote:
> On 2024-03-15 16:41:34+0100, Joel Granados wrote:
> > Hey Thomas
> >=20
> > Did you forget to compile? I'm seeing the following error when I
> > compile:
>=20
> Welp...
>=20
> >   ...
> >   ../fs/proc/proc_sysctl.c: In function =E2=80=98proc_sys_make_inode=E2=
=80=99:
> >   ../fs/proc/proc_sysctl.c:483:43: error: passing argument 2 of =E2=80=
=98root->set_ownership=E2=80=99 from incompatible pointer type [-Werror=3Di=
ncompatible-pointer-types]
> >     483 |                 root->set_ownership(head, table, &inode->i_ui=
d, &inode->i_gid);
> >         |                                           ^~~~~
> >         |                                           |
> >         |                                           struct ctl_table *
> >   ../fs/proc/proc_sysctl.c:483:43: note: expected =E2=80=98kuid_t *=E2=
=80=99 but argument is of type =E2=80=98struct ctl_table *=E2=80=99
> >   ../fs/proc/proc_sysctl.c:483:50: error: passing argument 3 of =E2=80=
=98root->set_ownership=E2=80=99 from incompatible pointer type [-Werror=3Di=
ncompatible-pointer-types]
> >     483 |                 root->set_ownership(head, table, &inode->i_ui=
d, &inode->i_gid);
> >         |                                                  ^~~~~~~~~~~~~
> >         |                                                  |
> >         |                                                  kuid_t *
> >   ../fs/proc/proc_sysctl.c:483:50: note: expected =E2=80=98kgid_t *=E2=
=80=99 but argument is of type =E2=80=98kuid_t *=E2=80=99
> >   ../fs/proc/proc_sysctl.c:483:17: error: too many arguments to functio=
n =E2=80=98root->set_ownership=E2=80=99
> >     483 |                 root->set_ownership(head, table, &inode->i_ui=
d, &inode->i_gid);
> >         |                 ^~~~
> >   cc1: some warnings being treated as errors
> >   make[5]: *** [../scripts/Makefile.build:243: fs/proc/proc_sysctl.o] E=
rror 1
> >     CC      fs/xfs/libxfs/xfs_dir2_node.o
> >   make[5]: *** Waiting for unfinished jobs....
> >   ...
> >=20
> > I'm guessing its just a matter of removing the table arg from
> > proc_sys_make_inode?
>=20
> Yes, for this error it's correct.
>=20
> There are also new implementors of the set_ownership callback in ipc/
> which need to be adapted.
>=20
> I'll send a new revision.
Thx. Not sure what your using as a base, but I suggest you use
linux-next so you get al the stuff going into the rc.

best

--=20

Joel Granados

--dcq2itrqq6m5yonn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX0dPcACgkQupfNUreW
QU81eQv/YATUMB0JjIPW8J4XRb/OFdpstOc0Yeqi/vJfhdfer0NWXpE86Bgfd4N6
O2g7pfT829Uulvxa1eJM4kV1nxGxwverjTnM51+MhLsm4dgEkr7eKNQLQmqujiSD
0fNWaKP2bApuYGS+KZxhU+cEJm7V40ytX3d+wFsAha4r7Ri2nqQZyAg4/7n7YLaK
9mq7d49wJrBZD8mzccRRJ8nmzWgpILaSJz/wjh6afYY9d1saU6F4I7oyxYgZJIrE
FCdliJTbAunj/EU32i3HHgEUFeIaGe3PQnnoFgXgbD2yRLhqwY0acLlo2gONDeVX
RxfNxb2Im8S5XaWjZzD/slaXjYi/zifoLlDxkGKrEX72aIbkkaQcFLvcI5yi/Dod
3mys2Ha1DWi9sjdpb5lmGILPKfG9hKW0ec381Ad1N6hXC9E/Jh8KfnQFJ9Z/v/qM
+dnaahqgcDcR49MLl1QK0o/5ECoP6iineFLOtxlm2Dijag58PQ21x7i6HP7RAjyW
bsR78PtN
=IudT
-----END PGP SIGNATURE-----

--dcq2itrqq6m5yonn--