Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp936980lqb; Fri, 15 Mar 2024 10:18:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVm1RYpNDsCAqZ7zNnyqq33UpalZrsORykzh/AqlrLAyuFUbYdxpiP0wotCOJ2HHaSwisLJKoGrmZyJ50unqumlAwHZ8dvQ1zHoSRPtDA== X-Google-Smtp-Source: AGHT+IFBOppiRG+70NOUwK/O7qbmfUv67BvGalnj6fd0QiPeCkbEzmABr+bu52cShpEGtJPKOI8Q X-Received: by 2002:a05:6358:6406:b0:17b:edd2:c785 with SMTP id f6-20020a056358640600b0017bedd2c785mr6848431rwh.11.1710523126799; Fri, 15 Mar 2024 10:18:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710523126; cv=pass; d=google.com; s=arc-20160816; b=JSnjs3rAZNwQYFKWU4LuaC1Rf/xN48aYXGOcgMT3hsM4/CBJWnO4rOHmoEpadT9zQi T6DWmmoGCMq/PfZWc+KjtwuspFmutwKlCaH0UhJR2s21MMvnSZxSoOWPRS4JH3H/D7Uq LsIVXsznALsm85EsVZ0QUHV/kAqPImAqduCz8YEuIoo3uXoWY8//RGAgJvYmzdzO/SYz JEPmn7yinmhZqXVehbZPtpNv24kvIMPOIOZHGoyejLo7dXEPMUyDWZNXXUHGOMMiCbRQ v2nbb2crbKj9G1tJS0pEozkh3yhaDpa4/VUI3p5URUPaOIlqdvHDGeqUsKFFnqFSzMo7 SlLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=/n1xeNQpebl3jFBaZdpI0WmhzQF4Mfu0SPL7B6gS+uc=; fh=bUxxhYc5apR+axnTdFXZqrOzdcR+fM95467hkTpjlhw=; b=Y7WZjFY0j8O/RpvroMthvKM3U7uVOevz7gOJTXS7lxSeicBoMCaWiRehv12ZmWvI++ 32QmhtC2lK2i+zTE+KcCYP95DZCk55jfbL0gnXVmgwUrBERIlfYG9Ed8tMwNbHLLFgTL Amehi/voAJxYYYMp4mB+BQI69GbWbSme/kb43EmWuIMFfgy34hsjE8JBs+hghTnqVg/6 Yw1Bofb1/Z3IIygZdOot7AlOXQpvE1k4mzcjthPkqaFwUWLL2IiHXqI5Yw8RaCpU1T4a vW0cbFLJH4G1T2qYWKCaRjRiPpTvdkcEVGh/5r93G4Rr5v0HqC/ufdo2BI5hT1uZuyGM P3BQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=hUfF8Cko; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-104692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104692-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x7-20020a634a07000000b005e43479dc38si3021538pga.495.2024.03.15.10.18.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 10:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-104692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=hUfF8Cko; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-104692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104692-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id ACFA0B25869 for ; Fri, 15 Mar 2024 17:09:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC84D4DA0E; Fri, 15 Mar 2024 17:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hUfF8Cko" Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A08374C637 for ; Fri, 15 Mar 2024 17:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710522276; cv=none; b=FaJOGsUOg5sUYfVTwb/cEgn5wMisXLqXD7zHFgReDS3VOVVhJrJ+LnwKZiMiFq6r4kAkThuRXFx1URjIWRERxUql8Z2gMct0par3Wm4VsqMecmsEnVZ30qAtZaC3Py5VbRjyF6BaWgmbKhpFeU43JyMqWI6CP1kcasVraKpVkUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710522276; c=relaxed/simple; bh=31Eem6k0p+zMuW1D6/xbgv2q+n+2sawV1sLU3/qFjwY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mCCDTgWKe1SWCxZmdb7nJxdJBcz+0GGztfCWOmgfCnWA+Ue23hromolgq0fp4U4VmVgGjTuPK8TAaV2pSwS/qzIIvl89/8GQNzl47HLjjclX2wJolN6msMx0CQ8UTCVkseg8m0NSL2IqbsTXtnTFjm67pMmS0ursTDJW7oSL5lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hUfF8Cko; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-36649b5bee6so3361195ab.1 for ; Fri, 15 Mar 2024 10:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710522274; x=1711127074; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/n1xeNQpebl3jFBaZdpI0WmhzQF4Mfu0SPL7B6gS+uc=; b=hUfF8CkozVu3/2bkYNoJq5HaT9IG/QADG0nkMGLfGOlcdKsykFvsS4hGABz4Uy6Qi8 QWQayvb0rq2KPX/QMUF8cUkag3FKvbb2psAXZqRBr5dCbwwpJnHGL6kD4ixXwHezIpsY YsVGOOGXiNMkDi+rHL6kiTA5AyRZxHnRvEmCcEDvz8iO7W1W7+B7JYoO7jut3w6rKYow YCBpZhIVAKngOqSKGCM5WGHaWsDZ1EZ+AdJtvD31z3pHoEQNw9P2PJ/0IMOgrsrV0hsl MoWEoB0utWrcT7pilRqoLHsDvaut4fVVoa453jwb60gyME6/mkWmHyvDUOoz6/91d1LO WJYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710522274; x=1711127074; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/n1xeNQpebl3jFBaZdpI0WmhzQF4Mfu0SPL7B6gS+uc=; b=lZI3CfYyLFmI30p9Hp2im9gcxYEHF/fEgPVpNQsC7esMhXEbFdCOxWZX5FPCOc31RF 3LWcXEb12pBOmBwIlgMd6Tl/R9kApLqMZEd6PkIos/quGycyCUKTKZPkblPnb959nN+n pkFkVcx0zv6J+XZFyZRtZ24UCdwbtVAO9ygPJxoXWz//qyDhCyMb6EWqgQYJIFobZw0H CRuwN0eYZb8HMm0QA+V8otIoK5Dc9MX8Q2OwNm4MyYutjCWZp6wCFNHo1EsilCsEuUKD dVv6vMDHQ93m1ZwUHJpnEhj8eKFCIlMwLwaq5ekVpKybiD/Kh6VXzbLGAN7v0vAxwhU8 ApCA== X-Gm-Message-State: AOJu0Ywz9Caxxbfu8On5EhS71F7cgUvT+kRyJriNrllqwlSvxkfGY9LW iGqSWnI4TfIxHmYGolmm5WCuCjCInORpz3lzzODs/BHu1MwHahbhzYc0sWvDsa8kkH1YUdbvU0s Eldfz35QXcRBnrusKh1sjzXdgMFA= X-Received: by 2002:a05:6e02:1c0b:b0:365:fe09:6431 with SMTP id l11-20020a056e021c0b00b00365fe096431mr3617938ilh.3.1710522273700; Fri, 15 Mar 2024 10:04:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240315091434.10622-1-dmitrii.bundin.a@gmail.com> In-Reply-To: From: Dmitrii Bundin Date: Fri, 15 Mar 2024 20:04:22 +0300 Message-ID: Subject: Re: [PATCH] tools/resolve_btfids: Include linux/types.h To: Alexei Starovoitov Cc: LKML , Daniel Xu , Viktor Malik , Alexei Starovoitov , Andrii Nakryiko , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2024 at 6:41=E2=80=AFPM Alexei Starovoitov wrote: > No one reported this, though lots of people > are building resolve_btfids that uses this header > as part of the kernel build. GCC version 7.5.0, GNU Make 4.1 Steps to reproduce: 1. Check out the commit e5eb28f6d1afebed4bb7d740a797d0390bd3a357 2. cd tools/bpf/resolve_btfids/ 3. make The steps above produces the following error messages (similar error output truncated for clarity): In file included from main.c:73:0: /linux/tools/include/linux/btf_ids.h:7:2: error: unknown type name =E2=80= =98u32=E2=80=99 u32 cnt; ^~~ The other sources including usually includes (directly or indirectly) before which is not the case for tools/bpf/resolve_btfids/main.c. So that looks reasonable to me to bring all the required type definitions into scope explicitly in linux/btf_ids.h. Any thoughts on this?