Received-SPF: pass (google.com: domain of linux-kernel+bounces-104730-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 15 Mar 2024 18:33:58 +0100
From: Michal Kubiak <michal.kubiak@intel.com>
To: Jijie Shao <shaojijie@huawei.com>
CC: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <shenjian15@huawei.com>, <wangjie125@huawei.com>,
	<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/3] net: hns3: fix index limit to support all queue
 stats
Message-ID: <ZfSGhhn4pkhlZh7G@localhost.localdomain>
References: <20240315100748.2913882-1-shaojijie@huawei.com>
 <20240315100748.2913882-2-shaojijie@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240315100748.2913882-2-shaojijie@huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4W7sWFM3o7Mta0M7Xo1DorWLIAdYPT6PuldN3yn3cpu2wS1W8q6/ExkIt5YC?=
 =?us-ascii?Q?riQVC25e9dvfAKYaV4SYNZClz0B0WnG8kaz9viRV/ynhJN1NZoBPc/C+LeqU?=
 =?us-ascii?Q?qOvalws2n29MrH3VH4ERoa/eUhOF2ebgElEJbPC8eHbFmiKCL7j8DiF9Ni/h?=
 =?us-ascii?Q?D+gsyxai7WnYob1fJ6oDEu3/TysL7zwauMSAzGJmMJ56wunpmAtn3vASs2wj?=
 =?us-ascii?Q?nWFfDS12kJLsdcvTvZE2Qtre6kni5+2vvKLI810DIPBYv8GPN2lSkns086Ea?=
 =?us-ascii?Q?OLyKhdYcFft5itb2xr/r0dmQm2kF+kdfctjORpH5KcuEDZJqrWmGGLuleL6l?=
 =?us-ascii?Q?ammpy+NZXe6VW0uAMJtgsA8OI0jeY9hA2F7n8Mveqg5qbr9JDDIkZ4x90ngY?=
 =?us-ascii?Q?RRWyQfcWgyjy0tHRMqwTt8vTH7Do2lWOfAvntXDNjhKDjKRkAG4R7QQXK7vX?=
 =?us-ascii?Q?zTLE1Wabo0lxCelkTAeGzyAO6rMerQJpfjxas3VVuYRc6xMP5Wm0qwRMiNAx?=
 =?us-ascii?Q?BC96jLHIY+ta4TUfCEFsm/MkoAZWz6z+GzZQUsNqG8LDPR2NjldvZ2jVPN2j?=
 =?us-ascii?Q?HRjt9aLNreaC++PYio2QnKfpErjVX2EWXSfWZbJEoOmSixVascCmTwc72M81?=
 =?us-ascii?Q?LyTGB6tDd9JUTcmpjjfTdFeudzF62UUFaN8ETjGYYh3QZPXLFQyXuQ95fKxU?=
 =?us-ascii?Q?Q9yhkaTFew1G1dzzKpTLRohdD8L1BxtyankpB0Qs35xpeeggY51OpWUMFekY?=
 =?us-ascii?Q?mrEuoQnSa0HAYjZuMy5wIW0Z1quRIfNh2CM5JNsC6oz62npcuZqEuBBMozEJ?=
 =?us-ascii?Q?dgoNJi3fJUeF6vZtgTqOXfpExGH6pZzGwire4qjKO/FLo9Lp06c0LkrjFSdv?=
 =?us-ascii?Q?SCvaMLAwlLimZf8OrYWfmyZRSn8K6HSZzaU2u36V//4jZCpYfJ38dzamygDa?=
 =?us-ascii?Q?GLEV15305wFtqHoigZUF4r4K8gU8wGVxqmA1AkktPrVXHK8VxCe10DGc0fxm?=
 =?us-ascii?Q?EcwDjYf3jvrkKBAh2p72Vs1oYCL1jycmMAApxyBW5Z3108EdxEH/Z+9DNJIx?=
 =?us-ascii?Q?dYOujLv856cUSHeowcRE4Vd1IwYs6Ivtd+oBm1dkC9ie7DGiGHb2YbzF4vXF?=
 =?us-ascii?Q?ri6llrrKGGLCJujm2t608UmXNSFGZwXmQKdr+E8TkZfMCzC0r9aNk92B5htC?=
 =?us-ascii?Q?y/esRZ7jeu6S58JrVqOymY/IkdHvEnjaKqyyYvHc27Ookrb7egBmsr6Xz/Bx?=
 =?us-ascii?Q?fNMDRbQfuyAXr6q+5SA7CfQy5SLQQeQ+s7Wqztz/lXl2AlgLXE0JXm+26zKu?=
 =?us-ascii?Q?gOTVotEYt9S90AbRB+Spaq8vxA/VYWARe7j7hcjuIFI9JUwfL44arKphZ43N?=
 =?us-ascii?Q?edG3dgRQS5Rz4gf8yt44FGM/DgDRtB5u0juP3DWrr8pxsV2Ppfx5HKJOfV/V?=
 =?us-ascii?Q?oKiwaMgoJShnm4hJmv6SYowxDRfpxvRPVCNx8WUtHzGBkC6doKypmc7yPG4i?=
 =?us-ascii?Q?vP4rdsJb6VNEJ742LD9bIc1OOvOv1UthDPpa8az04vM1VHAwfdocktDAyCoD?=
 =?us-ascii?Q?fQy2FhO185l50MeicDwxCVtjZvbtjRWy2fwbn7MBrxCsH29iWSAmrJ7UAs10?=
 =?us-ascii?Q?Vg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c3219793-44c7-4eb1-50d0-08dc45161cce
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 17:34:05.7215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0dGpnNoKZkcIfwardmO4d/s5ksI/Zz12vNNbVMUMdHvQ8TNyYoQp2hKPkgxfHfPIZPEsKMRbft7Qv6YZ/PYyvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8526
X-OriginatorOrg: intel.com

On Fri, Mar 15, 2024 at 06:07:46PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> Currently, hns hardware supports more than 512 queues and the index limit
> in hclge_comm_tqps_update_stats is useless. So this patch remove it.

typo: remove -> removes

> 
> Fixes: 287db5c40d15 ("net: hns3: create new set of common tqp stats APIs for PF and VF reuse")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  .../ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> index f3c9395d8351..618f66d9586b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> @@ -85,7 +85,7 @@ int hclge_comm_tqps_update_stats(struct hnae3_handle *handle,
>  		hclge_comm_cmd_setup_basic_desc(&desc, HCLGE_OPC_QUERY_TX_STATS,
>  						true);
>  
> -		desc.data[0] = cpu_to_le32(tqp->index & 0x1ff);
> +		desc.data[0] = cpu_to_le32(tqp->index);
>  		ret = hclge_comm_cmd_send(hw, &desc, 1);
>  		if (ret) {
>  			dev_err(&hw->cmq.csq.pdev->dev,
> -- 
> 2.30.0
> 
> 


Thanks,
Michal