Received-SPF: pass (google.com: domain of linux-kernel+bounces-104752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 15 Mar 2024 10:51:46 -0700
From: Breno Leitao <leitao@debian.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	kuba@kernel.org, keescook@chromium.org,
	"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] IB/hfi1: allocate dummy net_device dynamically
Message-ID: <ZfSKskdFpbGVgnk4@gmail.com>
References: <20240313103311.2926567-1-leitao@debian.org>
 <b4cf355e-8310-422c-8ff8-9e96d7efc9e5@cornelisnetworks.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b4cf355e-8310-422c-8ff8-9e96d7efc9e5@cornelisnetworks.com>

On Fri, Mar 15, 2024 at 12:12:15PM -0400, Dennis Dalessandro wrote:
> On 3/13/24 6:33 AM, Breno Leitao wrote:
> > struct net_device shouldn't be embedded into any structure, instead,
> > the owner should use the priv space to embed their state into net_device.
> > 
> > Embedding net_device into structures prohibits the usage of flexible
> > arrays in the net_device structure. For more details, see the discussion
> > at [1].
> > 
> > Un-embed the net_device from struct hfi1_netdev_rx by converting it
> > into a pointer. Then use the leverage alloc_netdev() to allocate the
> > net_device object at hfi1_alloc_rx().
> > 
> > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > 
> > ----
> > PS: this diff needs d160c66cda0ac8614 ("net: Do not return value from
> > init_dummy_netdev()") in order to apply and build cleanly.
> > ---
> > Changelog:
> > 
> > v2:
> > 	* Free struct hfi1_netdev_rx allocation if alloc_netdev() fails
> > 	* Pass zero as the private size for alloc_netdev().
> > 	* Remove wrong reference for iwl in the comments
> > ---
> 
> Very lightly tested, but interface came up and I could send traffic. Code seems
> OK too.
> 
> I'd prefer to at least remove the first sentence of the commit message.

That is OK for me. Would you like to remove it when merging it, or,
would you prefer me to resend it?

Thanks