Received-SPF: pass (google.com: domain of linux-kernel+bounces-104754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 15 Mar 2024 10:53:22 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>, <ira.weiny@intel.com>,
	<jonathan.cameron@huawei.com>, <dan.j.williams@intel.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<qemu-devel@nongnu.org>, <chenbaozi@phytium.com.cn>, Yuquan Wang
	<wangyuquan1236@phytium.com.cn>
Subject: Re: [PATCH 1/1] cxl/mem: Fix for the index of Clear Event Record
 Handle
Message-ID: <65f48b12b5b2f_aa2229419@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240315105336.464156-1-wangyuquan1236@phytium.com.cn>
 <20240315105336.464156-2-wangyuquan1236@phytium.com.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240315105336.464156-2-wangyuquan1236@phytium.com.cn>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dOrxr9kRwtl0DuDwt/q+BvmfwJyfiM4LqghaBv2AvAMqRkPXUlWyC6tHiZbW?=
 =?us-ascii?Q?Bb01orSRvI7ZFvR+ecoqZWxa3pnM3/62PR+UXzHIyWj/uRv5qmHBHK8GoYJo?=
 =?us-ascii?Q?J/MjQREy/LA/pqg93vBw6wVOuBTNAdddSUCHn4tY+dRekxXhVOHwwE35tNuA?=
 =?us-ascii?Q?L4VAdDngQBgzFRDnyCjyQ4wC9d7U9v6Gxs6CT0ocTlr8HXDd5QI4N8yNue7K?=
 =?us-ascii?Q?vFz+Ruaa1viLOWTuOdsbCe2Ch1RR6XRg8AAKsB0o+7QqndOMVzCVJjJCHOL9?=
 =?us-ascii?Q?OldK+B40vbfE/7os0kziI8gwcEyt3ZHKldjHmfh8Q9Oq7PTdGHX7ebgrW6mq?=
 =?us-ascii?Q?UnK+OLTmIN4CkG9LZraWAV3aHHKHvgRi3DVWFc3TmWEZO93jN5sW6heWrAu3?=
 =?us-ascii?Q?MRfScowyc2Db6SRjxg+17t4rsPKDNCCSCf86wuh0tU94xeWkPRkp6vIcQnsU?=
 =?us-ascii?Q?JGjWmVa6wnPdcJ2IBJTi70/bYz2jBAMRu+R+4/Pkf/9c0l8kBSHtnTL+RLla?=
 =?us-ascii?Q?I51OJ7eBPaBiC0dCdD73VhucyGwd79DbdRbh4s/M+gkWQOm4H7O9Jq0VkaCE?=
 =?us-ascii?Q?iJlToXU7nwYwSlT4P9M/lEN+eU2n1YLQJZrjU+TuJWW0eVKLOJfbDzWr733i?=
 =?us-ascii?Q?qien0/8rUw8YZpo1oLEIH+pD63nK1ZYshMx5X9WGLaczHdErW9CvWdchul2B?=
 =?us-ascii?Q?+t2XmQ3dScrnYb85bKBMKd9pycV6Dat94Otbgdwzo8UHRQ+3UVP4ne5dGPQA?=
 =?us-ascii?Q?FR/hYDpeWOBC0mLJg9ZYQ4yu+Iw0vc+ab6NEi71qkng7DMiIGpeFdPY0+Vtp?=
 =?us-ascii?Q?AZc+KcioXuHxBIuR9p3KEg6ZjN1O4+zlJBSrdJMHwqeJ5wruA1lB47lGZFgz?=
 =?us-ascii?Q?WRQpxuHZCAqdOsE95SJBu/Kn+JxDbOtBEIjU7ShYNf8VroonXAOh9FzdO+FC?=
 =?us-ascii?Q?b1sOiMdaXEF9MzFbySlkDMuWT/3AmgqnWV7b5AIMHnI7pf8qfXyWCuxPumik?=
 =?us-ascii?Q?ncPqV3xeSAddJbUG/o28X3HznmY1V3UQeyjH5N9Ze9CFROtaAYsX7kclRaPn?=
 =?us-ascii?Q?q0XFVF/iphSa4xDAkPb6jHrXQ2sSu+NBdY9yLVFtuKH3mZGtVDdSR3FCzTlX?=
 =?us-ascii?Q?1cKAwhJ8Qfcl4NVCm7oWi0Y77tBcY5fxg+kVYuLD01QbymeCOKR/Y5jFeVFn?=
 =?us-ascii?Q?BHNhJgzumsjelifCkzSwdeV01TFt9TAoXW0uWsM151PZaFZ+wm1W3CmxKlQq?=
 =?us-ascii?Q?aMF3M2o0G9qPnxoB8oAPEEj8CqhFgxGa/ZPWWprSwsIfTDWCxF3bdNSjVxPZ?=
 =?us-ascii?Q?8Ig1+O7lX2MRY1wQUDXO2bF7+uYDlxg5n3FGRFeag0Krng3hwUm3qdsaKsAl?=
 =?us-ascii?Q?TRu8xRk/tzXPJ9Ir0Acvv3Vp+6DwTYCZV/zM4MyJdM39f5l3kZay+NiWxUss?=
 =?us-ascii?Q?sLbMSF8E6G3ZkdWEb5ppvI+fiyPn1OOuzMa8A34FH/07bYW8UaWyCGpNCiPg?=
 =?us-ascii?Q?KTt4NSkAMbf5pSSq64hGSAOqHtQg4j/162ygDFFfVXbuZ28LGTKLtT4/jSD9?=
 =?us-ascii?Q?WCm3ZNnzJ2W2iTqDBwfE7E/x/p8hXxMtcChZZgd+RJhSIL60WsdoRUWOB7Hx?=
 =?us-ascii?Q?zQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bec1713c-6193-4b40-d624-08dc4518cfe8
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 17:53:25.1011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fmKbfjNK9Jc15AXQ8k2aWZ+TmXasYZ964BgaTcC2G1xfVPBgUPlx3SusmAVdNwG0sD639VtbGzSLAvcB8tgb4OLrSRtrbd9QmX1JGxmty8s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816
X-OriginatorOrg: intel.com

Yuquan Wang wrote:
> The dev_dbg info for Clear Event Records mailbox command would report
> the handle of the next record to clear not the current one.
> 
> This was because the index 'i' had incremented before printing the
> current handle value.
> 
> This fix also adjusts the index variable name from 'i' to 'clear_cnt'
> which can be easier for developers to distinguish and understand.
> 
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> ---
>  drivers/cxl/core/mbox.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 9adda4795eb7..3ca2845ae6aa 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -881,7 +881,7 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
>  	struct cxl_mbox_cmd mbox_cmd;
>  	u16 cnt;
>  	int rc = 0;
> -	int i;
> +	int clear_cnt;
>  
>  	/* Payload size may limit the max handles */
>  	if (pl_size > mds->payload_size) {
> @@ -908,28 +908,29 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
>  	 * Clear Event Records uses u8 for the handle cnt while Get Event
>  	 * Record can return up to 0xffff records.
>  	 */
> -	i = 0;
> +	clear_cnt = 0;
>  	for (cnt = 0; cnt < total; cnt++) {
>  		struct cxl_event_record_raw *raw = &get_pl->records[cnt];
>  		struct cxl_event_generic *gen = &raw->event.generic;
>  
> -		payload->handles[i++] = gen->hdr.handle;
> +		payload->handles[clear_cnt] = gen->hdr.handle;
>  		dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log,
> -			le16_to_cpu(payload->handles[i]));

Couldn't this patch be much smaller by just changing this to "i - 1",
because from the description the only problem is the dev_dbg()
statement, so just fix that.