Received-SPF: pass (google.com: domain of linux-kernel+bounces-104778-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
 Kamil Kasperski <ressetkk@gmail.com>
Cc: wens@csie.org, samuel@sholland.org, linux-arm-kernel@lists.infradead.org,
 linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] dts: arm64: sunxi: add initial support for t95 tv box
Date: Fri, 15 Mar 2024 19:20:52 +0100
Message-ID: <4902501.31r3eYUQgx@jernej-laptop>
In-Reply-To: <bb9f1f58-67f1-49cb-aede-046ec6258ff1@gmail.com>
References:
 <20240311174750.6428-1-ressetkk@gmail.com> <4331305.ejJDZkT8p0@jernej-laptop>
 <bb9f1f58-67f1-49cb-aede-046ec6258ff1@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Dne petek, 15. marec 2024 ob 01:57:21 CET je Kamil Kasperski napisal(a):
> W dniu 14.03.2024 o 17:50, Jernej =C5=A0krabec pisze:
> > Dne =C4=8Detrtek, 14. marec 2024 ob 01:19:28 CET je Kamil Kasperski nap=
isal(a):
> >> Hi Jernej, Andre!
> > Please no top posting as per rules.
>=20
> Sure. I'm not used to this kind of work, so please bear the mistakes I ma=
ke.

And line length should be 78 character max. Please read Linux netiquette.

>=20
> >
> >> Thanks for the reply. My board has a name "H616-T95MAX-AXP313A-v3.0".
> > Ok, we for sure need to integrate this somehow to compatible string, si=
nce
> > there are at least two incompatible versions.
>=20
> It's good idea to introduce dtsi with common configuration for both boxes=
 and add 2 new dts files with compatible string
> "t95,t95max-axp313" and "t95,t95max-axp305" with separate PMIC configurat=
ion. Similarly as OrangePI Zero got handled.

Correct.

>=20
> Not to mention, that it looks like arch/arm64/boot/dts/allwinner/sun50i-h=
618-transpeed-8k618-t.dts also has very similar configuration to my T95 box=
=2E Question is should we mix up the compatible strings for SoC?
> I know that H616 and H618 are almost identical SoCs, but if it's not only=
 a matter of documentation it's still better idea to push new dts.

Not sure what do you mean. We can mix and match whatever DTSI we want. Howe=
ver,
board compatible reflect SoC in them. So yes, if it make sense, Transpeed 8=
k618-t
can share same common DTSI, just board level DTS will have H616 compatible.

Best regards,
Jernej

>=20
> Best Regards,
> Kamil
>=20
> >> I believe these boards are two different revisions and the one with=20
> >> AXP313A is a newer one, besides incorrectly label as v3.0. Sharing=20
> >> common configuration between boxes is also a good idea but for this=20
> >> specific configuration I would be cautious. From my experience with th=
is=20
> >> board the default configuration for X96 Mate is not working at all. I=
=20
> >> suspect because of the PMIC and DRAM differences.
> >>
> >> Memory installed in X96 Mate is DDR3L and in mine T95 it's DDR3, hynix=
=20
> >> H5TQ2G43BFR, that requires 1.5V to operate.
> > PMIC is important difference, yes, but not DRAM. DDR3L is completely co=
mpatible
> > with DDR3. It just additionally supports lower voltages. Additionally, =
Linux
> > doesn't care about DRAM type and all. It's firmware responsibility to p=
roperly
> > initialize it.
> >
> > Best regards,
> > Jernej
> >
> >> The rest of configuration for both boards, like HDMI, MMC, EPHY and=20
> >> audio codec seems to be the same across almost all H616-based boxes th=
at=20
> >> I've researched.
> >>
> >>
> >> Moreover please let me update the patches and send v2 that aligns with=
=20
> >> mainline branch. I've incorrectly assumed to use sunxi fork instead of=
=20
> >> master. Sorry!
> >>
> >> W dniu 13.03.2024 o 19:00, Jernej =C5=A0krabec pisze:
> >>> Dne sreda, 13. marec 2024 ob 18:38:08 CET je Andre Przywara napisal(a=
):
> >>>> On Wed, 13 Mar 2024 18:25:14 +0100
> >>>> Jernej =C5=A0krabec <jernej.skrabec@gmail.com> wrote:
> >>>>
> >>>>> Hi Kamil!
> >>>>>
> >>>>> Dne ponedeljek, 11. marec 2024 ob 18:47:47 CET je Kamil Kasperski n=
apisal(a):
> >>>>>> T95 is a most commonly known for being a box with a pre-installed =
malware.
> >>>>>> It uses Allwinner H616 and comes with eMMC and DDR3 memory.
> >>>>>> This device comes with two versions - one with AXP305 PMIC and ano=
ther with AXP313 PMIC.
> >>>>> I have this board and it always felt like a clone of X96 Mate, whic=
h is
> >>>>> already supported in kernel, except for broken sd card detection. W=
ould it
> >>>>> make sense to unify those two boards and just overwrite or update p=
arts here
> >>>>> that are not the same?
> >>>> I think the box you have is an older one, with the AXP305? IIUC, thi=
s is
> >>>> about a newer revision with the AXP313. There are quite some differe=
nces
> >>>> between the two PMICs, though it might still make sense to share the=
 DTs,
> >>>> see the OrangePi Zero[23].
> >>> Right, mine is with AXP305. It has "T95MAX v4.0" printed on PCB.
> >>>
> >>> Kamil, does your board also have "MAX" mentioned somewhere?
> >>>
> >>> Best regards,
> >>> Jernej
> >>>
> >>>> Cheers,
> >>>> Andre
> >>>>
> >>>>>> Kamil Kasperski (3):
> >>>>>>    dt-bindings: vendor-prefixes: sunxi: add T95 to vendor-prefixes
> >>>>>>    dt-bindings: arm: sunxi: add t95 compatible string to list of k=
nown
> >>>>>>      boards
> >>>>>>    dts: arm64: sunxi: add initial support for T95 AXP313 tv box
> >>>>>>
> >>>>>>   .../devicetree/bindings/arm/sunxi.yaml        |   5 +
> >>>>>>   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >>>>>>   arch/arm64/boot/dts/allwinner/Makefile        |   1 +
> >>>>>>   .../dts/allwinner/sun50i-h616-t95-axp313.dts  | 138 ++++++++++++=
++++++
> >>>>>>   4 files changed, 146 insertions(+)
> >>>>>>   create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-t95=
=2Daxp313.dts
> >>>>>>
> >>>>>>   =20
> >>>>>
> >>>>>
> >>>>>
> >>>
> >>>
> >
> >
> >
>=20
>=20