Received-SPF: pass (google.com: domain of linux-kernel+bounces-104897-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 15 Mar 2024 20:41:21 +0000
From: Mark Brown <broonie@kernel.org>
To: Justin Swartz <justin.swartz@risingedge.co.za>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] spi: mt7621: allow GPIO chip select lines
Message-ID: <71533474-eb08-438c-b7ec-5f3277c195fc@sirena.org.uk>
References: <20240315015708.13948-1-justin.swartz@risingedge.co.za>
 <d562be73-ad76-4450-8bff-38ed5d144714@sirena.org.uk>
 <2dbc59c9133542f6f8bc465113d9630b@risingedge.co.za>
 <6c92fddd-f79b-40b5-bd52-61f43d6a7591@sirena.org.uk>
 <55c5f2e0723c18384c781e87985f0d22@risingedge.co.za>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="D8fyoBk023SaRwkC"
Content-Disposition: inline
In-Reply-To: <55c5f2e0723c18384c781e87985f0d22@risingedge.co.za>


--D8fyoBk023SaRwkC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 15, 2024 at 10:21:53PM +0200, Justin Swartz wrote:
> On 2024-03-15 19:47, Mark Brown wrote:

> > Look at other drivers that support GPIO chip selects?

> Of the 43 drivers (of drivers/spi/*.c) that setup the
> spi_controller's use_gpio_descriptors as true:

>   39 drivers use the transfer_one hook, and
>    4 drivers use the transfer_one_message hook.

> Drivers that use the transfer_one hook benefit from the core
> taking care of chip selection on their behalf.

> Drivers that use the transfer_one_message hook handle chip
> selection on their own, within the function they've pointed
> the hook at.

Oh, this is an old school driver.  Glancing at the code I can't see any
particular reason why it's not using transfer_one(), you should just
convert the driver to that which will reduce the open coding and just
generally improve functionality.  You could add a callback to flush the
write FIFO or add that into the write function, I'm not sure if there's
a meaningful performance benefit there.

> Considering spi-mt7621.c was implemented using the
> transfer_one_message() hook, I'd assumed that it made more

I think it's just old and based on having gone through staging likely
based on even older BSP code.

--D8fyoBk023SaRwkC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX0snEACgkQJNaLcl1U
h9AiQwf/UOmHNcZDrwzH7kt6mKHCl+t2aZ6FfT4MQdJ8icSErJVvBcuuQ9oJsVxP
xz1vy6RLJhwCbN5LBk2dq55XzuBxiITCjPJhusoxmvZhbYZeZYzWzzWY8aB88aFV
fyxs1trGjhla0rRAs1oNr/y5UDZFLYQvD9tBX+BWyGbous6fV7yYBycO7nYdRHd5
rsfasrQicNwMFKe1CJfKPp7GbaHPvC4drNGlDL9EaAFHGlxCp0a5ayWrLV4k1A6W
v77j7yGf8gagHBzL7wp3pTbBKfJkYxSJiyEeIvsxXpKg7cjVHMywkzWlvF9RYTvv
ZN3l1mazhE3mtXYNfbTEgMCj1iNXKg==
=gBAh
-----END PGP SIGNATURE-----

--D8fyoBk023SaRwkC--