Received-SPF: pass (google.com: domain of linux-kernel+bounces-104937-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <26841417-aee6-a996-4602-fcc00875d604@intel.com>
Date: Fri, 15 Mar 2024 14:31:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net v3] i40e: Enforce software interrupt during busy-poll
 exit
To: Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC: <pawel.chmielewski@intel.com>, <aleksandr.loktionov@intel.com>,
	<mschmidt@redhat.com>, Hugo Ferreira <hferreir@redhat.com>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Jacob Keller <jacob.e.keller@intel.com>, "moderated
 list:INTEL ETHERNET DRIVERS" <intel-wired-lan@lists.osuosl.org>, open list
	<linux-kernel@vger.kernel.org>
References: <20240315092042.145669-1-ivecera@redhat.com>
Content-Language: en-US
From: Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20240315092042.145669-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDMvOGlMUFpKdEZsRFI1VndsVHF4M3VDR0R2N2J0S3pNQlF0SkFYWWtub2Ix?=
 =?utf-8?B?VzZNdkRrendrbk10UHpVU0tPZXJrd3ZBNlVlVUFLK05INzlOY2R3VHhvdXhl?=
 =?utf-8?B?SU1WMStxT1VZVVgyQWluNEYwVnJRMnFMY1I3cXpFZHZ5YmJvQ1pnenhUM0NH?=
 =?utf-8?B?c1l5NFVuSlZPZ1lBRzl4RmhRUzdMY1dQNzE5YytuR2VhTGxVQk95MUxweGdD?=
 =?utf-8?B?ZENtVFNVWUxHcytMYW5Gb01QaEZ6Q1lLVExOa0dwYk1SWXJQZVRBK2MwVjlU?=
 =?utf-8?B?YlRGYzV0czdkN3NodERaUURQc2sxQzJENXpXWWtZem1rRkE5bWhvZVhkS0xM?=
 =?utf-8?B?Qk5lRFRORkNMcDN2SjZzZzZCbG5XTXVTT080ZXVXei9LdzZGRFpqMVdoQU9p?=
 =?utf-8?B?eHJBd24yQ0VMVXpacmc4bFJybjFPQWVZMjU5ZzA5RnYwMnpJYitVb1dVQ2NB?=
 =?utf-8?B?Y1hWaFJCWWVoUEY5TEUybGNPY0c3ZE5ZVXhNK2orM0ZpR0NjYUZBeU00N25y?=
 =?utf-8?B?YTh2RTZhTC93b0FGbFlBLyt3UkFaaXdhVy9FRXROcUNUcnAvdU82TWMvN3Qw?=
 =?utf-8?B?OHJDNW8xcHYzeHN0cHMrajhXV3hFN1NFTHl0NUhtekRmaTZPQThIM3JKdzdu?=
 =?utf-8?B?bGFnc0xsTWtydVl0V0VkK0lNZDRJY2ZUZlRpd0NwVjd2ZXVPdjVENDBNWStX?=
 =?utf-8?B?VGtncnR0SktoNmxBelQ3dU9ybUxnY3lCNkprOWpoV3NXSFBuRENKUTRKaXlY?=
 =?utf-8?B?dEdGdHRja3RYbU41UVRqRnRraktMT2FhekhXNVBkeDlVQWNFN0cxL3J0YjBy?=
 =?utf-8?B?Zng5S0Q0eEFLMWRaQ3I2SXI0TkVyZGRBczNseDBXbnZna200dVFzVFZwQ1pu?=
 =?utf-8?B?RmpKQUJjTGE5YVNQU0FwT291a1dkUWs1cy9TeUtTNVZscUtmTDg1T1NFbkk0?=
 =?utf-8?B?WmlDWHRUc3hpZk1VV08wZE42amJyb2JSTitOZTFXRG9RVmpLMWtZRUtlOFo0?=
 =?utf-8?B?T1lFd2dRTzJLZVlKRzArUXU1U2Rva1dabWw0eHBUZkkwZzFlWHp2K2xmRWQ2?=
 =?utf-8?B?L3pCRUlPY0x2c0VjcnUrODV1aTBsOHZpeVVqd2YvRlYxanFhdFoybStURFAz?=
 =?utf-8?B?TG9sT294MkRUTXVpUzhnWkRMSlErYXQwMWlueXEzVTVtRWlMZnAzaCtaUUsz?=
 =?utf-8?B?T3BBTFJ0WkJ0YzNDdjZ6S1doZFNlUTZ0dTBlUmdnMzRiTThPYk1nb1hSQ3Ix?=
 =?utf-8?B?Tm9sUkRZNEx2c0RBS0xEYXMrRWFRQ0RJYWczNStJOExYN2hQaGMxdythaUNT?=
 =?utf-8?B?RFhiSTJaRkNvRjlWbXYrYndnQy84ZmJZRnhDcWpYYVhmU1FKQ0hXR0l6cnFY?=
 =?utf-8?B?VXFKYmhwMXk1ZkVIZ1FGWGJkZGFkLytPdTA3c3VZNzl5R0JBQkgrZm0yN1ZB?=
 =?utf-8?B?SExwREEwdlYwb2tua2RjYUpHd3dTK0RNNDM2L0xHUzAzVGlIYXljaHlBUTg3?=
 =?utf-8?B?UTJWY1BNQWhzRmQrNEVzdFhSTWxaNTlUSmhJanhYd0U5UlRTSmgwYjFuekFr?=
 =?utf-8?B?Y21Ib1JDQTBtUU83VlI2WE5TdjB2TVBCYVc3NUNGV3dyeUh1L3ZrZ1JzNDk4?=
 =?utf-8?B?RzFZTmVPa1dHNjdGSFhSUVBoUzllTXB2Vm1KTVZzL2VJMDdhMDhsT1RDcXVD?=
 =?utf-8?B?SHpPREZqNEtzN2N3SURWSFdPK1U2cHl1ZDBtdzZFT2lXbjdDb3Urd0p3RzI0?=
 =?utf-8?B?czRoOHQ3THM5L2xKR25NTzU4TlZUejArZytDWkc4VWMybWxvMHd1NlVRb0JU?=
 =?utf-8?B?L1UyMkRLUnJSeTdjWm5hREhwZmdzT1ByNGYvQnVDWWp2ckloak1mMmJ4SUl0?=
 =?utf-8?B?c0kzT1NNMHN1NTYrZUxnYkx5TWYrRnFxU1NYQ2dtZ3VhSUExWFFVZ2NZVHlq?=
 =?utf-8?B?ejhIUW1MUlA3aHhJK2JpYmxqUUlrVGJtVk5GL3NGZ2NwanhJeDQvcjF1RnRm?=
 =?utf-8?B?elo2QURFYk1LQXpqVlFCSWRjYXMrdE0yRWtRb2lCa1BNcEFXN2piVG1yOCt4?=
 =?utf-8?B?bU1ZNXl2YWVDN2RLQThXL3N6dGtNQU50TW9VWXUrRFZYUVZkbmZYZ29CWjZy?=
 =?utf-8?B?RUJYbGVCNDd4RmRCQ01qT2hyTEk1TzVjdjh2SEsrb2VSZS9MdFlOS1VISjNE?=
 =?utf-8?B?anc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6afb6e58-9873-4d68-2b26-08dc453744bf
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 21:31:26.0587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ppPmdrZjWeSh3D+dX29fZBcS6xyQxNZhN1PhsWbZmLegMIYcIVpQZZLgLOGBS2dXRG3A0QPLNaIzmZI+q/zJQQgpluNsV/JrnKDoqQntgTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7387
X-OriginatorOrg: intel.com

On 3/15/2024 2:20 AM, Ivan Vecera wrote:

..

> -static inline u32 i40e_buildreg_itr(const int type, u16 itr)
> +/**
> + * i40e_buildreg_itr - build a value for writing to I40E_PFINT_DYN_CTLN register
> + * @itr_idx - interrupt throttling index
> + * @interval - interrupt throttling interval value in usecs
> + * @force_swint - force software interrupt

nit: kdoc doesn't like this style

New warnings added
1a2,4
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'itr_idx' not described in 'i40e_buildreg_itr'
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'interval' not described in 'i40e_buildreg_itr'
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'force_swint' not described in 
'i40e_buildreg_itr'
Per-file breakdown

Thanks,
Tony

> + *
> + * The function builds a value for I40E_PFINT_DYN_CTLN register that
> + * is used to update interrupt throttling interval for specified ITR index
> + * and optionally enforces a software interrupt. If the @itr_idx is equal
> + * to I40E_ITR_NONE then no interval change is applied and only @force_swint
> + * parameter is taken into account. If the interval change and enforced
> + * software interrupt are not requested then the built value just enables
> + * appropriate vector interrupt.
> + **/
> +static u32 i40e_buildreg_itr(enum i40e_dyn_idx itr_idx, u16 interval,
> +			     bool force_swint)
>   {
>   	u32 val;
>