Received-SPF: pass (google.com: domain of linux-kernel+bounces-104968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3cd275cb1f53a5fdfbf7028f233f4fd7.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240315222754.22366-2-wafgo01@gmail.com>
References: <20240315222754.22366-1-wafgo01@gmail.com> <20240315222754.22366-2-wafgo01@gmail.com>
Subject: Re: [PATCH 1/3] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3
From: Stephen Boyd <sboyd@kernel.org>
Cc: Wadim Mueller <wafgo01@gmail.com>, David S. Miller <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Chester Lin <chester62515@gmail.com>, Andreas =?utf-8?q?F=C3=A4rber?= <afaerber@suse.de>, Matthias Brugger <mbrugger@suse.com>, NXP S32 Linux Team <s32@nxp.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Richard Cochran <richardcochran@gmail.com>, Simon Horman <horms@kernel.org>, Andrew Halaney <ahalaney@redhat.com>, Bartosz Golaszewski <bartosz.golaszewski@linar
 o.org>, Johannes Zink <j.zink@pengutronix.de>, Shenwei Wang <shenwei.wang@nxp.com>, Russell King (Oracle) <rmk+kernel@armlinux.org.uk>, Swee Leong Ching <leong.ching.swee@intel.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-clk@vger.kernel.org
To: Wadim Mueller <wafgo01@gmail.com>
Date: Fri, 15 Mar 2024 15:41:14 -0700
User-Agent: alot/0.10

Quoting Wadim Mueller (2024-03-15 15:27:47)
> diff --git a/include/dt-bindings/clock/nxp,s32-scmi-clock.h b/include/dt-=
bindings/clock/nxp,s32-scmi-clock.h
> new file mode 100644
> index 000000000000..240022c1f109
> --- /dev/null
> +++ b/include/dt-bindings/clock/nxp,s32-scmi-clock.h
> @@ -0,0 +1,158 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +
> +#ifndef __DT_BINDINGS_NXP_SCMI_CLOCK_S32_H
> +#define __DT_BINDINGS_NXP_SCMI_CLOCK_S32_H
> +
> +#define S32_SCMI_COMPLEX_CLK           0xFFFFFFFFU
> +#define S32_SCMI_NOT_IMPLEMENTED_CLK   0xFFFFFFFEU
> +
> +#define S32_SCMI_CLK_BASE_ID           0U
> +#define S32_SCMI_CLK(N)                        ((N) + S32_SCMI_CLK_BASE_=
ID)
> +#define S32_PLAT_SCMI_CLK(N)           ((N) + S32_SCMI_PLAT_CLK_BASE_ID)

I think we've been recommending that scmi clk consumers simply list the
number instead of making up defines for them.

> +
> +#define S32_SCMI_CLK_VERSION_MAJOR     (1)
> +#define S32_SCMI_CLK_VERSION_MINOR     (0)

Why is this part of the dt binding?