Received-SPF: pass (google.com: domain of linux-kernel+bounces-104986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 15 Mar 2024 17:19:49 -0600
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: Rob Herring <robh@kernel.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: =?utf-8?q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, 
 Eric Dumazet <edumazet@google.com>, Conor Dooley <conor+dt@kernel.org>, 
 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, 
 Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>, 
 linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, 
 Jakub Kicinski <kuba@kernel.org>, 
 Richard Cochran <richardcochran@gmail.com>, 
 linux-stm32@st-md-mailman.stormreply.com, 
 Shenwei Wang <shenwei.wang@nxp.com>, Matthias Brugger <mbrugger@suse.com>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, 
 Giuseppe Cavallaro <peppe.cavallaro@st.com>, 
 Simon Horman <horms@kernel.org>, devicetree@vger.kernel.org, 
 netdev@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, 
 Johannes Zink <j.zink@pengutronix.de>, linux-clk@vger.kernel.org, 
 Sascha Hauer <s.hauer@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, 
 Maxime Coquelin <mcoquelin.stm32@gmail.com>, 
 Andrew Halaney <ahalaney@redhat.com>, Jose Abreu <joabreu@synopsys.com>, 
 Swee Leong Ching <leong.ching.swee@intel.com>, 
 Chester Lin <chester62515@gmail.com>, 
 Alexandre Torgue <alexandre.torgue@foss.st.com>, 
 Paolo Abeni <pabeni@redhat.com>, NXP S32 Linux Team <s32@nxp.com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>, 
 Michael Turquette <mturquette@baylibre.com>
In-Reply-To: <20240315222754.22366-4-wafgo01@gmail.com>
References: <20240315222754.22366-1-wafgo01@gmail.com>
 <20240315222754.22366-4-wafgo01@gmail.com>
Message-Id: <171054478795.2084826.7994527965167081853.robh@kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: net: add schema for NXP S32 dwmac
 glue driver


On Fri, 15 Mar 2024 23:27:49 +0100, Wadim Mueller wrote:
> Add DT binding schema documentation for the NXP S32 dwmac glue driver. This documentation is based on the patchset originally provided by Chester Lin [1]. This commit is a re-send of [2] and [3].
> 
> [1] https://patchwork.kernel.org/project/netdevbpf/patch/20221031101052.14956-6-clin@suse.com/#25068228
> [2] https://lore.kernel.org/lkml/20221031101052.14956-1-clin@suse.com/T/#me96c28bd0536de276dee941469ea084d51b42244
> [3] https://lore.kernel.org/lkml/20221031101052.14956-1-clin@suse.com/T/#m887a1b34e612f8dc0d5b718e4d6834c083f1e245
> 
> Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
> ---
>  .../bindings/net/nxp,s32-dwmac.yaml           | 130 ++++++++++++++++++
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
>  2 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml:5:10: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240315222754.22366-4-wafgo01@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.