Received-SPF: pass (google.com: domain of linux-kernel+bounces-105011-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 16 Mar 2024 00:31:00 +0000
From: Wei Yang <richard.weiyang@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Wei Yang <richard.weiyang@gmail.com>, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org,
	linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
	Michael Roth <michael.roth@amd.com>,
	Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH] x86/head_64: move parameter close to call function
Message-ID: <20240316003100.4vgiatdsnm77irhg@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20240315041420.12802-1-richard.weiyang@gmail.com>
 <CAMj1kXFRG8notqdt7toS9n3V-Y0KPHZBr3kZBJredCACMSubfw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMj1kXFRG8notqdt7toS9n3V-Y0KPHZBr3kZBJredCACMSubfw@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 15, 2024 at 10:10:06AM +0100, Ard Biesheuvel wrote:
>Hello Richard,
>
>On Fri, 15 Mar 2024 at 05:14, Wei Yang <richard.weiyang@gmail.com> wrote:
>>
>> startup_64_setup_env is first introduced by 'commit 866b556efa12
>> ("x86/head/64: Install startup GDT")'. Then 'commit 469693d8f622
>> ("x86/head/64: Re-enable stack protection")' insert some code which
>> leverage %rdi, which is removed by 'commit 8f6be6d870e8 ("x86/smpboot:
>> Remove initial_gs")'.
>>
>> This left the parameter of startup_64_setup_env a little far away from
>> where it is used. Let's move them together for better understanding.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> CC: Joerg Roedel <jroedel@suse.de>
>> CC: Michael Roth <michael.roth@amd.com>
>> CC: Brian Gerst <brgerst@gmail.com>
>> CC: Ard Biesheuvel <ardb@kernel.org>
>> ---
>>  arch/x86/kernel/head_64.S | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>
>The code that you are fixing here no longer exists.
>
>If you are going to send patches in the middle of the merge window,
>please make sure that you are at least up to date with Linus's tree at
>the time you send the patch.
>

Thanks, will do it next time.

-- 
Wei Yang
Help you, Help me