Received-SPF: pass (google.com: domain of linux-kernel+bounces-105104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 16 Mar 2024 08:22:05 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Jingbao Qiu <qiujingbao.dlmu@gmail.com>, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, 
	palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-pwm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, 
	dlan@gentoo.org, inochiama@outlook.com
Subject: Re: [PATCH v5 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC
Message-ID: <jtqqbpr4qeo4m5oetmmusf2hy2wy6hnpstl344p2hu62vbbqrk@tefqeoqf37jh>
References: <20240314100131.323540-1-qiujingbao.dlmu@gmail.com>
 <20240314100131.323540-3-qiujingbao.dlmu@gmail.com>
 <ZfT42gzJhVd1NQzd@xhacker>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="s4lgqmjnyk5h5zzy"
Content-Disposition: inline
In-Reply-To: <ZfT42gzJhVd1NQzd@xhacker>


--s4lgqmjnyk5h5zzy
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sat, Mar 16, 2024 at 09:41:46AM +0800, Jisheng Zhang wrote:
> On Thu, Mar 14, 2024 at 06:01:31PM +0800, Jingbao Qiu wrote:
> > +static void cv1800_pwm_set_oe(struct pwm_chip *chip, struct pwm_device=
 *pwm,
> > +			      u32 mode)
>=20
> Did you get any information about the capture support pwm controller?

Instead of adding capture support to this pwm driver, I'd rather see
support added to the counter subsystem. That's more versatile.

See https://lore.kernel.org/linux-pwm/Y3aze3B6%2Fe5uWS%2FH@fedora for
some more context.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--s4lgqmjnyk5h5zzy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmX1SJwACgkQj4D7WH0S
/k6F+ggAks6uSCJiH1mbc45Emop15Wur2v3K91t2QJSqBoijti/USWld2/ZtveTC
EcqQzoSjZP4QrYxr+jQybwfgNad47KtT/+IEOiq7Fhg8trvMiBTr5IUJUiQl3aSl
qy3Iz49T0pBsm9FVzYcc9MB2B8I12hl1MHHAM+nh0p2gGeuwu3p89aFHCKgfnD08
3qikAnMFFVotItY+XhhQ6lgYw7PW89bD8HFbpEirHukSpzjuTA9SzAjcNXc+AC0T
N64SQHAl/N37RGUdUiABy/Md3WrMxY4CD3+/cllXgSzj5P+QyT75RMzSrjDtlKaI
IEHPm8ZLCn756hNE8bCRBy4BxQU6zg==
=3u2N
-----END PGP SIGNATURE-----

--s4lgqmjnyk5h5zzy--