Received: by 2002:ab2:6486:0:b0:1ef:eae8:a797 with SMTP id de6csp235642lqb; Sat, 16 Mar 2024 01:52:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXsAc1e/cRLBrNIO4sJecqu5i9TQaHDndPLnKkrRiRCeRUmebqGWsL9py5Ht3y1Vc3xStR3XQ6MP1c1Xi7786KXyzN2O9p0jMaq1WLPXg== X-Google-Smtp-Source: AGHT+IEWbKo1NAy/MudbhS9svf+NvE5JOePmHxXu/CrFFmvNvLC35mo115rGWvzLLfNQSNQPUjOz X-Received: by 2002:a05:6808:3c88:b0:3c2:34c3:9804 with SMTP id gs8-20020a0568083c8800b003c234c39804mr6562447oib.33.1710579163685; Sat, 16 Mar 2024 01:52:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710579163; cv=pass; d=google.com; s=arc-20160816; b=BlyLqAj27YKtfhASWhtYyVgp6hWlM3DXzNrdH1Zw/DOnSxHL1RDCcmswy+5Xp6AEPH NfrqoGdROmxWSgViioEd67FmY7ECo0lVAJ0tftynP7YNfqB8NRGmPBXbLaZAhPl8RxMW qGzmTRDecY7/MLI1MHIh0jd1QO9Widm8O2NdBetu9ZImTCBiJ2xN2c7EIQneUO5Uw+6I iXSkGR4Put4jcO2mcjbfhl8iCyKyUqqc11AdeIbg7HuZVywX7iBSrK5FlWMNzEb8Sqhs oBXPWHs7JZX2MGy3czyYoDMfl4ENqVcj/NDuj/8M/FYbIvgpE2NDwI4sZ71j5sSk5SBW nvwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Uhr5t9ipDhLvDJsivQMnFJlaxBgq4Z64elmk0VV5RMw=; fh=P6EI6cEdkd7EwkRtBHTDJ0MWUbXJX7UZSED/uVlg61E=; b=j1i8BDgA6wt2G5lSaPg4tb8OtMfkWKRuWd0HM7gGKQfexc6emLV74Lu/u64j+O0MdK /8Y5rPQQjUmZ4qskO76hhaSqbJ2TX9CnFrkaDpb5LAavzvhaXI2ZXLtziJmXna+eKYV2 wud00YMaTrYHH5QJA1EVrfIpK9Mqj03xwhETsdGX+LEWg1wfFdX64Z4jcZOP4ex2f8O6 DbVMoHt22kPK6FwYlXBwyM2RxMsrYEZadMD7MDh+3hPexWtGQ0KQJmmy7dZ/QIgzAH0d 53K/Gc5pwLcmSqcML5m6mi0bK3jP/1qbhXZrr08dSIteQG4n7+gMnTd2WVhmgGxfmue7 +HHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-105119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105119-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i5-20020a63d445000000b005dc96170131si4085363pgj.766.2024.03.16.01.52.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 01:52:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-105119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105119-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 47FDF2821F2 for ; Sat, 16 Mar 2024 08:52:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2BFC10940; Sat, 16 Mar 2024 08:52:35 +0000 (UTC) Received: from mail115-63.sinamail.sina.com.cn (mail115-63.sinamail.sina.com.cn [218.30.115.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B37CBD27D for ; Sat, 16 Mar 2024 08:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.63 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710579155; cv=none; b=oq3N4QpshcYjfhvx65tl4xXxrBKk+NjoDP/QVR5dHa5H1yVx6uNW+8NphBOF8nNGaK750XWMZZBAN6VXWOSKDcr8hD2SXnY9H1Kz6if4MzZ7sDG6wG1oKVdkww0RCSa2uRDX2vCor6/7ZtaKHPlSVMjM8xAmPD1LceNqbH2VGek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710579155; c=relaxed/simple; bh=6ooMEYug8biKx7VZdn3SdFzIEdqjcFYgiuy+RGh9MjY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qtr/VmczwjCpaHTqjF3Tu+xXot3IgjoHkKy8pGYXumrztvo+JliGX3iGhQ5AplMhUtWcga/+kzQS4SGXkDKOA7KzO4qWZ6DkQAXcUytGjIFDxYhS30hmk8cTKyHqFqs9004eo9sbaU7ZfFPjljAhFJVLlArLmEv7KU0bjj71Ahc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.25.117.148]) by sina.com (10.75.12.45) with ESMTP id 65F55DC300009983; Sat, 16 Mar 2024 16:52:21 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 76942431458057 X-SMAIL-UIID: DC3F8470115B41159AB8B91E9E770289-20240316-165221-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [sound?] possible deadlock in snd_timer_close_locked Date: Sat, 16 Mar 2024 16:52:11 +0800 Message-Id: <20240316085211.1816-1-hdanton@sina.com> In-Reply-To: <00000000000099d9850613b12348@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fe46a7dd189e --- x/sound/core/timer.c +++ y/sound/core/timer.c @@ -409,8 +409,9 @@ static void snd_timer_close_locked(struc struct snd_timer *timer = timeri->timer; if (timer) { - guard(spinlock)(&timer->lock); + spin_lock_irq(&timer->lock); timeri->flags |= SNDRV_TIMER_IFLG_DEAD; + spin_unlock_irq(&timer->lock); } if (!list_empty(&timeri->open_list)) { --