Received-SPF: pass (google.com: domain of linux-kernel+bounces-105165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5178c9fa-711a-4a91-ba1c-4b10da7592b3@huawei.com>
Date: Sat, 16 Mar 2024 19:17:55 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <shenjian15@huawei.com>,
	<wangjie125@huawei.com>, <liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as
 UNEXECUTED
To: Michal Kubiak <michal.kubiak@intel.com>
References: <20240315100748.2913882-1-shaojijie@huawei.com>
 <20240315100748.2913882-4-shaojijie@huawei.com>
 <ZfSOZG5vHbIY3IFU@localhost.localdomain>
From: Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <ZfSOZG5vHbIY3IFU@localhost.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


on 2024/3/16 2:07, Michal Kubiak wrote:
> On Fri, Mar 15, 2024 at 06:07:48PM +0800, Jijie Shao wrote:
>> From: Jian Shen <shenjian15@huawei.com>
>>
>> Currently, loopback test maybe skipped when resetting, but the test
> typo: maybe skipped -> may be skipped
>
>> result will still show as 'PASS', because the driver doesn't set
>> ETH_TEST_FL_FAILED flag. Fixes it by set the flag and initialize the
>> value to be UNEXECUTED.
> Fix it by setting the flag and initializating the value to UNEXECUTED.
>
>
>> Fixes: 4c8dab1c709c ("net: hns3: reconstruct function hns3_self_test")
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>

Thanks，

I have sent V2 to fix them.

Jijie