Received-SPF: pass (google.com: domain of linux-kernel+bounces-105213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 16 Mar 2024 16:41:09 +0100
From: Jiri Pirko <jiri@resnulli.us>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@linux.com,
	penberg@kernel.org, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev,
	42.hyeyoo@gmail.com, peterz@infradead.org, mingo@kernel.org,
	danielj@nvidia.com
Subject: Re: [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed
 allocation macro
Message-ID: <ZfW9lVhnClqr9Han@nanopsycho>
References: <20240315132249.2515468-1-jiri@resnulli.us>
 <171412ef-1a93-3e56-2b7b-3baf83233eb2@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <171412ef-1a93-3e56-2b7b-3baf83233eb2@google.com>

Fri, Mar 15, 2024 at 10:39:02PM CET, rientjes@google.com wrote:
>On Fri, 15 Mar 2024, Jiri Pirko wrote:
>
>> From: Jiri Pirko <jiri@nvidia.com>
>> 
>> With introduction of __free() macro using cleanup infrastructure, it
>> will very likely become quite common to see following pattern:
>> 	type *var __free(kfree) = kzalloc(sizeof(*var), GFP_KERNEL);
>> 
>> To follow the CLASS() flow from cleanup.h, introduce a simple macro
>> KZALLOC_FREE() to wrap this over and allow the same flow.
>> 
>> Show an example usage in gpio-sim driver.
>> 
>
>Seems highly specialized especially for kzalloc specifically, so not sure 
>this warrants its own macro.

Yeah, but having like 2-3 macro variants would probably cover vast
majority of usecases now. The rest could still do things manually.