Received: by 2002:ab2:6486:0:b0:1ef:eae8:a797 with SMTP id de6csp514449lqb; Sat, 16 Mar 2024 14:10:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWLxw4ydsMBOZhosoTx6EtZd7uFfv55f7rFyn/TdyfMzmIn8nT+JjblA0S8XCDboG8npwIWqdjpAq3u50EobKD/lAjgw5G7J8eZrMw4fw== X-Google-Smtp-Source: AGHT+IGIMEvEDm0Pfv+7m116R7PHtcQ2VxermBDcYsjxFPj1UBAJF6N4orVbcsJtoFn0NIv/5dgZ X-Received: by 2002:a05:6808:1304:b0:3c3:5226:72b9 with SMTP id y4-20020a056808130400b003c3522672b9mr10292206oiv.54.1710623431496; Sat, 16 Mar 2024 14:10:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710623431; cv=pass; d=google.com; s=arc-20160816; b=d9tF8ZwbK2hGI/83RmvFnPwKnGIjbwbllwUUkaFnxEQWRBaCSMad4WVt6BczubZDi6 MUE/sAaeAHlRfb6862iHlO2aPlnJdMv5jni5LYMeAhr/V1ldwXyW/5YvX11uXv+l1nn7 +yghZEpKAueT6vT+Jn0Lew5uPK+KutkMpNK2rzj6xqQKJGvL97nkI/rT9HLSeesntWXk OVSeBrTsdIev1tmYSHipd8y8FsabwRFoNND7/vmNh/TGqoo/orAJVCv+CuDTliJxAzPA JICINegsKrX1yz+Zj9Kv26RicQi12PXz7gZQBH23ywe7jB+Rn7Rd5yx47xN4czD6VAUm WL1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=13ysREvRIfRyhIebo3XESHYKkRzY1Wqd/fThUQgveOA=; fh=qUJ9Fi6S9JJAjxoifz2soPjP12X+cL5oj7/J6745gYw=; b=LaBKKPU/a4f/3TMaoZxNouTo+QKSzCMhEb6No7CI5TiMSKYgNSsULfk5MsYOnhc8rN afBT6kFUxKgc8Wa4/nHYFEyyMhW+h1YLxCWrelUIEw/4/ygt+M2o2pHvBYd06RVjCrYn SlcwLZKbhAFdcZ62KExaDNtmACd53hUhl2iGsZvNzA9jlIgIiIrCrjKNZAFEJznKCNa8 NHlBwmViotF7LSk6N6b4GJtghz88uDbXErHuMYfUB89Hu4s0S3/tlzcIBZTq5B4v4bl1 DveZ6Rtjnekdht/8MZ0PXz8lGedMOjejqSrb3e0e+B/Ag4XMCi+0HKaWSROg3eaFKOQh zNTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=i4uvy6T5; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-105292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bw42-20020a056a0204aa00b005cfc084b80esi5565286pgb.221.2024.03.16.14.10.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 14:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=i4uvy6T5; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-105292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 58891B20F58 for ; Sat, 16 Mar 2024 21:10:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CBC631C6B4; Sat, 16 Mar 2024 21:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="i4uvy6T5" Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C987C1C6A5 for ; Sat, 16 Mar 2024 21:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710623063; cv=none; b=B+u4RH4h3Eac+sMFlfvlp3Pgxf3Zfj1toHvxXp0opKq7m3a99qDsHgjo0LfXaR06C6enKlM8xRJyD2fUc1EIyxl/UEcbVYEHWi+1/aERhRfYY6Dcea1pkecWuZvOgvFda5+ByB6WJC7pgM2LNUrZm9R90jHhUpxzZVcCoDDIaCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710623063; c=relaxed/simple; bh=6wwdtUF1IZ2XtlCHQx2ubpP9SCPuKDIXG7ZJS2cK1Zw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C1R2qk/2PicZEZYLYfugLeOd7vt1L3e2P4IE7v1TmHvvZsQpPctnlb5u8j2tSdTbvBh8pgmySwo7YcmYG+CoFcpxOlxheGyit9yqaOws/x1ppQfompeLFbmqVdHAKk+OzSB2aybEhwhvM6DxrK5/5MjGv58/pBRpUDIvgxyNgsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=i4uvy6T5; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Sat, 16 Mar 2024 14:04:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710623058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13ysREvRIfRyhIebo3XESHYKkRzY1Wqd/fThUQgveOA=; b=i4uvy6T5Rw32a4b1sjxEuMpV9lTE2Z3CJpjE+BdcfZUB1XYoOdMzfxqa7Wt5AKC+vP0m3k lnVBdSTi6zvDGJ3TndOL8xiTsYPmWwLkyPtjm28Bd54VV69WXVxAbzs/TUQ9X13h2Erjw9 PgUwRbwh6qo1bvtKxH7KWtxNuHI8HhI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: add NULL check to obj_cgroup_put() Message-ID: References: <20240316015803.2777252-1-yosryahmed@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240316015803.2777252-1-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT On Sat, Mar 16, 2024 at 01:58:03AM +0000, Yosry Ahmed wrote: > 9 out of 16 callers perform a NULL check before calling > obj_cgroup_put(). Move the NULL check in the function, similar to > mem_cgroup_put(). The unlikely() NULL check in current_objcg_update() > was left alone to avoid dropping the unlikey() annotation as this a fast > path. > > Signed-off-by: Yosry Ahmed Acked-by: Roman Gushchin Thanks!