Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755833AbYAHVAi (ORCPT ); Tue, 8 Jan 2008 16:00:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753430AbYAHVAb (ORCPT ); Tue, 8 Jan 2008 16:00:31 -0500 Received: from ns2.suse.de ([195.135.220.15]:52584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753431AbYAHVAa (ORCPT ); Tue, 8 Jan 2008 16:00:30 -0500 To: ananth@in.ibm.com Cc: akpm@linux-foundation.org, lkml , mingo@elte.hu, Jim Keniston , mhiramat@redhat.com, davem@davemloft.net, hskinnemoen@atmel.com Subject: Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot From: Andi Kleen References: <20080108063334.GA29385@in.ibm.com> Date: Tue, 08 Jan 2008 22:00:24 +0100 In-Reply-To: <20080108063334.GA29385@in.ibm.com> (Ananth N. Mavinakayanahalli's message of "Tue\, 8 Jan 2008 12\:03\:34 +0530") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 20 Ananth N Mavinakayanahalli writes: > kernel/kprobes.c | 2 > kernel/test_kprobes.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++ Can you put this somewhere else please? I know there are already some test files in kernel/* but imho they all belong into some other directory. + if (!err) + init_test_probes(); return err; Couldn't this be just a normal initcall? Perhaps even a module_init(), then it would be possible to use as a module too. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/