Received-SPF: pass (google.com: domain of linux-kernel+bounces-105403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 17 Mar 2024 14:37:39 +0000
From: Conor Dooley <conor@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matt Ranostay <matt@ranostay.sg>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible
 check
Message-ID: <20240317-bakery-numeric-a34b928efa6d@spud>
References: <20240316-max30102_binding_fix-v1-1-e8e58f69ef8a@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3m7Apa/RWUaBOpCe"
Content-Disposition: inline
In-Reply-To: <20240316-max30102_binding_fix-v1-1-e8e58f69ef8a@gmail.com>


--3m7Apa/RWUaBOpCe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 16, 2024 at 11:56:57PM +0100, Javier Carrasco wrote:
> The "maxim,green-led-current-microamp" property is only available for
> the max30105 part (it provides an extra green LED), and must be set to
> false for the max30102 part.
>=20
> Instead, the max30100 part has been used for that, which is not
> supported by this binding (it has its own binding).
>=20
> This error was introduced during the txt to yaml conversion.
>=20
> Fixes: 5a6a65b11e3a ("dt-bindings:iio:health:maxim,max30102: txt to yaml =
conversion")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>  Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30102.=
yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> index c13c10c8d65d..eed0df9d3a23 100644
> --- a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> @@ -42,7 +42,7 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: maxim,max30100
> +            const: maxim,max30102
>      then:
>        properties:
>          maxim,green-led-current-microamp: false
>=20
> ---
> base-commit: c1f10ac840caced7a9f717d4170dcc14b3fac076
> change-id: 20240316-max30102_binding_fix-898e7c94cce9
>=20
> Best regards,
> --=20
> Javier Carrasco <javier.carrasco.cruz@gmail.com>
>=20

--3m7Apa/RWUaBOpCe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZfcAMwAKCRB4tDGHoIJi
0iQVAQDqnSYSNHsDNk/8FIR4UROHkzfm7B7BmeUbEVUcYw+gIwEA47Rm8mdO6nPq
1tpXINAFvlSKjbaAvg9+B+ayG6xtqwM=
=5kuB
-----END PGP SIGNATURE-----

--3m7Apa/RWUaBOpCe--