Received-SPF: pass (google.com: domain of linux-kernel+bounces-105456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 17 Mar 2024 15:49:11 +0000
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: clock: samsung,s3c6400-clock: convert to DT
 Schema
Message-ID: <20240317-jersey-trolling-d4678546e87d@spud>
References: <20240312185035.720491-1-krzysztof.kozlowski@linaro.org>
 <20240317-curator-smoky-99568f9308bc@spud>
 <60039f49-a20d-49b9-8a3d-2ded499435a4@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Kk6uFwGcxqpNcnbw"
Content-Disposition: inline
In-Reply-To: <60039f49-a20d-49b9-8a3d-2ded499435a4@linaro.org>


--Kk6uFwGcxqpNcnbw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 17, 2024 at 04:26:55PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2024 16:23, Conor Dooley wrote:
> > On Tue, Mar 12, 2024 at 07:50:35PM +0100, Krzysztof Kozlowski wrote:
> >> Convert Samsung S3C6400/S3C6410 SoC clock controller bindings to DT
> >> schema.
> >=20
> >> +description: |
> >> +  There are several clocks that are generated outside the SoC. It is =
expected
> >> +  that they are defined using standard clock bindings with following
> >> +  clock-output-names:
> >> +   - "fin_pll" - PLL input clock (xtal/extclk) - required,
> >> +   - "xusbxti" - USB xtal - required,
> >> +   - "iiscdclk0" - I2S0 codec clock - optional,
> >> +   - "iiscdclk1" - I2S1 codec clock - optional,
> >> +   - "iiscdclk2" - I2S2 codec clock - optional,
> >> +   - "pcmcdclk0" - PCM0 codec clock - optional,
> >> +   - "pcmcdclk1" - PCM1 codec clock - optional, only S3C6410.
> >=20
> > I know you've only transfered this from the text binding, but what is
> > the relevance of this to the binding for this clock controller? This
> > seems to be describing some ?fixed? clocks that must be provided in
> > addition to this controller. I guess there's probably no other suitable
> > place to mention these?
>=20
> To make it correct, these should be made clock inputs to the clock
> controller, even if the driver does not take them, however that's
> obsolete platform which might be removed from kernel this or next year,
> so I don't want to spend time on it.

I think the comment should probably mention that these are the expected
inputs, part of me thought that that was what you were getting at but I
wasn't sure if instead they were inputs to some other IP on the SoC.

--Kk6uFwGcxqpNcnbw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZfcQ9wAKCRB4tDGHoIJi
0jbjAP0el+zfqXU/1GH/ci5i68AFLqupDHz+2uX0i/EiXkqgwgD9FSPzzbqPkxlg
rMx2MTgf2+caqhXEviVOR/fol7xARgk=
=QuI7
-----END PGP SIGNATURE-----

--Kk6uFwGcxqpNcnbw--