Received: by 2002:a89:2d5:0:b0:1ef:f8eb:5d24 with SMTP id d21csp38221lqs; Sun, 17 Mar 2024 09:27:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV5OFCoJ9UJopd6c/cXBXnst7OdLOw1lG02FyAHnn3v7ztEOgv6Ea7GqshOD5FZ0FTCSGH9/LxPRaMapkZSADK9J/IH047gQy+wpI1Org== X-Google-Smtp-Source: AGHT+IHcc9eRziH0KYN0ebjk8ExN2szyTTsxNDcLlvRjIw5DYSGfkbeH2LkfZKd/FA7hFWtnfeOJ X-Received: by 2002:a05:6808:1a06:b0:3c3:66e6:ecae with SMTP id bk6-20020a0568081a0600b003c366e6ecaemr12080700oib.34.1710692859273; Sun, 17 Mar 2024 09:27:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710692859; cv=pass; d=google.com; s=arc-20160816; b=jyoUEj2nrUBwxgfeNaFNi+tDzxtSA0Fo0XbC1dmREa3Kmfg9k2NddPv083oGwOlx07 GZ01D/6utVqPzZ54aeK+xTpbD1SsIV5Juym6XF6GEqPy3K+WyVOHsfaPX1/N/1Ryr67B TkOpSskX1E+QGDSkqBCTj2T4m3+sVGuzMFvJ0g/dev+6YrOVXdKqek4+fP1krof6pJez Byjs7hjMmqCG3y9bcyargQRUwCYUJEzu8hlAL29lNWzUNsMUaNQWsMN8C0TKN7mjOXvT 1JebiolWBh9SDC2CjgSP/aM8i7vvr72YX1H3RnEs7Qn9TRtBOeiWFti0/ngYTucVtb8t sPng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UskOP0A0m3huiTp8WYB6u5yehxNlSpJMfI7NzML4HhA=; fh=tNR7v1sJIBwTv9eYRXQDtSRs9r3OTV6/RJrYbcoDQfM=; b=pD8jPQc+gPToq6LAFc7s3FoTFp5qnUNevsyteqFzc61WVQyLh4tOdxjU9dfqN7Z3cx EZvody3nftHPSplr2WsQb97xU0HaX9ArmuXBNv+u+FZFanjc3cTFpJlrKFUKRuQE6T3z QLqpG5uHHEAYbhYryk+4AgFXAtTg/knRMqEkIPB7aKwveZPdEdRhSx04TTzEXobi8aVr hDGhER1vv6xDANlM+B9+tkO8KOVbaKmkohZRMQd4SgorSwpBeQZgOPa/T+ZcSYuf08cL 5/s51BPym0SzRQTwNFVb2JC3hDnHpFU3OAm9IijI4h2ZQSND0uFrqUwRi95afzku/3QY w7Dg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nuxCTcSw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105468-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105468-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id vw7-20020a05620a564700b00789e7b73bd5si4572839qkn.324.2024.03.17.09.27.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 09:27:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105468-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nuxCTcSw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105468-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105468-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 00B251C20CCF for ; Sun, 17 Mar 2024 16:27:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 673EA1CF8A; Sun, 17 Mar 2024 16:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nuxCTcSw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A49A1CD2A; Sun, 17 Mar 2024 16:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692846; cv=none; b=NRuX+ghaPSv73z/MzOQPY326/hexk6ndvuollRvwt0oFcRx9z0Jp74wNi+kz4T4SKg/iTK7SJ2CP3sDkUD2KKKh6ReZmWW/o60DJCch71TppWJcPEWh0nlfGRLFbWX4Lsat6KWyN/jO10EP/hvQheNT1QtqIj/IMMPzG8XfpDiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692846; c=relaxed/simple; bh=/sMe+0qb19ZKYZJ2RQShEwagtkA6NxLUpEjBWbZDHVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bkD5yc9QN8pBHGtCWPMYohYq0FkVQi7EOG9xfkt5aAPICiww6BYedIabV25RaOxZXOD2mRdwbWfMzNVAt7VCq2m7XUpXjVo+SaX3eTf1HzyAOlTxbI0VAu1C7jIVDeRiprXmHIl+xBFdMmMkzaDxAKAiTRxTuxF5KWBr59veQsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nuxCTcSw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFFBAC43399; Sun, 17 Mar 2024 16:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710692846; bh=/sMe+0qb19ZKYZJ2RQShEwagtkA6NxLUpEjBWbZDHVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nuxCTcSwdHSKoPzO08uyzDdixIUJpcGVuKh7EhhtzM7tda4HhedOs+7SJevGiW0kx yfrwowq2BI1tyqFTEvTIBC0ZaXfJuvlTOzd44Is1jbZQdyPQ3ZO+wYX/0RphNuwB5l wgI5+yl+2KeG/H1uYLQvmP39lWBE63n5GFViJhNUWWJH8C7GWa08wlpkGros3IXy45 L2SxR8yq2owzB/Lh+MyqoAW/ZchpLYDzIl/Y6MEpmX2F+efTwGQ/+nnuJ8RRw0H/8C 7/OtTicETfxh6mf8Muf34VYbc6Ew94qJHBd6raURTmRJ1E9vlmsP58o1FfmO6Fm/0B 45v8CA199RGog== From: Bjorn Andersson To: Konrad Dybcio , Sibi Sankar , Gabor Juhos Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] firmware: qcom_scm: disable clocks if qcom_scm_bw_enable() fails Date: Sun, 17 Mar 2024 11:27:17 -0500 Message-ID: <171069283518.134123.12387132556718627972.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240304-qcom-scm-disable-clk-v1-1-b36e51577ca1@gmail.com> References: <20240304-qcom-scm-disable-clk-v1-1-b36e51577ca1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 04 Mar 2024 14:14:53 +0100, Gabor Juhos wrote: > There are several functions which are calling qcom_scm_bw_enable() > then returns immediately if the call fails and leaves the clocks > enabled. > > Change the code of these functions to disable clocks when the > qcom_scm_bw_enable() call fails. This also fixes a possible dma > buffer leak in the qcom_scm_pas_init_image() function. > > [...] Applied, thanks! [1/1] firmware: qcom_scm: disable clocks if qcom_scm_bw_enable() fails commit: 0c50b7fcf2773b4853e83fc15aba1a196ba95966 Best regards, -- Bjorn Andersson