Received: by 2002:a89:2d5:0:b0:1ef:f8eb:5d24 with SMTP id d21csp38282lqs; Sun, 17 Mar 2024 09:27:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCmu3FvsWE6aga652CFjm7AcYq93S/O8TdXDSvA89Xzy7hZ4I1ik1S2QWqc8O4j4bJkQ41W2Fp5aAXiaxaxPgHsijDKi+w3DKBPUhkOg== X-Google-Smtp-Source: AGHT+IEpXw4vHldSmfRG4wtuEjpOR/od1m2e/xhHATRqWvwQuhlcZiUFkNvnJkBYRRdYWl7FNHNM X-Received: by 2002:a05:6214:c68:b0:696:1c3b:ecf3 with SMTP id t8-20020a0562140c6800b006961c3becf3mr766603qvj.7.1710692870630; Sun, 17 Mar 2024 09:27:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710692870; cv=pass; d=google.com; s=arc-20160816; b=h/GXdCJpZWxhyjJjwoQ2mJ88/TnaVNP5ZVVTfXcOdPIAtblfAD5B+l6dgmuH7TLI5k hd425WU+V7tvOAwHVGDkfEBLFpzQ1VoHPTILWGcfVipKJF7Arh3aa07f3jE6daDCJFYf NXcAtW3nL/AA7EXqeK+o037dcSFqM3i8oIsAckV2/zIfcl18YSe3bKt6kJr89DEYWC/h +MOBqCVeI1h/W6KmUa4OqkABg236i5h6SQYfgTdeqj2ZSKeEgmBUc5CXNlFpDjrePCY6 JDZvMh87dauYAFHO8EjygveR3R9hPpASPVehoB6T1rtyJRxccuS4UurD8ZlTwm9XtWwJ hxmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=wCM9PWfjMo5K2r4bKuZNlBef38FhkLEo4BQJIPPapBY=; fh=KbDIGN0/mqJUq6ORkAyL6pPLo5znLhQ2ZFJbODjU1Zc=; b=WgmnVVAIkdgIHnOvhpS/WuyAT8DHSskfD0Ld+yL0nR3etUab9hwEpSNJhjcvLXMYNv Tj5258C/2Hzs0YjrgdTWzomn1RShUAbUsSI1A4c5ecuXRFYVrLp5SItd2DaOoeY6xLcY +kOab86L5aT69AU66EcIKPfdVzeaBmeaVsfEGxh+R2NhXG3FjMvR1p+SIJrJdxW/kJ3l kaSQA2jc8teYcRFLAuKS/f05KtVk7V7jFaAkm414AVqEr59SE68+zhNhGrKUiVCF6s1W pu1HoOpXCqSZ7Kgh7dBUQpCvJNMMuL9BPJ4zPsDGa2p9pcGVo0YFrxGCBhmNVaoCoomy wvbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K3AM7ez6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 2-20020a056214202200b00690a5b8a999si7314778qvf.234.2024.03.17.09.27.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 09:27:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K3AM7ez6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105469-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 520741C20B0A for ; Sun, 17 Mar 2024 16:27:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53F1C1D545; Sun, 17 Mar 2024 16:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K3AM7ez6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2221CF8D; Sun, 17 Mar 2024 16:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692847; cv=none; b=D80x4AvIUxmMlxhK/z6wdWewn86IWZ58c3eegEbcGGe0WOuw1VgnQYJFg4h7/giV64IWuEuVFzKsjXMUoxesMraqSsj+ZbJtYS4H8R+r0eNVY9MCXTstgBAS0K28Hp3WRy+PjpDh+vj+19rIaMuFC8Tpfe8Ja9XI7EIZJVyIOSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692847; c=relaxed/simple; bh=27b4hlI4WVrl3Vmvz0wh8OMrbMtXF4kn/OE1t3LC8lg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QNWo8XAm1C9nPtevKTEoz86A2tYcP1fVFTYheKt/e6z4Z9HlZTTvYnbVMWFdmU1n4PjJgKxc/+ujZj6y9X0KDsv8JbLwGvbM1f1AdX0RhM+558EOlFzlKQeSIXL7eG9appZrT3UxUCF307rHKWdKxK9+LIzOe1h6KsqRFMwahQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K3AM7ez6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A43BEC433C7; Sun, 17 Mar 2024 16:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710692847; bh=27b4hlI4WVrl3Vmvz0wh8OMrbMtXF4kn/OE1t3LC8lg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K3AM7ez6FjWtx/wAV926cLvLb/NsyY6j2t3XFM9EOl9gjUipxha68JgygjrrGh7PU DztTnwW93oEHcffLy8jBdbjnxY2iIqIXOhFe/Rl3Fk72NkB2JF43J/uTW8ADZmnfWY J02mVHAeK71CDgZe9fMkVL1ZiLKmIxkgIRQs3Wrnexh8mYd/7J+9XcBLtporPaTeDq jH1EsBXY6F0Ew1Rxk1Agcee+GFQ/KljlvvnwZz1gcZAkb/CbFApgKeJ3b+ZPiIOib/ iB1UIY87JFdUfLBAS0zm3LqZyFqVItMSFjLy+hoy7zyEKQxM6bUDWPBcZFBZ9myAaw 6X2wR83E0L9hw== From: Bjorn Andersson To: Konrad Dybcio , Gabor Juhos Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() Date: Sun, 17 Mar 2024 11:27:18 -0500 Message-ID: <171069283518.134123.17425854027960478350.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com> References: <20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 08 Mar 2024 10:25:07 +0100, Gabor Juhos wrote: > Since the qcom_scm_probe() function returns with an error if > __scm->path contains an error pointer, it is not needed to > verify that again in the qcom_scm_bw_{en,dis}able() functions > so remove the superfluous IS_ERR() checks. > > Applied, thanks! [1/1] firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() commit: e6f3dac9cf11eff1daddeaa69521370c8941a5f9 Best regards, -- Bjorn Andersson