Received-SPF: pass (google.com: domain of linux-kernel+bounces-105541-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 17 Mar 2024 14:06:25 -0600
From: Rob Herring <robh@kernel.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: linux-kernel@vger.kernel.org, christophercordahi@nanometrics.ca,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org,
	linux-sound@vger.kernel.org, herve.codina@bootlin.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 02/13] ASoC: dt-bindings: davinci-mcbsp: Add new
 properties
Message-ID: <171070598512.2141016.568175668659767924.robh@kernel.org>
References: <20240315112745.63230-1-bastien.curutchet@bootlin.com>
 <20240315112745.63230-3-bastien.curutchet@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315112745.63230-3-bastien.curutchet@bootlin.com>


On Fri, 15 Mar 2024 12:27:34 +0100, Bastien Curutchet wrote:
> Following features are not described in the bindings:
>  - The McBSP uses an internal sample rate generator to provide bit clock
>    or frame clock. This sample rate generator can be programmed to be
>    driven by McBSP's internal clock source or by an external clock source
>    (located on CLKS pin).
>  - McBSP can be configured in 'free-running' mode so that its serial
>    clocks will continue to run during emulation halt.
>  - McBSP can generate a SYNCERR when unexpected frame pulses are detected
> 
> Add an optional clock item that allows to select an external clock as
> sample rate generator's input.
> 
> Add a 'ti,disable-free-run' flag to disable the free-running mode. This
> mode is selected by default by the driver that's why I add a disabling
> flag instead of an enabling one.
> 
> Add a 'ti,enable-sync-err' flag to enable SYNCERR generation when
> unexpected frame pulses are detected.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
> ---
>  .../devicetree/bindings/sound/davinci-mcbsp.yaml | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>