Received-SPF: pass (google.com: domain of linux-kernel+bounces-105560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 17 Mar 2024 14:14:16 -0700
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, fstests <fstests@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: [RFC PATCH] xfs_io: add linux madvise advice codes
Message-ID: <ZfddKAS2GUOG41wb@infradead.org>
References: <20240314161300.382526-1-david@redhat.com>
 <20240317165157.GE1927156@frogsfrogsfrogs>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240317165157.GE1927156@frogsfrogsfrogs>

> +#
> +# Check if asm/mman.h can be included
> +#
> +AC_DEFUN([AC_HAVE_KERNEL_MADVISE_FLAGS],
> +  [ AC_MSG_CHECKING([for kernel madvise flags in asm/mman.h ])
> +    AC_COMPILE_IFELSE(
> +    [	AC_LANG_PROGRAM([[
> +#include <asm/mman.h>
> +	]], [[
> +int moo = MADV_COLLAPSE;
> +	]])
> +    ], have_kernel_madvise=yes
> +       AC_MSG_RESULT(yes),
> +       AC_MSG_RESULT(no))
> +    AC_SUBST(have_kernel_madvise)
> +  ])
> +

I don't think we really need this check, as madvise and asm/mman.h
have been around forever.  We can probably also drop most of the
actual flag idefs, probably for everything older than MADV_WIPEONFORK.

The rest looks good to me.