Received-SPF: pass (google.com: domain of linux-kernel+bounces-105582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240226201517.3540187-1-irogers@google.com> <0b2ff06f-099c-424a-97b5-fdf638892e41@linux.intel.com>
 <CAP-5=fVTOgOO=N7uf4CaANWu+WCCLXXMuNBnDdBOP3E6vijG_A@mail.gmail.com>
 <2b950564-fe20-4426-ac91-5b40a2087099@linux.intel.com> <CAP-5=fURvd4nx_-QLgRBWSoJbXDUqO=WbsLkqMgjiyucXHVrjw@mail.gmail.com>
 <ZfSvwBQRBhfWGb98@x1>
In-Reply-To: <ZfSvwBQRBhfWGb98@x1>
From: Ian Rogers <irogers@google.com>
Date: Sun, 17 Mar 2024 16:04:17 -0700
Message-ID: <CAP-5=fUxw21-1SXBbaPoGgvZv98E5k+V6KGM41e=8XTFhyQohA@mail.gmail.com>
Subject: Re: [PATCH v1] perf vendor events intel: Add umasks to PCU events.
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 15, 2024 at 1:29=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Wed, Feb 28, 2024 at 08:12:10AM -0800, Ian Rogers wrote:
> > On Wed, Feb 28, 2024 at 6:55=E2=80=AFAM Liang, Kan <kan.liang@linux.int=
el.com> wrote:
> > > On 2024-02-27 9:12 p.m., Ian Rogers wrote:
> > > > Kan, what's the right way to deal with this?
> > >
> > > There is no umask in the uncore spec. Please see P120 of the spec.
> > > https://www.intel.com/content/www/us/en/develop/download/intel-xeon-p=
rocessor-e5-2600-v2-product-family-uncore-performance-monitoring-reference.=
html
> > >
> > > It should be occ_sel.
> > > The occ_sel =3D (the umask from the event list >> 6) & 0x3.
> > >
> > > I don't think we want to change either the kernel or the perf tool.
> > > There is nothing to help either if we add the occ_sel in the original
> > > event list. So it seems the only choice should be handling it in the
> > > convertor tool.
> > >
> > > Is it possible to check the UNC_P_POWER_STATE_OCCUPANCY.CORES_C0 in I=
VT
> > > and use "Filter": "occ_sel=3D0x1" to replace "UMask": "0x40"?
> > >
> > > It seems everything in the filter will directly be appended. Is my
> > > understanding correct?
> >
> > Yep. From the manual:
> > C0 =3D 1
> > C3 =3D 2
> > C6=3D 3
> > So I'll need to fix all 3 events during the conversion to perf json.
> > The same problem exists for haswell and broadwell, so I'll do the fix
> > on those architectures too. I was able to test on a jaketown but the
> > kernel source makes me think the same fix is necessary there too. I'll
> > send out a new patch with this.
>
> Please clarify if this remains reviewed and should be merged as-is.

v2. is already applied in perf-tools-next [1] so we don't need v1. Thanks,
Ian

[1] https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.gi=
t/commit/?h=3Dperf-tools-next&id=3Ddd267d056fed323f1684fa52d2a864fc93ca3be0

> - Arnaldo
>