Received-SPF: pass (google.com: domain of linux-kernel+bounces-105594-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <252d1ba7-0ae0-4616-9ee7-f7c204531eaa@infradead.org>
Date: Sun, 17 Mar 2024 16:47:44 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] init: open /initrd.image with O_LARGEFILE
Content-Language: en-US
To: John Sperbeck <jsperbeck@google.com>,
 Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>,
 "Peter Zijlstra (Intel)" <peterz@infradead.org>,
 Thomas Gleixner <tglx@linutronix.de>,
 "ndesaulniers@google.com" <ndesaulniers@google.com>
Cc: linux-kernel@vger.kernel.org, Nazerke Turtayeva <nturtayeva@ucsb.edu>
References: <20240317221522.896040-1-jsperbeck@google.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240317221522.896040-1-jsperbeck@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 3/17/24 15:15, John Sperbeck wrote:
> If initrd data is larger than 2Gb, we'll eventually fail to write to
> the /initrd.image file when we hit that limit, unless O_LARGEFILE is set.
> 

Could this be related to
https://lore.kernel.org/lkml/CAHY78BqCpMQptPN0SMaXuRqHOhYi+wnMEUSTYt7OHDZih4e7yQ@mail.gmail.com/
?

Thanks.

> Signed-off-by: John Sperbeck <jsperbeck@google.com>
> ---
>  init/initramfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/initramfs.c b/init/initramfs.c
> index 76deb48c38cb..b607d3463b47 100644
> --- a/init/initramfs.c
> +++ b/init/initramfs.c
> @@ -683,7 +683,7 @@ static void __init populate_initrd_image(char *err)
>  
>  	printk(KERN_INFO "rootfs image is not initramfs (%s); looks like an initrd\n",
>  			err);
> -	file = filp_open("/initrd.image", O_WRONLY | O_CREAT, 0700);
> +	file = filp_open("/initrd.image", O_WRONLY|O_CREAT|O_LARGEFILE, 0700);
>  	if (IS_ERR(file))
>  		return;
>  

-- 
#Randy