Received-SPF: pass (google.com: domain of linux-kernel+bounces-105612-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 18 Mar 2024 09:03:19 +0800
From: Feng Tang <feng.tang@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>, "Peter
 Zijlstra" <peterz@infradead.org>, <x86@kernel.org>, <paulmck@kernel.org>,
	<rui.zhang@intel.com>, Waiman Long <longman@redhat.com>,
	<linux-kernel@vger.kernel.org>, Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/tsc: Use topology_max_packages() to get package
 number
Message-ID: <ZfeS16iHtEYsqs5m@feng-clx.sh.intel.com>
References: <20240315112606.2248284-1-feng.tang@intel.com>
 <ce02f1a8-870f-41bc-8650-4bd6103f9637@intel.com>
 <87r0gbjk17.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87r0gbjk17.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2VNSLFi3P6um6gsSvXrH0PR2CseL1THD706pi1hDfKN+ldpFl7yqkvw9Q+Fo?=
 =?us-ascii?Q?nwd7hVYONhdoTmKTrIVMaeqDyH4PQcrkAskGXwmMDpUbnUWDkEStiS0IsgWU?=
 =?us-ascii?Q?JWyJ3sh8UHKLA3VB1fjlXyC7ErRMaRXXRvDQFcU0cLmxiyzI+Lj43HzgKUQv?=
 =?us-ascii?Q?H8YB3MLOR3ORQ4cT495+HoSp12WUAnzvxdXc29JwW4efHyNy8CIJWqpahhAm?=
 =?us-ascii?Q?DaJPbvms//HmxFPcxXdLiUfu2OjkcPowpBDoj7t5cfKMde0w2yyk8eKzWH5k?=
 =?us-ascii?Q?oljS17CtqwqVEl6j2wj+XTDfHOr878uRKw9FD37OKgIpNlqgOXsKuUMOS8+V?=
 =?us-ascii?Q?Gmtgc4EF18sTXaI7NCyhQHjev+CE3LlnGaIZkBWEcAK3GChiI1EWETxHDeSY?=
 =?us-ascii?Q?+v7w2yuq/XVFB0ufKITumq8/+H6vJEFhS2hRE/s7enV468divlwZEwCwz8+/?=
 =?us-ascii?Q?69Ra3wPmnDBgCSkUuV9XbJRPj7oH4iHFDRZOlK6C2yVhdo1qzjRt9quMdDhy?=
 =?us-ascii?Q?fSSAqV0txsioi/HLvfqoA5ZlfAQ8VVPpoy6V5gymjBZahT8f4vj2PEXa2bSf?=
 =?us-ascii?Q?R6DMayAKtja9YZRuzgYmnyXlBthUOdGR58SSpEMU7Tk9Tgjq1OTMIoUT+9Uq?=
 =?us-ascii?Q?uLlHtkza8JVElqIWHgrY2S1r4QMqCj8jt+hhtlraIyBtr6VwOEX48bh+7vnW?=
 =?us-ascii?Q?MSpEEvxYHF4xNTxsJChx/ufVFRlepWljgKFW78Ve1tY2HTNktV1Z/KIWpbQH?=
 =?us-ascii?Q?rh1fQsPV9/te4BnqwPXzaF5N9lwAwjjmbPXi23pcwvwGrIlYrYAZjtTa0NsX?=
 =?us-ascii?Q?2gaf1vtcr+QK2XAGHH0QCmptq4OZWvMH8ZECj9ErxZkyB+SLGdTS19wmgwrz?=
 =?us-ascii?Q?W3dPtNNSeJgnviLJhWT6q7i9rCunNTzUPhPeGjfXGeg9JaEKmPwWGf9rnSGl?=
 =?us-ascii?Q?Y7H3jg6YgpjRIPtIbsMV9Q9zaxMevLJ69rLIwU8uHsTJoOpHBVSZgCrjQIup?=
 =?us-ascii?Q?aGMH6JlY/mLTtB159/0oEvBEGUo3Zd+KKLEqggiGoAF4u2/T4/7TLRFjiSZq?=
 =?us-ascii?Q?qRl9kZIq6zmCOwq0iDA2TWV42ttSWsMqUeQYV5xPcVmxVYT/Rkk81yw0loIn?=
 =?us-ascii?Q?E5DIeu1tN4ENn0mz4CSYn6odUDWOyIXAc7M8AwFvyqndwWYQD+dRq1lMDnMb?=
 =?us-ascii?Q?5Gp6s7prkQNlOScmmKzsLkGm2s4GttxRG9I+EHrcl7rVHE9usiLtFsVvpg0k?=
 =?us-ascii?Q?O/ZBOCRkjIl0Ohr+hezpTcsFdsS2lNWzEDVX54dgjgXcPQriH4l56CfZz3N8?=
 =?us-ascii?Q?HPfw93jP78ekgarBkbsfuJxdUgVjqJLNjiP4KTV+GAA1wVkitsv1ehcG9NFv?=
 =?us-ascii?Q?UMIFwC1cxG499h2dXWpxZm3Dc79adp56Cer+DezSE/UvyrYOUzkDeaaLY68m?=
 =?us-ascii?Q?dSSRMgF7wPjlNOlsN/zlf08j8EFiOSRgJLgCpZ226+USEkJDX/pw1jKdyaFt?=
 =?us-ascii?Q?XvU6YmjHjR3BZBcUlHUbODp5EZI3JlgBIJYDhg3gxsDKI8YZ7koORsgiDjDi?=
 =?us-ascii?Q?jPNmKBc0RobyRfHRpJbERBjHa5NKQJ+94Ti7YrPK?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf0cce7-a578-4152-248f-08dc46e926a3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 01:17:17.0564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PGwHL32kN4ua22Oo2iYSrZGPpGj/5UfZqSxTT1FjqOnpNwXlZKZbmAQyhb4XCQK0hWDP9+Wb2wyP26dVI28wtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6526
X-OriginatorOrg: intel.com

On Fri, Mar 15, 2024 at 09:51:32PM +0100, Thomas Gleixner wrote:
> On Fri, Mar 15 2024 at 10:58, Dave Hansen wrote:
> > On 3/15/24 04:26, Feng Tang wrote:
> >>         /*
> >>          * Today neither Intel nor AMD support heterogeneous systems so
> >>          * extrapolate the boot cpu's data to all packages.
> >>          */
> >>         ncpus = cpu_data(0).booted_cores * topology_max_smt_threads();
> >>         __max_logical_packages = DIV_ROUND_UP(total_cpus, ncpus);
> >
> > Because Intel obviously has heterogeneous systems today.
> 
> Hybrid is a per package property. 
> 
> But neither Intel nor AMD support populating multi socket systems with
> random packages, where socket 0 has less cores than socket 1 or socket 0
> is hybrid and socket 1 is not.


Before posting the patch, I run the latest upstream kernel with your
topology refactoring patchset on one AlderLake and one MetorLake box,
and they both show the number of package is 1.

> 
> > So I'll buy that removing 'nr_online_nodes' takes NUMA out of the
> > picture (which is good), but I want to hear more about why
> > topology_max_packages() and '4' are the right things to be checking.
> >
> > I suspect the real reason '4' was picked was to give the calculation
> > some wiggle room because it's not actually all that precise.
> 
> IIRC the TSC is only guaranteed to be synchronized up to 4 sockets, but
> my memory might be wrong as usual.

Yes. I did try to increase the bar to '8' with a patch, and at that
time Peter Zijlstra mentioned there was real issue with TSC found on
some old 8 sockets machine.

Thanks,
Feng

> 
> Thanks,
> 
>         tglx