Received: by 2002:a89:28c:0:b0:1ef:fe5e:92fe with SMTP id j12csp6402lqh; Sun, 17 Mar 2024 18:24:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVsjrmJyblzRW4BD4I1w0EHCkJhiS88wUdctKO//L2uGov1w3KPKfyNaSwvOaoQvsnNRNjY4KqXgdrARfgp2pfF2y5hVC8lE4zVGRq8LA== X-Google-Smtp-Source: AGHT+IHV5Q8d4SYfUEfjyU59TlRPqruWxOpvo+mgQonnGfQO+d6x+oFceFECEHkxB7+NE5xNbyK7 X-Received: by 2002:a05:622a:5786:b0:42f:2056:dd1e with SMTP id eh6-20020a05622a578600b0042f2056dd1emr14516083qtb.38.1710725060748; Sun, 17 Mar 2024 18:24:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710725060; cv=pass; d=google.com; s=arc-20160816; b=p/cMmyWW/KdB41mYtjJn2JWCpSKZvvYlkRyS/0DpQ9fJt46OuERIoKDKFZwFgJoNIK q7jbDSxBPoXLLQfaV29v0w+0BNf29qWr9FtOmdu6bRLoA74CtyCEsJ3T0U0SYqkuzAzw 16TLgexwcMhAfp8S8m75ddcjRuXnkdGKbJ4rxpevZf2Ldw2QUI7VQBUHD4/IzCCvAjt5 3oZKLtOQ/zETjrD5EtegJagaVWBJKo9TrV2hndAR7sPeSs+hpqat06VhSyNZr6wY8jIF f65673hIXI7LTkW0T7mLjuKvAET8zLfZW+jXvM7ZLVUggQoOSomYoFqQbLBX034GeGHO jqgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=k13RKKfyS+W6o1ljeljbabEH0+v70vV4nAEczmhMgOA=; fh=G0KuHVZnRNIt56YOj1GkhswEESRFwLxgYw+k9kF+Msg=; b=nYNJDZG/BaJvYs+TWBksHbPR3XNSIPZsZSRNLUChjW4Nvjx++xjY1f3ATfL3WDmTed 6Koi4BQV+ltWXdFS1FIb94PRsji/ZfLb2aUsbBXlvtBFOz/hV1nPlrdttPVGTG36W+1Y kDBxJAXX5C1iG3efPVfWpSfgpD8rAEXxu4NlwnQb/EehygZPU0q+TlTkKeGww549Y4Ht PafKJ5j+SWuvCVeNidYq5YJil7Qts0jWAYllqVdNTolAQnKg7ieqHdUuCvKfFVk8IlHQ 8xLNZVz4vnSj37V+/kxarxYg93nPByAjU6pt7by3kmP0W78H7JDzUTDItFQvk/ri1Dyf agOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uQozQc8g; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id k13-20020ac85fcd000000b00430cb9c2ca9si1933234qta.39.2024.03.17.18.24.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 18:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uQozQc8g; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 75E1F1C20AC2 for ; Mon, 18 Mar 2024 01:24:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5026F1CFAD; Mon, 18 Mar 2024 01:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uQozQc8g" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61BC3179AE; Mon, 18 Mar 2024 01:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725049; cv=none; b=nVePsXl3wu8lwJlTIk4royGm+CAma/7eha2UL9eqAvHKHTIhwMiaHh9JCSSbk7jUPqEVv628yOzN/LsnxQigIdvmmUcbZj4rflyHAvQBzs1dWDrl5WmCZLzGTGm/rQ0gkRGsSNRCmA7KM8AWDdP16NmC8wS9ygTGxdz+NAtHNpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725049; c=relaxed/simple; bh=+wfvHnwJWpfZDGn/7Sn97aBeOjz4tC3+nHOqRiSkpxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gW8cASwbPvCcWcit1LAXje6u3XfC1+EQapy8cLN6qJGUtVanhEfZZ87YxMmXLrbp10t3LNiQ/cZ9KimJTcK5qv0Br6hTJZlH8vb9AFHi1lzBh+CBUPhRiAIWgeejvjX8gqix5ubb1c8G2ugoN6slbEQmuFTMSE7YG52FNLUbf/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uQozQc8g; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E21D1C433C7; Mon, 18 Mar 2024 01:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710725048; bh=+wfvHnwJWpfZDGn/7Sn97aBeOjz4tC3+nHOqRiSkpxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uQozQc8gbodC6KvNGzCsF9tEaq1ZXPHr/ZCwmtz+4zNnZaaAeaolAH4IiW7BtsiXD A++0Do+rE427NeibdWKRcW2D+CoctBncoYacjXixE7QZ1J5U+LQo2ZJKd7yABOq1Fd KkP1sN39X2oA6G64NSbbWwYQk8Ds8HEbBzsF3CU9ls2nVmMYqWxU9nUINN4as1bE8Z PB/BvjjGbY2tgBT2S1lbaKPpB05s+Bpq/oytolz89AMYApRqnzs/KjaoDKjdR9Uh5B aUecHpRB2dQOOSZ4FYufrOgujp34GQ1c0j83eoX0TSXFKo9ebmyoF7jEespYlPz77G vB1tKj8wH3X5A== Date: Sun, 17 Mar 2024 20:24:06 -0500 From: Bjorn Andersson To: Johan Hovold Cc: Bjorn Helgaas , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v4 3/5] PCI: qcom: Disable ASPM L0s for sc8280xp, sa8540p and sa8295p Message-ID: <5o5vbnxfsiokjf2ahrppr26oyuqhwhdos3374r3zpexunhc5j7@yquaupvfywbz> References: <20240306095651.4551-1-johan+linaro@kernel.org> <20240306095651.4551-4-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306095651.4551-4-johan+linaro@kernel.org> On Wed, Mar 06, 2024 at 10:56:49AM +0100, Johan Hovold wrote: > Commit 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting > 1.9.0 ops") started enabling ASPM unconditionally when the hardware > claims to support it. This triggers Correctable Errors for some PCIe > devices on machines like the Lenovo ThinkPad X13s when L0s is enabled, > which could indicate an incomplete driver ASPM implementation or that > the hardware does in fact not support L0s. > > This has now been confirmed by Qualcomm to be the case for sc8280xp and > its derivate platforms (e.g. sa8540p and sa8295p). Specifically, the PHY > configuration used on these platforms is not correctly tuned for L0s and > there is currently no updated configuration available. > > Add a new flag to the driver configuration data and use it to disable > ASPM L0s on sc8280xp, sa8540p and sa8295p for now. > > Note that only the 1.9.0 ops enable ASPM currently. > > Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") > Cc: stable@vger.kernel.org # 6.7 > Signed-off-by: Johan Hovold Reviewed-by: Bjorn Andersson Regards, Bjorn