Received: by 2002:a89:28c:0:b0:1ef:fe5e:92fe with SMTP id j12csp7449lqh; Sun, 17 Mar 2024 18:28:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXVO00u9680e9bXTiKQHUbVx8rgqmeYcTh68ilHZ/htl9T8C7go1gUl7JvXIJ3p7rZ2nYKCrC4qcMMBsal/4OzaU+B9e7j+AkXrzZ9cZg== X-Google-Smtp-Source: AGHT+IE8ZKKbQ1PuHYuh776hwEDSzDS3CBy3FJFakBWV4m7+wSxgfrR2U8K386/pH/1IbVeawzvV X-Received: by 2002:a05:6a00:803:b0:6e5:cd5c:620a with SMTP id m3-20020a056a00080300b006e5cd5c620amr14585332pfk.16.1710725287574; Sun, 17 Mar 2024 18:28:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710725287; cv=pass; d=google.com; s=arc-20160816; b=VGTfVmo2K0R5oGXTwM/nEpDzjEsskM74OtZ1+w9oTusYLc59lcQcqHtBQ2n8CLFiV/ Kn5UntylWcKiWy+02zRXOUPsL7YlOe37qccLPgQFmokV8HojEjTA7Dvc7L8meB4xlWTw 1qhdB/yKzlw0bUsJYHgS5QeWiF+wMnjHzXc0BCGRQqNj3OrlZdiStVQzzcNGITUoeJxA Cx6oXLCH7YndAcOJmj0L57puRqM9bzABNKNDKJrTTwUSlDdfB6oUy6NSPiPQuqSNIOyW DNl6WaJWgBmTrqWHo203+X2qvk4jTbx3iz/1dqEFG2224Qq4jqepOuPvT3SwFXAKSkA6 w0kA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lRdW3PYkD/OPzFWYyYpSj4xxmx30lL3IhH3s4RkXMPc=; fh=ADadgPmiGG5lfSIvgyff2kizc/oVZesenTaX08mIqrY=; b=0/LsuMe/ZQbw2MJXfrPbRYYqd6FZJIPR1/S7QDKF1yXKWdA1PWCpQfgBG0LFY4mbPQ feEcSdl7Xn0LAhSFkIczu+qBOmv3cwvA/NQuoHsH/3dT1n76JEXjTlNS6B/gNYDt58Rg 5s1GY+Tau9F4WewjypaXycdgaBfoPbILDfYazvxNLvlM0J8UdUxbbLDK7hjIAZhE84ya l5kYLaL/J9JubXe6pWodFRSywWaHHvsRmbgw6sDEa46HV6V6UjD2/rDkYWXF8UD7r67s oM7E/Vbr0B+dShBJPur+IrGYKqXowKjku6CrS8AiuEwrf5kMPOj6YeQ5MAeMCMAiB8fe SyYg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mAZqwJus; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105617-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f3-20020a63de03000000b005d8bbd208desi7112945pgg.163.2024.03.17.18.28.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 18:28:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mAZqwJus; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105617-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1C4AB280E0B for ; Mon, 18 Mar 2024 01:28:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 668941CFBC; Mon, 18 Mar 2024 01:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mAZqwJus" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 753CD1CD07; Mon, 18 Mar 2024 01:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725276; cv=none; b=QIaFhdtuecS7skmpojejXTusE7xV6+H7voZvfc7IcBxvO6OdKefiRYExbEWeiUiASeROXwIFsbPGbuCJo58wQ27641ZfcPuqx4zR9M3f61cnFvbrvjFvN6aWizU/csHGgywIeYcsJua9CwzwPU9aTEaoW3Bjgp9tf9SsKnB7dSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725276; c=relaxed/simple; bh=RhB/nWWwoCQMMHLsN2PtqvPB+ZkEomggWeNkRLQBVUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bLsmpKNpUAH6nxdY1qlO3iGcoFHYK5flGqF4I9iAn3jdagxuraBYcExPO1dbB0P3X9baCBzfiXYXLYCwE4KPR5IfG2MEH5gQNxFtLLlat0tio3X6inTqitzNmxWLwAzo+S4m+afjo7mYF6ylwF6i5By0HyGEcmDY5zqxlrNPjx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mAZqwJus; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0F4C433C7; Mon, 18 Mar 2024 01:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710725276; bh=RhB/nWWwoCQMMHLsN2PtqvPB+ZkEomggWeNkRLQBVUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mAZqwJusQJZXb2OJMfT+mDfrdyC8ILUSY2QKpsvTPvP5oVcLiZ9GyhibASy3ausGx 5JHmg3fBSOTc4NkezKfvT82kSECEFp049Z5SpFxh6nbg/natLPSx+uRbgvLJn9T3Rm AJIctURuGRrhcyszXa/oo5r/qhwp+e49EzTkjq0aPo+IlbR7ATcaKCiENjaAplVGaB BKZi9HQVhh9mamrTZoWwMWSjwngbgodqh5rXnjSb4scBrNsZr17vogzbxn2/2W5Aow 08qpNcTQeweb+KERctFkLLKDCgS9DTFwqBBIE6OSqZDrsQrgz3QSrS+y/tYxRb0HuA obxAj+9QY/NNg== Date: Sun, 17 Mar 2024 20:27:52 -0500 From: Bjorn Andersson To: Konrad Dybcio Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thara Gopinath , Amit Kucheria , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , stable@vger.kernel.org Subject: Re: [PATCH v2 2/3] thermal: qcom: lmh: Check for SCM availability at probe Message-ID: References: <20240308-topic-rb1_lmh-v2-0-bac3914b0fe3@linaro.org> <20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org> On Sat, Mar 09, 2024 at 02:15:03PM +0100, Konrad Dybcio wrote: > Up until now, the necessary scm availability check has not been > performed, leading to possible null pointer dereferences (which did > happen for me on RB1). > > Fix that. > > Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") > Cc: > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson Regards, Bjorn