Received-SPF: pass (google.com: domain of linux-kernel+bounces-105627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 18 Mar 2024 09:18:35 +0800
From: Feng Tang <feng.tang@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "bp@alien8.de" <bp@alien8.de>,
	"x86@kernel.org" <x86@kernel.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "hpa@zytor.com" <hpa@zytor.com>, "mingo@redhat.com"
	<mingo@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"paulmck@kernel.org" <paulmck@kernel.org>, "longman@redhat.com"
	<longman@redhat.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/tsc: Use topology_max_packages() to get package
 number
Message-ID: <ZfeWaxlGBIO1J2Jd@feng-clx.sh.intel.com>
References: <20240315112606.2248284-1-feng.tang@intel.com>
 <ce02f1a8-870f-41bc-8650-4bd6103f9637@intel.com>
 <f9da97d86e5599edca74fa859053ba9caf2b4d9c.camel@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f9da97d86e5599edca74fa859053ba9caf2b4d9c.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qldzb3B6SVRKMUJaSmhsY2FSTU9ucm5WaDNRankxQjkrSHNsR3V1d0pHdjRY?=
 =?utf-8?B?eGx5cUFIbEgyc0pLbjBsNThnemtseDVhc2FqTlJsSEVOMDB6UGhLZlh2Ui9D?=
 =?utf-8?B?NnkxL3NGeElNSHhyTUZ2NjdvN1lnSkdEQ0l4dStsNElaeGpVb3dRVkVYaHc0?=
 =?utf-8?B?STFEdnVhamVIMFpnTWI4N25aVDRSUGhHd2ZnaTRpU3NoYjlrcFBFS3BEL2Rz?=
 =?utf-8?B?VytNNUFQc0dNdmJQS0dtMDY4S0FoVHlsSG5kQkFOeEthaVpjWWNRU3phem9U?=
 =?utf-8?B?N3BaZjFGclVzSGFPbmdhbmJGVkpnaHVVUkI4clpRWjBLcjhMNjJzRnlxOC8x?=
 =?utf-8?B?aWU1NzdVeVFQdkQ1TURiVkxBamM3WjE1TjN6VDJtOVZMTjNXZkk2MzYwMzVq?=
 =?utf-8?B?RGN4UHFkWHNVZTdPdjJQMFBuNHNmbi9vMW9rOTAreG5GckJnR0RnRmpzN1Yv?=
 =?utf-8?B?bWRxYmxFME9UVVJMZlU3akZ1Z1p3akVmazVIN25vcXZVZ3V2bU9uRWN3UzJU?=
 =?utf-8?B?Yk5RRkpMWlNZWUVENTY2ajN6UnV4YWloSnorODJ0Y3FaVWhKcXorb3AycXA0?=
 =?utf-8?B?em4vSk15K3hOL1dYZm5aN253bURuYVNpQ01TZmJDME5Ja2F6OUtnUDlaMlhh?=
 =?utf-8?B?amk4czQzN042dmt5VFhmbCtueVRSdjRma2gvcXBuQmQxQkZzZGM2Y1hxd2ph?=
 =?utf-8?B?NVo3QlFJTEZEbm9NczZlVHpqQklZclZJSlgrM0p2NEEvTTAyVXJ3SlNBUDJh?=
 =?utf-8?B?OTREMXNZOFJrLy93RjhCYmJUNjRJMndkVWszeUx5Tnc4L3FzV3Z6RHdUdmxS?=
 =?utf-8?B?blJpUTZYK2pITG14eVlPaStDK080bWh5b0l0bm1KRHZlRndsUEZ2b3pNV1Bq?=
 =?utf-8?B?cWNUUHozMk5razhoMytRUi92WTdjU3N1Y1kwTTY4aHlQa2M3cktLVlZTNkRr?=
 =?utf-8?B?SkJQRWdvWlRMM1FmSjBJMjdPVVJSOGtJNzU2WmQxQ2trd29lWWJ2ZzZXSm5U?=
 =?utf-8?B?aDJiYVZWSk9oSXJaemZhMERydG9VQjE1R3UrZHVuQTRpNHZkdFM2RVlmWlpX?=
 =?utf-8?B?NEZRTzQ1Sm1TeXljNHhFbEpwTmlXRlNBUGYvcUc4THVHc1BITldGRDhJSmZZ?=
 =?utf-8?B?TVY4YTNCZUtIbmJlUzVDbWxaTGRWOFJaT202NGxublBvOGpXVG5SdjZxeHo2?=
 =?utf-8?B?dTJ5cXdzRkVDRmpqanowQjAxOUNETjJUL05kcXRvVkRYRkMwNjcrT2oraXQ3?=
 =?utf-8?B?ZzFaOFJTeUEvVk9qdDNXSnd1bnRNNStyeFFDUWdRL291RitKYkpaNVdzajlN?=
 =?utf-8?B?bmdEemt5cDNaNWtrd0s5S1VSbHprak4rdEVIUDUzTjIvY3QwdkkxTElzMlZp?=
 =?utf-8?B?bU5XdjZvblgwaFpQL2Flc3RETGpVVkZNOCtUblF3VkMzbGk2UE1BZk5OTExQ?=
 =?utf-8?B?Y3J1S3NVUTYrYkxYVjVaS0RySFlJbzRsT1EzQ3RqMGZJRnAwcG8zYlY4ekw0?=
 =?utf-8?B?eXVBNWtjK1JTeGNFOWM5SXpTMnZ4TTlTbHZ0SlhrYTAwbVVEWFJCUUxtNWxw?=
 =?utf-8?B?eURCb0lnQUFjN2Ivd05WTWJPMVcyUDY3Nnc5c0I5T0ZIb0hSSkt1N1VNMTRy?=
 =?utf-8?B?RXRZL3hHajQrVDRwVEJIWnJaVU1BYTMxbVIvM0hkdzlTWTltNldNWFhKUVp2?=
 =?utf-8?B?K1kvWVkwUjd6bEYrZFZveUtPMTBuQnNVVGR5UlNIK2dYVHVOenpSQUhZL2o2?=
 =?utf-8?B?ZnZ0TUI1L1ZFc3kzQ0EzK3lxK2hMYk8xTGdJMC9uQUZlb0VocXNBWmZ6OVhv?=
 =?utf-8?B?ZzhFT0hVcExqUVBTbW1sUFN2TVpGWERKWkppVGZpdGIrWGliaStsb1FaUmlm?=
 =?utf-8?B?c3NPY05Td0dlU3k0RXEwN0NGVFVsMUhWeUdKVVRzQWpjZ2RYWDBYNGpMbHhU?=
 =?utf-8?B?ejZYbW9aR3hXUTE1ODQwUzdZZXd3R1BkN3dVYTUvcWJQS1JycTNlc29ZUlRn?=
 =?utf-8?B?ekxla25ld3pUY3lFV3ZsV2QvSytJOHFMYk9Ya3NMWjhTZlF0bW1NYkpFTG1s?=
 =?utf-8?B?aGNIVE9qTnl0ekxrT09KNzhNc0NUbllkQ3ZGUUsvVmgyZHU1QUl0U0xkZEVU?=
 =?utf-8?Q?aC8MZQ6JX5cBxkvpMCeQhYm7S?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a0fba06-bd81-4542-c3ba-08dc46eb4891
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 01:32:32.9382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NWmMRhTBxXsql443qsC4ZzOeSUtBXl5/1x76kLr6IR2++spc55ZW78vOZHyeiTXH6e9y5dSogJmUqqcy3LXa1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7552
X-OriginatorOrg: intel.com

On Sun, Mar 17, 2024 at 08:00:26PM +0800, Zhang, Rui wrote:
> On Fri, 2024-03-15 at 10:58 -0700, Dave Hansen wrote:
> > On 3/15/24 04:26, Feng Tang wrote:
> > > Thomas' recent patchset of refactoring x86 topology code introduces
> > > topology_max_package(), 
> 
> s/topology_max_package/topology_max_packages
> 
> And topology_max_packages() is not new. The patch set actually
> improves/fixes it.

Aha, you are right. Will fix the typo.

Thanks,
Feng

> 
> > 
> > I also did a big *gulp* when I saw this:
> > 
> >         #define topology_max_packages() (__max_logical_packages)
> > 
> > and:
> > 
> > >         /*
> > >          * Today neither Intel nor AMD support heterogeneous
> > > systems so
> > >          * extrapolate the boot cpu's data to all packages.
> > >          */
> > >         ncpus = cpu_data(0).booted_cores *
> > > topology_max_smt_threads();
> > >         __max_logical_packages = DIV_ROUND_UP(total_cpus, ncpus);
> > 
> > Because Intel obviously has heterogeneous systems today.
> > 
> Dave, I think you were checking the old code.
> Please refer to commit 090610ba704a ("x86/cpu/topology: Use topology
> bitmaps for sizing"), which is just merged in this merge window.
> 
> thanks,
> rui