Received: by 2002:a89:28c:0:b0:1ef:fe5e:92fe with SMTP id j12csp10193lqh; Sun, 17 Mar 2024 18:37:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHw/Kkw6TiXjm+m7NdJA1AerozqMxZkD5nYEqUGtQBt++MBwFyceH2RQU4V0jc4HYiBtAInolh7JnugxQAyMi/JlNKEfogJMb9CIsyhA== X-Google-Smtp-Source: AGHT+IEHoV6acLom3fe774zqTjb8JBXdCuBI0/5oJbdrZE7d/Wv0ZETlw/FCGsyMZsonN5JEeit3 X-Received: by 2002:a05:622a:60c:b0:42f:2074:2747 with SMTP id z12-20020a05622a060c00b0042f20742747mr12648128qta.18.1710725878753; Sun, 17 Mar 2024 18:37:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710725878; cv=pass; d=google.com; s=arc-20160816; b=fE+nwYP6+7iWFs8TEK3+N+Pv9nUzTuwPlYoYVrT05LwqLN1XCt5c6sP9uf9hA5H23A d3uVinsc1k7OzOYXE+c74GoUhn5oy/EqLWEs/3U8L22Ntsj9xdT6N09/wLbBjewUZd9X SJ2uhkU9lWAbNMoBvZXSzj6w71qLMv25uqaKlwWpgVik1401EvF6UhLN/QTq+NuSQk8T b6pUjXE7bNOpgQOzoNjKAlB4SWtdL20KDkF8INS+T1uTeSfeYLjSZQaJ9NKCZWM7HBnx 5PRtO2KsUSEUfFlBWcrNzGJCmnXpVHnWq0WT05e9i9EtbFp+C0K5RTCR/V9X31giHbf4 l7QQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=AfJmFgODneANbQY2M1rYf2EOoZlB4hjNXWcdT4cc+zk=; b=ineq0H6u9BklhY3OZI9bot93mFh4vWB9WqJvZebnzytpXIVw54u6hiTR4dWHkt2JYQ 9phb8huzLh6hbTCE+SdJh8gK+PdPz80E+g/ctkKM4RUMIslJ7WjBI444SuTVaXPOsKf7 xRS+ei3Eyu/A5OoIYRL7suGXNxLMZfV60eucjJmGwwJ0TRfulz15ABRPoReBtZAaY1Fm mHDRRIBjtvxx5kXwWNQ/tj9dZCvALZrlxT/j1OaAeFLM3bl6ryjAW8i8HFKXg3fbwKVb /Vhaay19IJ4C6UHePtfMgYIli0hkYrrXVFaiWtq6PZnp8vzXs1RvFKVqw7tVGdwvakP+ QT2A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lv+jukBo; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-105634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105634-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f15-20020ac87f0f000000b00430b0d03931si6243289qtk.107.2024.03.17.18.37.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 18:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lv+jukBo; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-105634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105634-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7726E1C2201D for ; Mon, 18 Mar 2024 01:37:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6CE81DDE9; Mon, 18 Mar 2024 01:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Lv+jukBo" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D721318C36; Mon, 18 Mar 2024 01:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725866; cv=none; b=WKFfI4CGKv6ed35SoX03MO/q4NwpSXmXVzsnurlJFsgZ8MkTYny7y/zp5hSpoUwUIpi2WO+KHJDNSMv3kkKagjSx/iDmLB9rKLF72A9reKW4bC7lO1hKxcRRtpPwKJaK0sJuUmnAgHGNfgxaficpZgh5Gpdd9iWXp/ZfvIFfKf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710725866; c=relaxed/simple; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VTYwYbp3wHb4tPsJwQJiISfjljv67iE/kJjvg0Zap8JahVzQPAA62WGrG6AoDN44sGaxKI5UzNIDqcHjdn2Omyz0hTr0I/BH9zFrbVyKQGP+clUiHQTRNggNUy3EVYKy1I2mCqMlMo0iaW6pxm1k2WprhuES9Bm5xEI1DogJm6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Lv+jukBo; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=Lv+jukBolHgJVFHPYOonFCmy0W qBYN4yQXifwN/5WxK/nIpuUDWCo9tp3DzaQwYEDw6uxMJg01j5d6FvuHK2juZnX//qL5864SILy8A W0G50hrnJv5FtujweNv/DSzgeVVwZIpEwpIhawhHcUQ/TjiY08z/MYte1hxKKkFL/wDC8uBYyWqN5 6SkDGXaxBJ0Xqkau6ZIDMiZgTcLYZQpDgj92mt7N8BrsmDVt+LrzJhVGM+HXi8z0NsFeYpMbpIvdX dy1Z3RIz14b+0c2XHAWp43gKq7qW2RgIU8yY5+5zRko7vrMe6uEjGcdzrCDIswQOgMcXNxJ7Q7CTJ h7z4m/CQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rm1wd-00000006wrG-1fcA; Mon, 18 Mar 2024 01:37:43 +0000 Date: Sun, 17 Mar 2024 18:37:43 -0700 From: Christoph Hellwig To: Zhang Yi Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, hch@infradead.org, brauner@kernel.org, david@fromorbit.com, tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v2 10/10] iomap: do some small logical cleanup in buffered write Message-ID: References: <20240315125354.2480344-1-yi.zhang@huaweicloud.com> <20240315125354.2480344-11-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240315125354.2480344-11-yi.zhang@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looks good: Reviewed-by: Christoph Hellwig