Received-SPF: pass (google.com: domain of linux-kernel+bounces-105650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 18 Mar 2024 09:57:30 +0800
From: Feng Tang <feng.tang@intel.com>
To: Waiman Long <longman@redhat.com>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@intel.com>, "H .
 Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>,
	<x86@kernel.org>, <paulmck@kernel.org>, <rui.zhang@intel.com>,
	<linux-kernel@vger.kernel.org>, Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/tsc: Use topology_max_packages() to get package
 number
Message-ID: <ZfefinwL7jUo+Ly0@feng-clx.sh.intel.com>
References: <20240315112606.2248284-1-feng.tang@intel.com>
 <e0d1b16a-2880-4e3f-b3ca-b0b47494014a@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e0d1b16a-2880-4e3f-b3ca-b0b47494014a@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?voMtb5hUA89MlbRfWbfjqTa4Qb4ea/aE5TVybf4SkjWQrB6d1VpUt+HBRLjb?=
 =?us-ascii?Q?9mung1MAFyJhOtGrIpBSKWOB+doVWe0gCRsEl6G+pC/ZFk27ADmwHcn07kXE?=
 =?us-ascii?Q?VuGaekJFAh6VZ7Du2OMeuCabygBWWlX8rvuh1qUe+Wi6MxwDeNNJ7SlG7gxW?=
 =?us-ascii?Q?8D/L7CyLxhyGAvZu0e2Ydlb1jSlnuyCw0lLv+V/B7yYDYUzJCKX6vqcqQhQi?=
 =?us-ascii?Q?P22eMptRHJoDltvtSFrH6zVcGwvQGY/vp85ZF6TRfwydYaLnCDucCmmGt1ya?=
 =?us-ascii?Q?QscTUY5WRg7hO4h1fehBMBuIv+YAhDRzJih3LPC/fo2XjJhH5dC2RtSIRGSd?=
 =?us-ascii?Q?unx1RmheLE2Svnwq979EO3IePCOBDJBR9USuXaJ/TUEcLNSJBTWb0df/i3BQ?=
 =?us-ascii?Q?7216v/MGim8dnB4JCSrUCV1+ta1Mtm/taaTNX+mzI1Gwj1Y7l4MRb0y+weOr?=
 =?us-ascii?Q?s3cyOOZwSVdGGlWJKOUBQ3mV6aIOAGdhZ9lXvN7VMQHTrQeB90Po3QtLSj19?=
 =?us-ascii?Q?OV5AWJntvurhyy/xwNbM+GFf6XFfvSfw8JWTBfHmNrlbDXfWRF5paUmY7dNl?=
 =?us-ascii?Q?ZJKQek7zoy4204zU38360vP2F9hkgRy+eq1a/SJ1oFCfrTLSPwbmt+p0CFCT?=
 =?us-ascii?Q?HYqyPbA/Z6oW70Nfpk7MMsfqqJU8+SUcvsTNn2y1ROmTAUuZ6E7PsDbDd8DZ?=
 =?us-ascii?Q?T4ZD1p35gGI9IwbRRlpnwQF/o16u87qzmwOIymXvxrLfpgvoO8nKRE/8z/8t?=
 =?us-ascii?Q?s1Rs3rFfTfUExt8wPyxDWSJzm2fc0XNHGMHx6nF3pVXmAshwXgoFDZanRigT?=
 =?us-ascii?Q?/ZkdQTH4C6TJc8t9uzOPwleHjkHUJk1TKeuYL88zkONCzzZYkRrY4vnhLLsl?=
 =?us-ascii?Q?FuJrzvF1iJ+ZV/Sa9JnF4DRkUY6T6+2UqtLkmziM6esjTnFz3eBFGzduz6uV?=
 =?us-ascii?Q?ZMpJhUuVgJHiIx6vlgBdUmjNBScND+O1HbkoKe+84UDRq/Pc27ktfryWFvQB?=
 =?us-ascii?Q?mFM8ZtOqrt02suzsi0eSjihV3vzM1Jyb6gDiIw3+I7y07hErexY0skNwBd6c?=
 =?us-ascii?Q?8O0v32EWmBYfkIOqVF0VeGg7a3HBJgRymRDB1eoIXm/7PY+AdLqdIEpPLLrP?=
 =?us-ascii?Q?31tfHVd7N2863PNMYCD8tlzL2R13uEg9SeaZSwbYsVqnrxAkigq5JaWs1ock?=
 =?us-ascii?Q?UGEAc65Uopa7hktEV8hq57Jq9VsITG/mHvmi9Z1snw9f2KyvP33VZ0w3JZB+?=
 =?us-ascii?Q?VHIxfjE8pMaWQV3E1IhkFuIkEpJd/URKfiGV4Vl8ZMHMdVd5HqgRAAEmhJHV?=
 =?us-ascii?Q?l81f6YABpeNwJInFCbMuxBg4hCjlBeudqSXEdKYYKQQNAZSMucapuSqGfw32?=
 =?us-ascii?Q?SsNKCDO6WXO4TAOd/uEnmdgy72NcHjgaB51N7jA9E6OgxwMhpWWGkG5dRILl?=
 =?us-ascii?Q?ojDosRJ6jbpYUrVEWPDAWIBYcrur3WVMPJtR1cDyozbQJoErfXxP9Sz/yK/U?=
 =?us-ascii?Q?E+77P55gjsrOC6cic2q7KG+TxP75fbbp1eiu/DUFc3YT2wE2qHCqITm/behu?=
 =?us-ascii?Q?RCp17BbJUPK/vquv6o72STao9EkWE1+yr5sfPYgR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26f3ba5a-f24a-4868-58ff-08dc46f0b82f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 02:11:27.6828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e8e2srkj7PAHjCi0qUXi4o51nZK/4UMQTCUtgrkVF6r/597FuyRyXYtpJ4F8ELORTPf20bLLBjl5F65oShKi8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6511
X-OriginatorOrg: intel.com

On Sun, Mar 17, 2024 at 10:03:38PM -0400, Waiman Long wrote:
> 
> On 3/15/24 07:26, Feng Tang wrote:
> > Commit b50db7095fe0 ("x86/tsc: Disable clocksource watchdog for TSC
> > on qualified platorms") was introduced to solve problem that
> > sometimes TSC clocksource is wrongly judged as unstable by watchdog
> > like 'jiffies', HPET, etc.
> > 
> > In it, the hardware package number is a key factor for judging whether
> > to disable the watchdog for TSC, and 'nr_online_nodes' was chosen as
> > an estimation due to it is needed in early boot phase before
> > registering 'tsc-early' clocksource, where all none-boot CPUs are not
> 
> "none-boot"? You mean "non-boot". Right?

Yes, you are right. will fix it. non-boot CPU means AP (application
processor) here.

> 
> Other than that, the patch looks reasonable to me.

Thanks for the review!

- Feng

> Thanks,
> Longman
> 
>