Received-SPF: pass (google.com: domain of linux-kernel+bounces-105664-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Cristian Marussi <cristian.marussi@arm.com>
CC: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, Sudeep Holla
	<sudeep.holla@arm.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Oleksii Moisieiev <oleksii_moisieiev@epam.com>, Linus Walleij
	<linus.walleij@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer
	<s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Rob Herring <robh@kernel.org>
Subject: RE: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Topic: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Index: AQHadhNQAq3ztPnC+06ZIaeZ1qof0rE3crUAgACA3vCAARLLAIADylFg
Date: Mon, 18 Mar 2024 02:47:06 +0000
Message-ID:
 <DU0PR04MB94176621F225DA0316E2734B882D2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240314-pinctrl-scmi-v5-0-b19576e557f2@nxp.com>
 <ZfMqWP-t39SCvkA2@pluto>
 <DU0PR04MB9417056FD84405898F1B007B88282@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <ZfR89rdzRymY1Ovx@pluto>
In-Reply-To: <ZfR89rdzRymY1Ovx@pluto>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?PNUKpYaTTyWEQzHufsmIay6ouM/BktSNzmXOkrMabVfZ9A/fSORAJTw229Al?=
 =?us-ascii?Q?yzSbU25TBOnlzfkbaiTkMEe2bL0Y85tVa7YyZSzv2ewcBmlI5He08Sucx2T0?=
 =?us-ascii?Q?701Z0bNdFOAOELLaYBJ4cqDWmkWTbaoJmoPllSS8RAW8GVmL4KbLm1SM3nwU?=
 =?us-ascii?Q?PdWEf1LQAK1tMngJLC60tJU+kdvv2fNvTKpHzMMB1c6LmnVZRrkmQhrk6LXg?=
 =?us-ascii?Q?SOhUIYtghoZFQFbAjluelXnmVepcAniyshGB4rjkD/MOJRqb1cm712S0MKOE?=
 =?us-ascii?Q?sO9I7SXWPXUqN+CIovWOiIhv1MuWw+JoAN5q0S6+PPyWBSYdTLGFT7lK3Kfc?=
 =?us-ascii?Q?o/uuLVSv8q3tK/FL4Ur0gK0qaj57rx37ejrwAqZN5BOkNMuL+PAazCr6yHOw?=
 =?us-ascii?Q?29p6e3IL089iD/CWRVgqCax2HWtR0OxvupDZeEfH+dq/Bc1gGmI3Lp+I2g7g?=
 =?us-ascii?Q?hin/tw1gJXLMkOwgOtdSsGvFVCSonu24dVJu5OHqOiwfxRC53QUXi9N2ZFLT?=
 =?us-ascii?Q?th3vNanrCIwD+tIc30m1h7kF8V489H/aynY/Pkvn+vTK0Rrd7Qzs9vhTS0Er?=
 =?us-ascii?Q?9c1oTje2L08rv72qr/9PYwObbHBaPptan/tdbfhS6Nyok4SSFDdprpzZBr8a?=
 =?us-ascii?Q?YFnd261KQ/66Kif1Kfr0dLJ/Z9plZ0BBW54l2P2zN72ZWq4nakw1F3Dwj4G3?=
 =?us-ascii?Q?QiyuiOLEa/nEf+CID0uqWRu42CCXcGp3DjsQ/2+Di++oxQCX7B77BrOoC0Oz?=
 =?us-ascii?Q?y1HDKM2zDngNp2V9T+G+IVl5VVdUt3zBJls1HlP0iPFUkG5vCL386MleP8rq?=
 =?us-ascii?Q?cUIDvP50GcAM/AlldTeDiry5MhivIHloUEp8yMRkZXhvo496TPXJ7cLsqfS0?=
 =?us-ascii?Q?TSWAIksdPtU75kwoN9liNiEY2r4jUFRaXZMHNd0jNSAKJes78TrTVjsqyqJp?=
 =?us-ascii?Q?X3cZA9dZ5sVBBIL8Ylt6kszRBuFu7qTvcgV+9AYy3a7fi4fy8gmVv7ALEs/O?=
 =?us-ascii?Q?hQZTAAaiDfSUbakh9ZNi9dSl0ZlejNMyV/1BbeH6MjzLwmEiLjCdQCHwg7Fg?=
 =?us-ascii?Q?mzOOisFIUZUh4KGwPXyyzU/jZooTEZ15nMGv1r9lWdhKtCyDKoqqTtEVkAO6?=
 =?us-ascii?Q?yLV1bqDQhWWW7dxKlYnf7MnheUDT8mQrZi8KzxpKsML0i4YgTxDbJvqDzBRu?=
 =?us-ascii?Q?J9bXT8Ou44lbqy8IMgALuO0Z+7Be8r0ovqg6io8nzD0QadRcFSFlGYsgQinI?=
 =?us-ascii?Q?qnHTMPy2OjKuw4Gke0OWZU/BKKxoe9i1Q9uJ457f/qxVXxl6W1wk7vyWWjcH?=
 =?us-ascii?Q?Fr/Ch3ILcELl9Hiejq5FBgubzjztIdY2a+gDa+Qa6ClKYd/3yNxYKp+O4h3/?=
 =?us-ascii?Q?NTWV/e5gRyMmBgJt7ad+T5nB2S/556fXjIo/91hIhBaHhAfQhpatI3WUuxqn?=
 =?us-ascii?Q?9PYcjfkUmfT/38VOwi0emGuUb3Fn7iYWO+rdSRLbx4S3M5LDmFYggX7+TRLO?=
 =?us-ascii?Q?0J9HbiaMVeK/WwC4e5oFeXaMaSfMoCBgktLFUAaiB09rShxasv+5QLzSapEu?=
 =?us-ascii?Q?bQ3KqtSu0w4KHcOqI1o=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94f92e92-9533-4631-209b-08dc46f5b30e
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2024 02:47:06.4259
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: orwncCbPk70BI+qWM3bQxxw+HzVHP/ZEKCnyU3MPaZNfuFU+9ypM+/0aBYcadjgL7sI/jjvDrVZYWdX7PZVtqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7088

> Subject: Re: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> protocol basic support
>=20
> On Fri, Mar 15, 2024 at 12:31:51AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2
> > > pincontrol protocol basic support
> > >
> > > On Thu, Mar 14, 2024 at 09:35:17PM +0800, Peng Fan (OSS) wrote:
> > > > Since SCMI 3.2 Spec is released, and this patchset has got
> > > > R-b/T-b, is it ok to land this patchset?
> > > >
> > >
> > > I'll have a look at this last version and a spin on my test setup.
> > >
> > > ...but has this V5 change at all since the Reviewed-by tags due to
> > > the latest spec changes ?
> >
> > The tags are same as V4. I only did a rebase, no more changes.
> > >
>=20
> Ok.
>=20
> > > ...IOW does this V5 include the latest small bits spec-changes or
> > > those latest gpio-related spec-changes are just not needed at the
> > > level of the Linux pinctrl support as of now and can be added later
> > > on when a Linux gpio driver will be built on top of this ?
> >
> > In my current test, I no need the gpio related changes, so I would add
> > that later if you are ok.
> >
>=20
> I COULD have agreed with this, since AFAIK there is currently an effort t=
o add
> support for GPIO on top of SCMI Pinctrl BUT not in Linux, so no reason to
> block this series for gpio-related missing features, that should only be
> additions not breaking backward compatibility...
>=20
> ....BUT, I've just wrapped my head again around the latest public release=
 of
> v3.2 spec (which has gone through so many changes and additions that I ha=
d
> lost track O_o) AND beside the above mentioned GPIO changes there are
> indeed also BREAKING changes around the commands
> PINCTRL_SETTINGS_GET and PINCTRL_SETTINGS_CONFIGURE (which were
> the old PINCTRL_CONFIG_GET/SET), that now also get/set the selected
> function: so that, at the end the payload itself of those commands/replie=
s has
> also changed IN SIZE, so the driver needs definitely to be updated (and
> whatever you use to test on the backend server too, if you want to test t=
his...)

Ok, I see, there are indeed some changes, I will update the driver.

>=20
> I think these changes (which I forgot being there) were in since last mon=
th, so
> already V4 was broken in these regards (which I have not looked at)

I may need to drop the R-b/T-b?

>=20
> I'll leave some comments along the series and test all of this again next=
 week...
> ...since too many things has changed and I want to re-verify all on my si=
de.

Thanks,
Peng.
>=20
> Thanks,
> Cristian