Received-SPF: pass (google.com: domain of linux-kernel+bounces-105669-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Zi Yan <ziy@nvidia.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
 Keith Busch <kbusch@kernel.org>, Yang Shi <shy828301@gmail.com>,
 David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, Andrea Arcangeli <aarcange@redhat.com>,
 Nadav Amit <nadav.amit@gmail.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/mm: Fix build with _FORTIFY_SOURCE
Date: Sun, 17 Mar 2024 22:59:35 -0400
Message-ID: <86DB2DA7-5D38-4E45-B810-225E4F75067B@nvidia.com>
In-Reply-To: <20240318023445.3192922-1-vt@altlinux.org>
References: <20240318023445.3192922-1-vt@altlinux.org>
Content-Type: multipart/signed;
 boundary="=_MailMate_519C5D90-A726-49A4-89BD-B41149B7F45C_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zQUuLuJRC/ilbA4YeeQlgCOCLWDxBcVuz62mw+zbbVL8qFG1DoBNxdcnVrXg?=
 =?us-ascii?Q?6djAdObOZTdL83stBZMag7k0IQ8rpWn/CHfek+M23ZxwxxlKQwvJ81i6sYlH?=
 =?us-ascii?Q?9MaFtnu6F5uoBnubUJqhgM9wYxJZFSE8TEh4Icfm2lIS+r4ADigrF/HR98+K?=
 =?us-ascii?Q?QawtJ1G4iAkdURoqIe+psPKNdsLIHEE1y1siOGF289vHarEtjjYFqF3VS2Sb?=
 =?us-ascii?Q?tjQyEscj66Enlk1nYW2TMixLDxRWcBnsZbbMtG/hX3J16jk1deCeNDmz5nuw?=
 =?us-ascii?Q?FQUpKJVvc1qp8GmKdXcWOqzx5QmJZtMBQOE9Z1oOHaqUg3gE5Cy7oEavnv4f?=
 =?us-ascii?Q?gkJOm0pTarXWqFD8GP5z/4/aCqCLFRHYnYOBJyZwEXLb0dsij/lDGZrpPod0?=
 =?us-ascii?Q?YiZxJ46XHO6zkzn/tDLVNj/4x5dEkqK2B2e6CTP/SjpbAIjdgCkpsVGXuBF/?=
 =?us-ascii?Q?+KNKF6fiZsU/LoPZbmR7az1Mg24FstoYnl/r7OUfamfsMRiHZf6HrDPnODNw?=
 =?us-ascii?Q?iybZ74ya9jCKom554qT2ehKgwiDi3BCF0D8MWqM5ldjAG6Foz2OCbBEsqPzW?=
 =?us-ascii?Q?EKOEFJj6FVTTEsNE4zC0AeIqqjtIXcx8Pc+GrIc9qGrbKBSO1y0e0tvQGr1V?=
 =?us-ascii?Q?/fi5k66cjEcC4H4dt8uVJuzEU/bHUpMxJpJu6XzEF3MWhUhlCi6L0hOni7+V?=
 =?us-ascii?Q?+4soPS8RmSa1v7niuuK5ARMMBq4sXqW9TmNqWHbsR+RP0bSroleMuDRWstM1?=
 =?us-ascii?Q?CtrTsm+J/Nvm5mqnB19sc0FfV7OYmmu36Ea0qPAitStSn5T3mG6vIRa1ZZVb?=
 =?us-ascii?Q?H1Qhd/xqkdIQalItJIyjJi+eHMWMYyUQuBXmDcFnTvxoRNxLsB6THYBfkCr2?=
 =?us-ascii?Q?FvNwKgYIHEJErzxL8IR5OOecp9vJk5qyTPKrFwJEkl5gdxmmS6Ev0I+nQWNB?=
 =?us-ascii?Q?mimoEmDIAZ99QNeA8N4sHbUTVksNj2pDvJ4WYkmMqTVlnJEEQupALhbl2W95?=
 =?us-ascii?Q?Ff0JqBeHMrRTBNMf2JuQw6Ji0rBtqXdltEDEkZ5VDbIVQgEFWsIsjE3PBjV/?=
 =?us-ascii?Q?lxmAUTRiwCsNQZlwucrBcXQouoFWnOpG6LJyrJD/abGo1L4f0mnqu540Nk9N?=
 =?us-ascii?Q?BUAlvPCMJsNo7kMJV+BJSPn8Mq0cWu7PKJ+c1Djb6e2yQ946WpRc6EDhctXs?=
 =?us-ascii?Q?weFpqRqvQ5ZNKpmgJG8cTpmg7Hz3Eds6HiEbpQQIt7MSS1zx93y0FPTJDwx9?=
 =?us-ascii?Q?43vfLJ2iRXf2RnLoC+wIj24HsVFBKOW1GFtrm44yKsMAs7mJCzkIb9rEDWbA?=
 =?us-ascii?Q?buptjVlsLd4hUMBEzl6WdDFDEzJ3z6RgfYpUwGo3Bt7VUhIZWI68rbvAI8YW?=
 =?us-ascii?Q?HbNbn7zu0dClPJPf7SS4NiLQFK4q6bXcqq7x7L4+fuaNJsGvE04/gb5zX4yf?=
 =?us-ascii?Q?fEpC74BtGiwzlI7u4vwkA/gK+AvtphEp8u5rOSyAPEa7/U5K3pSpTI0Qy1w1?=
 =?us-ascii?Q?twfRRpdGfF+Ufc9uwgoCWKcG8TvP3wCt6iSq7IT5sDG3QZbowswB7/XqDzLq?=
 =?us-ascii?Q?40ZUd/Nsym2brOBo4VM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2779e855-977d-4e12-6140-08dc46f77334
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 02:59:38.4341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wWyYT7gv5Ng13dFR9itJndKN5BkIt4l7m2eYAkv1hlQ8SAVSpFLk3Zp9t+qo45gO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9133

--=_MailMate_519C5D90-A726-49A4-89BD-B41149B7F45C_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 17 Mar 2024, at 22:34, Vitaly Chikunov wrote:

> Add missing flags argument to open(2) call with O_CREAT.
>
> Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid
> value) (together with -O), resulting in similar error messages such as:=

>
>   In file included from /usr/include/fcntl.h:342,
>                    from gup_test.c:1:
>   In function 'open',
>       inlined from 'main' at gup_test.c:206:10:
>   /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode=
' declared with attribute error: open with O_CREAT or O_TMPFILE in second=
 argument needs 3 arguments
>      50 |           __open_missing_mode ();
>         |           ^~~~~~~~~~~~~~~~~~~~~~
>
> _FORTIFY_SOURCE is enabled by default in some distributions, so the
> tests are not built by default and are skipped.
>
> open(2) man-page warns about missing flags argument: "if it is not
> supplied, some arbitrary bytes from the stack will be applied as the
> file mode."
>
> Fixes: aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow=
 user specified file")
> Fixes: fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP spli=
t")
> Fixes: c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect")
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Yang Shi <shy828301@gmail.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Nadav Amit <nadav.amit@gmail.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
>  tools/testing/selftests/mm/gup_test.c             | 2 +-
>  tools/testing/selftests/mm/soft-dirty.c           | 2 +-
>  tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_519C5D90-A726-49A4-89BD-B41149B7F45C_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmX3rhgPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhULfwQAInZeU7jCZM2Ek8wXoXDMTh9ikiJr4zsO/hE
Agzva6n0LYhY4eF/I+iHhPJUNM27OjLp/mODixUW2VNfAwGyerhQaMRsn36C6vHA
t5qn0yO47nCo1jIn3Szyh8JOCfBghhH7hcBRs8bRBB68ihhVicjBvqkKuejx+RpT
ceFCx8Y4wMF4ZUnXhtM05RuxUYmuF9fHF6SLePFJd+z4tpZvQN/cy9tcG+hm/OlI
ZDHwNTrqcvjsa6UKYhn2SuHTbRo29+lrPNMIjr+wuQRHgPUZKtLo8d40QfOMCv8M
agURsyEnkjMCWkalZap8GeF3z2Ecy8DZ6Ik0SNSN7ym7uqgoNA0GCkShXv5jJS50
wjAcbVYQabBbra0/AGJb3XWhzSlIb7rnAoU6ixd6VJMViN0VlXduwJ8jITOuEeYs
VLKfPMFLRGSFkyz2vH6U2Tf3Mv1TPuaqrGBuLm1Ious5a+PAMOashMscj8pOUrl+
hx3pPMJ9me0ToWdiQXYtx4WHNDrGqzYAGbkMTTuc+JlcoViPT/UuOyD08kL8S+UD
jXiN0ynPbFBjqp3asbTJIPr5PxFqJyythfJv0p7Yuiz5h/d4EaLwCaL8MbUBPM8w
HFvXNcLm4PlmnSLK0Z+LxtqZ2p6AjfEEnp9FPlxZkqOY0ZJ4Otajof5xnYb574pm
7dl6mcSC
=RRJW
-----END PGP SIGNATURE-----

--=_MailMate_519C5D90-A726-49A4-89BD-B41149B7F45C_=--