Received-SPF: pass (google.com: domain of linux-kernel+bounces-105695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 18 Mar 2024 04:43:12 +0000
From: Matthew Brost <matthew.brost@intel.com>
To: wangxiaoming321 <xiaoming.wang@intel.com>
CC: <lucas.demarchi@intel.com>, <ogabbay@kernel.org>,
	<thomas.hellstrom@linux.intel.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<daniel@ffwll.ch>, <intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe: Failed getting VMA cause display stuck
Message-ID: <ZffGYCzt7dUe9Ox9@DUT025-TGLU.fm.intel.com>
References: <20240318041244.1239610-1-xiaoming.wang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240318041244.1239610-1-xiaoming.wang@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ilRN5mKyTvJ7ua6lIidV325+8UFdEy0+B7FAvz63jl4Z5I8gd4bU6O1SV19p?=
 =?us-ascii?Q?Yaiy4bDiqHJky9VTCYo7V0Vd3HM7XrKP9l/AfiF0vBXkE73YANKTVyNoM/XD?=
 =?us-ascii?Q?ITRMGgjaUCEqv0jC3Z33JRFrChfcyF0LrUbGoD86bVQVIihfKC0lH5Iy6/L2?=
 =?us-ascii?Q?TRguG71PCq+dfig88et5PtXzecBBOiEpExStVGfHerlcXfGsgYYq9Pd4+NgA?=
 =?us-ascii?Q?4tr4ogKARL/pLFbiDihF1JgvOT/snLEOT6yfKRrKSF8yrA7C7I4tbrQhztrx?=
 =?us-ascii?Q?j/WBuVJdvCKjrUClULlc6hlIEBnLILRrt1TEPzzJ+5Lwo6HgYnZLsDDVplz7?=
 =?us-ascii?Q?CarSQNnf7r89BopADrNqlQmn6NfCAsK3qgJDnzmqH+oFSe8y2ZKS/BaRMJYN?=
 =?us-ascii?Q?vRPi5bvgZyck1avN1fyfuu7+CwQChWNN+E3Cfo4T0+YgTyuX/FrTtOM8zvfQ?=
 =?us-ascii?Q?f5EOU58OtVfI/tdvKtb4RvYgYYB5MIWe9L0TU1vrPs1OqjETYiZFSeqwUbh8?=
 =?us-ascii?Q?LAB9J7XZzW3ScCjgT6MxoJJ5HQL6bfFX3Rhv6IZaKu8+GU60pNCTqdb9xMT6?=
 =?us-ascii?Q?gs14nEzyqDd8Rr/L4UQ+xC6c+/1ih2YuemWWlOdBkNw17IdzKdFDV3YqEeDX?=
 =?us-ascii?Q?4u8oZh8ejsVu0aqr+Jd+AjqTJRw/oWC7OWspMY5qjkysG3jt3MG7oIMbhKeX?=
 =?us-ascii?Q?XphWBnxkTAbeU3KWnCS+O07YpgoZlixqyrwcOul+7z10Th02hrktNQ9H6hzF?=
 =?us-ascii?Q?w5THW86kyb+Xxqdlr7NQWZH1ECQjGJAZltMuFTxzdIbyNgqP0HPDA+ucBA+0?=
 =?us-ascii?Q?ywlj0l/h9MPknu6H5It5iaUnkFmlon9dPtpDMY/TQGGXe7qHs7jDFIpyXR2c?=
 =?us-ascii?Q?r2xOLIb6VFmK3CdgALqH/FCjLMzTzb6ks3Xfw0HnCch5CPDXo180nqEd07G+?=
 =?us-ascii?Q?JYfKPVHz8rr83EYw8spQWRWpqjVs7XCFAonK8C9gFxBLXSc7afPn916fsKsS?=
 =?us-ascii?Q?bDkfq2N6HdScRAoAon2tyAFUX3rKeSbpFHZ84fIWKs11JxrtEohXm3zyHsdf?=
 =?us-ascii?Q?y8TbhlhzpdoZJ1eYF0DUWZ5V9TfVWMeTgaVYrA3l14QHPe8M5Lo+AvFK9TVT?=
 =?us-ascii?Q?2qIbijGlkEPdWBL1qaKICADKiN+Mm3gtP5yepmT0OGNHoz+ysMirIQzJ4Ty4?=
 =?us-ascii?Q?ceGyQnCV/Gn1HOHgIVUClWRyMNCicloJCRrYIjYOvYsgK2ByA6djydynQbkH?=
 =?us-ascii?Q?0ukmH1q+TGZRwELHQc8z/ozjQc7lFOpiW61KG8Qs8MrU+yYBLjXRrLHAV0Nm?=
 =?us-ascii?Q?+WekRT48wa2jSFTL4p7HJuN7wS1Rw6Ud4QYoPzF7e1BCxLa9D0AUSaNakZN4?=
 =?us-ascii?Q?F84DR0J4WnVX5gnQCp9dixyNJiUOmgyTyJRpDkNUN3UIAt0PILj+ScKvTrQi?=
 =?us-ascii?Q?Udl8T6zSW5VIpmsN1tHdzcFJcfW6gJRLfJNMmH2xQlZExfr1C1bySJ2ABeb+?=
 =?us-ascii?Q?ZrpzVLu/bduKDasfFHTBIYpNu4zL2OAEqd2JX55mDLDQGj0zSoC8p9EdBOhs?=
 =?us-ascii?Q?/8jslpcBkf5p7flVs5NcgHXEin1nUsVWao23SmEZGQboDMWkE5nxkUCBVXLS?=
 =?us-ascii?Q?aQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed39fdb8-ae63-4def-b661-08dc47062b6d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 04:45:00.5067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 875zd8JESIZBi1PFSdt1muggPLddtuen9jVgLZsp/fykezjjKeQmK+RID1pcp0dXyvbohi8iBAfY4+6lWWY5zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4642
X-OriginatorOrg: intel.com

On Mon, Mar 18, 2024 at 12:12:44PM +0800, wangxiaoming321 wrote:
> The failure of binding VMA is duing to interrupt,
> So it needs to retry while return fail.
> 
> Signed-off-by: wangxiaoming321 <xiaoming.wang@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 99aa5ffb0ef1..d33476b631e1 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2621,6 +2621,9 @@ static int __xe_vma_op_execute(struct xe_vm *vm, struct xe_vma *vma,
>  	}
>  	drm_exec_fini(&exec);
>  
> +	if (err == -ERESTARTSYS)
> +		goto retry_userptr;

This doesn't look right. If the user presses ctrl-c we'd restart?

Matt

> +
>  	if (err == -EAGAIN) {
>  		lockdep_assert_held_write(&vm->lock);
>  
> -- 
> 2.25.1
>