Received-SPF: pass (google.com: domain of linux-kernel+bounces-105705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Mar 2024 05:23:03 +0000
From: Matthew Brost <matthew.brost@intel.com>
To: wangxiaoming321 <xiaoming.wang@intel.com>
CC: <lucas.demarchi@intel.com>, <ogabbay@kernel.org>,
	<thomas.hellstrom@linux.intel.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<daniel@ffwll.ch>, <intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe: Failed getting VMA cause display stuck
Message-ID: <ZffPt/ww2+/TTMQ+@DUT025-TGLU.fm.intel.com>
References: <20240318041244.1239610-1-xiaoming.wang@intel.com>
 <ZffGYCzt7dUe9Ox9@DUT025-TGLU.fm.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZffGYCzt7dUe9Ox9@DUT025-TGLU.fm.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YYn5r6VtHmKPwRPFgpp/fkW+DCOKykQv4OOkz09MdTmwr0cfj/G/SI6LsCgm?=
 =?us-ascii?Q?9/s/9aTNkDKPvrPH3uDP6DpY4Ocg/ewCXwm5f4iOeRAnx3GePB9MYJxugXbb?=
 =?us-ascii?Q?PRsDw7NKaO3D3cKvBap0tsP42CMLFkFPr+x9VaISxGFxTfgxYCqCri96q+Rj?=
 =?us-ascii?Q?GOqOVIKwcDYuS/7TfQf8dmela/g5kfrpoqOxkjjhZGoVQMm0NH1XnngZZU+c?=
 =?us-ascii?Q?wweY0BoZJjJkYJjPd5eBNMsFcclBk3b5acfIwfE9LjG8HKD9auOT4JBHQiCw?=
 =?us-ascii?Q?KMUDQXSG69NTdC2N0lnEQ18wCTi5PLcOwbI9hyxrt4FRG9AuuxW/DZaIpCVm?=
 =?us-ascii?Q?R65+qkKcGv9qhYca8MXDvGtYkl9/l5QwGy1pHTIf9fhBJLQVR34Za5TpO/TW?=
 =?us-ascii?Q?UHbDPliQg1CMYkaI/sATjQt82rljDp+hza/HD8ACWSn8xD21E4o1BE/YoQU8?=
 =?us-ascii?Q?zG+wKEetrbc3cbDnAkhFztuLxzzSvQaZHfItdBlbgUw40+edpkrkCQfjU3zL?=
 =?us-ascii?Q?789rxsi6/3+By2vIyD14B5PPz8SOjIUn5FzmQ7yWPh9TLoFqKn9kp0tyUqJP?=
 =?us-ascii?Q?l5HGVn+I0Wm17Dt8a2arnOTUb2WIyuS9UqarBtn/JYZtFP/HE+8v+FKBbqaP?=
 =?us-ascii?Q?ojzH38tw7SLJ6ZepiptY2JTC2OC1iyNJapN9CTHm5VVtbTkovf4aGjGbM/uj?=
 =?us-ascii?Q?CWih4/sgCEReuw+kV1k3gTsXAcfqHCTKzbxIvmYuv+U3At1i5S+wVD99De9j?=
 =?us-ascii?Q?ib5d150eLna+HZGHa++71UOcSAC06eS6pCZ+STkI/+Mb1ci8jwfuC8vqs2F/?=
 =?us-ascii?Q?66/4m1rIEcokD7UTSFz5rVdsqe51TUu3VoOvYazLiArzl9qSQKVTfFMJBhzo?=
 =?us-ascii?Q?1RysVCU5ScrDTPe6RuWKsPw4St4Begd2+jLZwPSZaA7E3wour+ylgwUlpOPC?=
 =?us-ascii?Q?hxci6PyuP6JHIJ0aXGht6hytE1NS9jhhcNvxsLNHBordMXXpiNH/DbA2OUdp?=
 =?us-ascii?Q?p7L2hx9l+oExZyHx65S+D48ju1RkenS0XC2MBmB/2U5AAprd1dHVLPlpPLHQ?=
 =?us-ascii?Q?gxLoXXdNkeKZ2L+D/UzN2lBhTNS8GSayZZl6GKZ+6GkwT39Q7g7DiHT5p4jT?=
 =?us-ascii?Q?umlPyytCrgCd9bNEq+wtVXjGJF4uCH7/jsaPJo7AVfrsjF4LFd9PADOak+Rb?=
 =?us-ascii?Q?hfRqpylDAiAZQQhUEwmqOJugU+ToNNDRR1z3alkN0bnwV0QjoaD2il0K73FG?=
 =?us-ascii?Q?fmMiVsG7AjpCE9AqGswROX6UXS+2pj7lKrSd19qnpeTPOEVpA8EDG4bj3/i1?=
 =?us-ascii?Q?NoyLOyn114xo9vLNmHK7zw6sMqdq3D2JltkyBs/GIqQdoFI3si1BZ+bfFG7O?=
 =?us-ascii?Q?Jg1kALJAkxPfGvZ00PBopj76tWrx+Ks9sRWA/ToPx9iBLCIQl2Y9u9+yWZbA?=
 =?us-ascii?Q?P1r93m00zjgz1BsfjqTOSQj1M5aA3Yx4yq7L2mpJch3tCGBtDpPEvjC9wgIA?=
 =?us-ascii?Q?OXhcNDq2rHr9jh1W7D+TqzcUWNrErQDqQ01bb4kqBgY3U9UqjcyuTuoEwefw?=
 =?us-ascii?Q?L+Y+OeOUGM7xslyxhGHZJyFDyeVMximZt8szaq1eFdrApoz2pZCpL0aYyPSG?=
 =?us-ascii?Q?6g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aac6540-8e4f-4c20-0309-08dc470bbc81
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 05:24:51.3580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZHtncHRhvj+qlJn5aSt9fwdXN96awIW6kRLqckF2V2bJC/O1nU6AooqxjkRWS6it0ZzNBTSPyxtX9ur1sU+q9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7444
X-OriginatorOrg: intel.com

On Mon, Mar 18, 2024 at 04:43:12AM +0000, Matthew Brost wrote:
> On Mon, Mar 18, 2024 at 12:12:44PM +0800, wangxiaoming321 wrote:
> > The failure of binding VMA is duing to interrupt,
> > So it needs to retry while return fail.
> > 
> > Signed-off-by: wangxiaoming321 <xiaoming.wang@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_vm.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index 99aa5ffb0ef1..d33476b631e1 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -2621,6 +2621,9 @@ static int __xe_vma_op_execute(struct xe_vm *vm, struct xe_vma *vma,
> >  	}
> >  	drm_exec_fini(&exec);
> >  
> > +	if (err == -ERESTARTSYS)
> > +		goto retry_userptr;
> 
> This doesn't look right. If the user presses ctrl-c we'd restart?

Typo above. s/restart/retry.

To be clear this patch seems incorrect. This is traced to
dma_fence_wait_timeout, if it is interupted, that function return
-ERESTARTSYS which would should returned to user space via the IOCTL
failing. That is what the exisiting code should be doing.

Matt

> 
> Matt
> 
> > +
> >  	if (err == -EAGAIN) {
> >  		lockdep_assert_held_write(&vm->lock);
> >  
> > -- 
> > 2.25.1
> >