Received-SPF: pass (google.com: domain of linux-kernel+bounces-105716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7e1df07d-d047-4cfe-bfdd-fb17d0daf158@quicinc.com>
Date: Mon, 18 Mar 2024 11:20:57 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC
 pins
Content-Language: en-US
To: =?UTF-8?Q?Pawe=C5=82_Owoc?= <frut3k7@gmail.com>
CC: Robert Marko <robimarko@gmail.com>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240313102713.1727458-1-frut3k7@gmail.com>
From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
In-Reply-To: <20240313102713.1727458-1-frut3k7@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 3/13/2024 3:57 PM, Paweł Owoc wrote:
> gpio16 will only be used for LCD support, as its NAND/LCDC data[8]
> so its bit 9 of the parallel QPIC interface, and ONFI NAND is only 8
> or 16-bit with only 8-bit one being supported in our case so that pin
> is unused.
> 
> It should be dropped from the default NAND pinctrl configuration
> as its unused and only needed for LCD.


Matches with downstream.

Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>


> 
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---
>   arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index e5b89753aa5c..8bed34174460 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -349,7 +349,7 @@ qpic_pins: qpic-state {
>   				       "gpio5", "gpio6", "gpio7",
>   				       "gpio8", "gpio10", "gpio11",
>   				       "gpio12", "gpio13", "gpio14",
> -				       "gpio15", "gpio16", "gpio17";
> +				       "gpio15", "gpio17";
>   				function = "qpic";
>   				drive-strength = <8>;
>   				bias-disable;