Received-SPF: pass (google.com: domain of linux-kernel+bounces-105740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH v2 02/10] xfs: allow xfs_bmapi_convert_delalloc() to pass
 NULL seq
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kernel@vger.kernel.org, djwong@kernel.org, brauner@kernel.org,
 david@fromorbit.com, tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com,
 chengzhihao1@huawei.com, yukuai3@huawei.com
References: <20240315125354.2480344-1-yi.zhang@huaweicloud.com>
 <20240315125354.2480344-3-yi.zhang@huaweicloud.com>
 <ZfeYt6zWcX7u1zMG@infradead.org>
From: Zhang Yi <yi.zhang@huaweicloud.com>
Message-ID: <e484887d-8fa3-89a5-73ec-e279b216a645@huaweicloud.com>
Date: Mon, 18 Mar 2024 14:36:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZfeYt6zWcX7u1zMG@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2024/3/18 9:28, Christoph Hellwig wrote:
> The patch looks good to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> But maybe I'd reword the commit message a bit, i.e.:
> 
> xfs: make the seq argument to xfs_bmapi_convert_delalloc optional
> 
> Allow callers to pass a NULLL seq argument if they don't care about
> the fork sequence number.
> 

Okay, that's clearer.

Thanks,
Yi.