Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp36012lqt; Sun, 17 Mar 2024 23:38:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWGPXL7rCik0FFZD/KismiWzjCNncZpX1C0Ge2MM6q8GZ+HXqDS6kGITN1wthmUIq5J4XyNKdYaqnl9rZdyn/NrYjvnYCA+221h7rR9CA== X-Google-Smtp-Source: AGHT+IFt81Mbd8e/Uen3qH5hMBikqXHAK8d/iomrRzVu5n2MWGi5y/WYCPWHqkth6qdWo+Jihb1C X-Received: by 2002:a05:6a21:2d09:b0:1a3:676d:11f with SMTP id tw9-20020a056a212d0900b001a3676d011fmr1518478pzb.31.1710743927344; Sun, 17 Mar 2024 23:38:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710743927; cv=pass; d=google.com; s=arc-20160816; b=iV3GCGWQ5VLAjliBzpOuJFJrts/u8SMRIvYcxXBBCzoQSniZ6yiFmSNQowleDoUCKY iGcuUHYk93RaSmjkIWDEHLRzKg9RO/KWJi9M6UWM5+BBFR85M8wCj514xIrtA8bwgTRH ck5q2VTC97P7j+7d2PTyRDq9xhpJL2kh0Wa8Mr48/3E1rQt7BZmGGT5q4GVVYizyZX4t 39Z4ivEyBvA3OBRQiKC6nG1XwIqBFQHUvSasEoAR5tY2uAEzm5yGkXWJI4Nj3SzowAOB ROJKBs3dRE9AzNluw4iXEA3XtR8xj3qSNR+KWsyGICvxLlZnwLIU0i7RLbWWgH2S8zUc m81w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject; bh=kcKfwrqX3ieYoibxdxGk/9dJxuLxJPwnKYrLOPOJKLo=; fh=Rh7CyOgrM+Ix7Gfo5Ji3D8IZUA12Of8bsFtLyWEocmM=; b=oXwJCyJTP9CWz/+c8CUSB8LvptLEizmqmaml2x4Bngd1WDK1ATV/zVW+CoCjXLy3ZQ R3Afdr5v5eUjnYxzpwQIBAuhJ2ieNido+masj9rQIliw1ZW4msXFcpNlGxF5w1yQjHIF kiXbTMe+5BbHRsRZWeWx9ZYZH9M5GvMBzaUsL+eXpjCPDzw5iobjkDzs0jU4vsqGiIc+ xoOZqtiJ5E2cj6OoR4/Q5x/eMzSkg3fyVPhLdQy1VLlLcobPeyOSee9NQtdo/C2MmYBr UHPg0EDdcZqUCCQ1GxK1nW4DO9cDq6/u3adLf9Pavx1pnHZpkBFYaQHRWVkI3kqckkN7 DKUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-105742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105742-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a12-20020a63e84c000000b005dc4fda246esi7462923pgk.615.2024.03.17.23.38.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 23:38:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-105742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105742-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0A889281CF8 for ; Mon, 18 Mar 2024 06:38:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63DD122EFD; Mon, 18 Mar 2024 06:38:29 +0000 (UTC) Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17C0722612; Mon, 18 Mar 2024 06:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710743908; cv=none; b=jrZNTeiFcpXSgWs+sMT5MLrSAQCbHmnSzEeX8PVk3ixBxpCiv61ZaUknQzNr/p/YR3Xm3CN21G+GNXct5vrFGrc7vrxOXajWIelM4trOmMz+qYHg+3kwCRwCurNlgaJPRcmve7qBHVxR4winYYEa41LYtMrnBABmNKh6BtPKkJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710743908; c=relaxed/simple; bh=QlQ0S93XSrKiyGVVOq6x8ozz/ougIl8fihJ5K/fIWgE=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=MxvVfuvUwcdAaWz8gMLOUjNdlwL8d0OZ7q4ja+yobW8OU+EfFrL83ElG4IT5lEVSyx960I7nuipopLpUNyQ8mY//XoTN1SWKB6Qzhq1sj25el3x6sJCNEiELighPGMhhASKUz/TaJN8b/xOJLKadGHdC/tIG1NumhUL7DWAYUo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4TylY73b0Dz4f3lX2; Mon, 18 Mar 2024 14:38:19 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 4F1561A0C9E; Mon, 18 Mar 2024 14:38:23 +0800 (CST) Received: from [10.174.176.34] (unknown [10.174.176.34]) by APP1 (Coremail) with SMTP id cCh0CgBHGBFe4fdlfHU8HQ--.29522S3; Mon, 18 Mar 2024 14:38:23 +0800 (CST) Subject: Re: [PATCH v2 04/10] xfs: drop xfs_convert_blocks() To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com References: <20240315125354.2480344-1-yi.zhang@huaweicloud.com> <20240315125354.2480344-5-yi.zhang@huaweicloud.com> From: Zhang Yi Message-ID: <464005bd-0b68-78ed-a3d7-55035addb761@huaweicloud.com> Date: Mon, 18 Mar 2024 14:38:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgBHGBFe4fdlfHU8HQ--.29522S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYx7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4 x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kI c2xKxwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1U MIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x07UQzVbUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ On 2024/3/18 9:33, Christoph Hellwig wrote: > Maybe just fold this into the previous patch? > > Otherwise this looks good to me. > Okay, it's fine by me to fold them Thanks, Yi.