Received-SPF: pass (google.com: domain of linux-kernel+bounces-105771-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com>
 <CAAhV-H6aGS6VXGzkqWTyxL7bGw=KdjmnRZj7SpwrV5hT6XQcpg@mail.gmail.com> <CAJhJPsVSM-8VA604p2Vr58QJEp+Tg72YTTntnip64Ejz=0aQng@mail.gmail.com>
In-Reply-To: <CAJhJPsVSM-8VA604p2Vr58QJEp+Tg72YTTntnip64Ejz=0aQng@mail.gmail.com>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Mon, 18 Mar 2024 15:31:59 +0800
Message-ID: <CAAhV-H5TR=y_AmbF6QMJmoS0BhfB=K7forMg0-b2YWm7trktjA@mail.gmail.com>
Subject: Re: [PATCH v6 0/2] Add support for Loongson1 DMA
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	linux-mips@vger.kernel.org, dmaengine@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 10:08=E2=80=AFAM Keguang Zhang <keguang.zhang@gmail=
com> wrote:
>
> Hi Huacai,
>
> > Hi, Keguang,
> >
> > Sorry for the late reply, there is already a ls2x-apb-dma driver, I'm
> > not sure but can they share the same code base? If not, can rename
> > this driver to ls1x-apb-dma for consistency?
>
> There are some differences between ls1x DMA and ls2x DMA, such as
> registers and DMA descriptors.
> I will rename it to ls1x-apb-dma.
OK, please also rename the yaml file to keep consistency.

Huacai

> Thanks!
>
> >
> > Huacai
> >
> > On Sat, Mar 16, 2024 at 7:34=E2=80=AFPM Keguang Zhang via B4 Relay
> > <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
> > >
> > > Add the driver and dt-binding document for Loongson1 DMA.
> > >
> > > Changelog
> > > V5 -> V6:
> > >    Change the compatible to the fallback
> > >    Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> > >    as well as .device_pause and .device_resume.
> > >    Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> > >    into one page to save memory
> > >    Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> > >    Drop dma_slave_config structure
> > >    Use .remove_new instead of .remove
> > >    Use KBUILD_MODNAME for the driver name
> > >    Improve the debug information
> > >    Some minor fixes
> > > V4 -> V5:
> > >    Add the dt-binding document
> > >    Add DT support
> > >    Use DT information instead of platform data
> > >    Use chan_id of struct dma_chan instead of own id
> > >    Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> > >    Update the author information to my official name
> > > V3 -> V4:
> > >    Use dma_slave_map to find the proper channel.
> > >    Explicitly call devm_request_irq() and tasklet_kill().
> > >    Fix namespace issue.
> > >    Some minor fixes and cleanups.
> > > V2 -> V3:
> > >    Rename ls1x_dma_filter_fn to ls1x_dma_filter.
> > > V1 -> V2:
> > >    Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> > >    and rearrange it in alphabetical order in Kconfig and Makefile.
> > >    Fix comment style.
> > >
> > > Keguang Zhang (2):
> > >   dt-bindings: dma: Add Loongson-1 DMA
> > >   dmaengine: Loongson1: Add Loongson1 dmaengine driver
> > >
> > >  .../bindings/dma/loongson,ls1x-dma.yaml       |  64 +++
> > >  drivers/dma/Kconfig                           |   9 +
> > >  drivers/dma/Makefile                          |   1 +
> > >  drivers/dma/loongson1-dma.c                   | 492 ++++++++++++++++=
++
> > >  4 files changed, 566 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/dma/loongson,ls=
1x-dma.yaml
> > >  create mode 100644 drivers/dma/loongson1-dma.c
> > >
> > > --
> > > 2.39.2
> > >
> > > base-commit: 719136e5c24768ebdf80b9daa53facebbdd377c3
> > > ---
> > > Keguang Zhang (2):
> > >       dt-bindings: dma: Add Loongson-1 DMA
> > >       dmaengine: Loongson1: Add Loongson1 dmaengine driver
> > >
> > >  .../devicetree/bindings/dma/loongson,ls1x-dma.yaml |  66 ++
> > >  drivers/dma/Kconfig                                |   9 +
> > >  drivers/dma/Makefile                               |   1 +
> > >  drivers/dma/loongson1-dma.c                        | 665 +++++++++++=
++++++++++
> > >  4 files changed, 741 insertions(+)
> > > ---
> > > base-commit: a1e7655b77e3391b58ac28256789ea45b1685abb
> > > change-id: 20231120-loongson1-dma-163afe5708b9
> > >
> > > Best regards,
> > > --
> > > Keguang Zhang <keguang.zhang@gmail.com>
> > >
> > >
>
>
>
> --
> Best regards,
>
> Keguang Zhang