Received-SPF: pass (google.com: domain of linux-kernel+bounces-105813-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f1be501c-51fa-4a0b-a11f-893b185571c5@linux.com>
Date: Mon, 18 Mar 2024 12:26:05 +0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has
 the same code "do_floppy = NULL" inside.
Content-Language: en-US
To: Yufeng Wang <wangyufeng@kylinos.cn>, Jens Axboe <axboe@kernel.dk>,
 linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: inux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20240318060453.18538-1-wangyufeng@kylinos.cn>
From: Denis Efremov <efremov@linux.com>
In-Reply-To: <20240318060453.18538-1-wangyufeng@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hello,

On 3/18/24 10:04, Yufeng Wang wrote:
> Cc: stable@vger.kernel.org
> Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
> ---
>  drivers/block/floppy.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 1b399ec8c07d..25c9d85667f1 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
>  		pending = set_next_request();
>  		spin_unlock_irq(&floppy_lock);
>  		if (!pending) {
> -			do_floppy = NULL;
>  			unlock_fdc();
>  			return;
>  		}

I'll answer to the 2nd email.

Thanks,
Denis