Received-SPF: pass (google.com: domain of linux-kernel+bounces-105820-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 18 Mar 2024 16:35:52 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Inochi Amaoto <inochiama@outlook.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>
Cc: Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, 
	Jingbao Qiu <qiujingbao.dlmu@gmail.com>, dlan@gentoo.org, dmaengine@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 2/4] dt-bindings: soc: sophgo: Add top misc controller
 of CV18XX/SG200X series SoC
Message-ID:
 <IA1PR20MB49538CDB75367C1FBBF85C79BB2D2@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <IA1PR20MB49536DED242092A49A69CEB6BB2D2@IA1PR20MB4953.namprd20.prod.outlook.com>
 <IA1PR20MB495375AEBA417DB6908CAC98BB2D2@IA1PR20MB4953.namprd20.prod.outlook.com>
 <3f6753ab-ef3c-4bf2-a885-afbf5ad83ccc@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f6753ab-ef3c-4bf2-a885-afbf5ad83ccc@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|PH7PR20MB4414:EE_
X-MS-Office365-Filtering-Correlation-Id: dea48f1c-5672-4ca4-59d0-08dc47266f24
X-MS-Exchange-SLBlob-MailProps:
	RlF2DIMZ1qUQWS8lN22nULkf5597sA7XohXtyjFUJix2A5x4xn175B5c2kxm4g+N+8FSSbK5EhQCznHrBZltGv/wU0qhdzk23WU88lvYl9924dqT/12B49gDBRyj6ypTAbq5W5cWB2Em0vVoPoXkaP6IB93I/BbR7EuRSbUdSeiMQqoRgZ3FYo6uO9yv5yWQrRtGtgdlObVIco00dojkaS0xdKg9cbH2ZXCBe8mEqAPo8hZiTZZ6j5XT0SNIilokaN2Eu4QIw6OsqaSrJeFvn0u2lUtgBEbGZ0nLC08ebbxnWjyneLJBN3xIB/IR3BqGdebEC4qZyhbO0w1nk1Suedm0KMdONMSSE6iSFfqYuMOUdFAMzIJmN7wxFCR2+qUhAxsPn8e64qH9kFYVVJVYWEUVApDRtv5TXH+cbz8dxt+kdFBWmjZB1AIqTiX9wVr9iip3xQgZNLHcR8ZmqxfH2vv/CKXsFHEqptCUj1bqon23ivCpinEluCgpapAARD9knr/YTGTmnagP+63zzmZ8QitEirPTGJHd6omwtp4OB2YJHHeF69oaXwl29JiKloapDQZORzwMuH0449hfM1idD+FBZPrXEvfvJDTtTz2KFm7PqeBNUhrp8DLMirDNN4JIbXTm13sM7xrQrVQ9oIRo4OGs6YAsbdt0p9peVWlEzErP1BafjtXj3oLJ/j5oBIXDtPMLaejyIHiaX36z3dOLunGnwcjP6GxXod9friX0NM/1JaQ2eZiz2yxuo8dpVv2ZULnk0FZ7liJufNZqGbsQFVLiM1XY0C30QKqjOImzzeqWRF3T0xq3bQKa6v11sJec1FI9hAli0DieCNBAFHx/IBQN5pf1VTF9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4z7gKHJnJdGSLNkZKP0edllZLH0Akx2eBRF4Jc0/lcZCVEr0Ykr+zyZk8l5meoR35h/LLvls+U/Fu8dpMnnCcQIjqTfGakIRrDrDbWhxgRqhpe6wNXivnFl0d+smiEnrwD7NoR3vDikZG9zZ5jiilqKqodvqtFjeamWBjqOqSamEwWUtwLI3FI0i4pc1w7GJEkhclfvjIJoEnXxpAEmQBrhZKlH+Uc2MV42HFaVK15/tnBh6JRr1Lzgc83erpDiHV6keLfsayn1CgvcOrMHQ+lUBpz0uDpnKPw35B7X+CXZ8vxV8ahm6EHBYvAMSg1RDQHaYyasRpYJHvfi/eeDFzIpmx/gs+Ij7RS7h9RY9S/nBQ/2iW0dxaiJuQsAiYXNKH5aJdCXaW0oEpd+2nex/Xe4tWMECpZsK1XDWQvwQ74kgvhx1ousoeZgbtDlqRxYKSXwQEcNLrW3PqLXb+PcPEThQiswtJsCWUUXv5ZdmOpe+G0JbwHcGLNMt6v0f7D8Bn9jOwTseGNDgUo21TLZKSJ55C5lhhpvGByMIjetAGnbwl2TyrxXpR/xvTYHqGNwICiHpsfXYA3vrzuV/T5NWau4WbXr54dQmXbJOQsjuCanVr6pM+apTnsBWXLk3ePtPOQXxRDP/h0YaUAMfLD1LqQYj7WPUmBIaJQlpxMYwHZoVESNqpaDoiRy9krmDu88CEaIvKiv6MY2LAzDZCuwwJg==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YCmo0rtUC5mkbPKI1P+IrEbQH4e24dI8zVHogwUoOVk5N1vb1lISyDX71/ru?=
 =?us-ascii?Q?aHV22I7fsxNiS4dGWEvEyZ5is/pKSlPHS7JnIUTCHkxqf7Bb7DpcDSLpJi6L?=
 =?us-ascii?Q?8D2SLIwsYBchBrSZuPocSWq9/jroowIo84AEvmmIfC7w8pt4ahSDRmqKwYSm?=
 =?us-ascii?Q?sl2nstcRqkOIzoUXDlOr+iIYcnQ6RguqjD60CRv8nte/rOdarIEQ99MdlRHg?=
 =?us-ascii?Q?30di+KP6ndNF9T/SKH+5l1gC2dwLPemf61bome3NPA+6jCPV8vwOlAc6wwkr?=
 =?us-ascii?Q?920XX/h9+GV1AiHZ+Bw/JJK1iiIIM4fB5sbRWg49+YVAEEkJRmmm/As4aivB?=
 =?us-ascii?Q?tMEW/Zh5MPcQeWrEbKgY72TsFWq6NxE6O1+kuP8HOu9GlDamC9LgngIoj6wC?=
 =?us-ascii?Q?HfInyLYXlk7jzShHTSrpGfc5ZozxdCQwd3AVr9bI1nEAZEaOLyjvuOj0VPyl?=
 =?us-ascii?Q?45TdF68IrEQyK5EzDy+NI4AzbS++U80kV3ZLExB5qsjZK9GD2ROWXVwmuq0g?=
 =?us-ascii?Q?LaeQkBPVfiFAhOotBvsx2heErBwoZqP0Dxy5tkWHhPn68yfLAR+LIdbex5C7?=
 =?us-ascii?Q?V9vxJnTBxb1tUJmtmgtrFCneLplcPtNsdnDy+F1XpGuf/2CnW4MsY9FHwDgc?=
 =?us-ascii?Q?6k5dhGzXwG08SxH4D3nMfD6mL5P7XESyVkSrBVYqVN26blQpdea9bDoKumyA?=
 =?us-ascii?Q?5rwhW5uqslDmCYjlF4/QHHExMaJob/xJZiq7yMrLbbtbQTmLi1WgcEhXmRRb?=
 =?us-ascii?Q?RNieMw5WLK6l/FFetSUuiiscI/J2Fx/HArOaFs2Pb2VI9XEjYuqG6kmEDTAt?=
 =?us-ascii?Q?+RfC/Fgpk4cQ5SGzi8diMk0F0UDBRr3uH2F7unKYTM7vcAfnkJb6HJk9nFqk?=
 =?us-ascii?Q?t3iyKs7i7KDL/kOpQbmj3IJEdOjiWwrEuM3jy4xjlt6ePAUtN8tkE6wUUjWj?=
 =?us-ascii?Q?IM/Z3qYQ1AhfDEkKFhgJcPfBfV/V+/la/spGobCBu/HUlV3Za5Eok1PE1d0A?=
 =?us-ascii?Q?7YFqcQ17tCMPbYPyOU7K57Pslzhiya2ATG3Hs3NWbXGMuwP3L6KPP66Yunc6?=
 =?us-ascii?Q?FqZYLADpkQAf8DBnZVvgk+XGYQsLsWOlYKZzBivgwNMNuULdkx/Oktd1Uyqo?=
 =?us-ascii?Q?4nO1/fuTu8avl6G50XL59wBqA0XezZ2U1SKPhUqSQEpW+n8kgpNqPJyLHRQ0?=
 =?us-ascii?Q?cpA6UtjYHmszuly4yikkCwuManhcDtMVn+DPQkVxceP/5J0Ew7UGipEvJwFN?=
 =?us-ascii?Q?zF/O6XOcOX94JiJvBPIT?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dea48f1c-5672-4ca4-59d0-08dc47266f24
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 08:35:58.0219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR20MB4414

On Mon, Mar 18, 2024 at 09:04:37AM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2024 07:38, Inochi Amaoto wrote:
> > CV18XX/SG200X series SoCs have a special top misc system controller,
> > which provides register access for several devices. In addition to
> > register access, this system controller also contains some subdevices
> > (such as dmamux).
> > 
> > Add bindings for top misc controller of CV18XX/SG200X series SoC.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> > ---
> >  .../soc/sophgo/sophgo,cv1800-top-syscon.yaml  | 57 +++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
> > new file mode 100644
> > index 000000000000..009e45e520d9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,cv1800-top-syscon.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sophgo CV1800/SG2000 SoC top system controller
> > +
> > +maintainers:
> > +  - Inochi Amaoto <inochiama@outlook.com>
> > +
> > +description:
> > +  The Sophgo CV1800/SG2000 SoC top misc system controller provides
> > +  register access to configure related modules.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: sophgo,cv1800-top-syscon
> > +      - const: syscon
> > +      - const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties:
> > +  type: object
> 
> You have schema for the child, don't you? So use it: add 'dma-router' to
> the properties with $ref. additionalProperties: false.
> 
> Explain the dependencies and merging bindings via one tree in the cover
> letter or commit changelog.
> 

Thanks for this suggestion. This is what I need.

> Best regards,
> Krzysztof
>