Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp79823lqt; Mon, 18 Mar 2024 01:48:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV5qk7uwOfkgwc3uk8BkJZeoElKg5bL2fOsZKmNGq22avF8oA0CW3pxZG4187s1x927Z85tPfOalzs4cNRoO5APh5NvZmw65skhcgt0IA== X-Google-Smtp-Source: AGHT+IF8viB6/cleCxvCTKTUJ1yZbFhKu4aH8+gBgemq6NgVQs4Xx1VQTnh5hdiIn/8z181BY9P8 X-Received: by 2002:a17:902:d505:b0:1e0:1bff:676d with SMTP id b5-20020a170902d50500b001e01bff676dmr2737948plg.62.1710751717988; Mon, 18 Mar 2024 01:48:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710751717; cv=pass; d=google.com; s=arc-20160816; b=BUoBbWpcFF+OvEb/JGSZDNHiefeWzCF46yOSJ1td7BE5hul09FKeZdVvfYMUvGMXgQ w0C4YKFtzPGv2qrRvNjmg0/6HGfjkOnRedkwqs5V3CIbiiCMhX7btK/nSwNDGhA1Y+Bz 2ulid5eEZiGynYxR8D2IcNXv4GjjLTOMkCrrvdt06anTPZ4oCbTJabmWwqsArsisRvFR mxUGaDH1vkOfdSlbqnA/uXx+EDoOY7NVY7bWDYppwHb8ClHNvEZNyVK0Cq2FS3PS9lMf xzzLNmCv47jGErIskE7WH40JMo5BK5ME0Pp1sdL/bJjh1B80+7B2g2+zYGxvQcOYI2Hn sf1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/axK6CBnRF50EmwYqSx3nB5XyaKV1/Bk14xrtP+Veno=; fh=cA0QWkzCkvyseSQZxALVSBWi0AgaPcDfpwhiNcXzkpg=; b=KkMA3nf9fhyn1R/Ery/m8baRLUklyo82ycQ8obEDJmUm7i5oz6zIg3dEoxK1UyhdA5 i7xmO7Sl+D9n4BNzaKoWodSATAM6urlrsyKKiBeY1/SdLD2jDXIoA26BwhBcNStoi8oQ aaTJXMCy9VGjdQ64ybQO/lLRILMrZN8AEqxiB7DxO/VC1WDlu2Kt0eg0tt5FNDRgC2ZY 8SsccJhEJ+OSAVr0KOwUyg+pB7OytvXzeW0SdyaCyrLx+BQE041csgoLg6EcxdI9fGTw zDPjJREv/WbP+/ivIh5i7UQF1tgqhbTeVGkt8CafSWIIC2LheIgzn7rGwT9TWLBIVMyl y/2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EzivUTTJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105833-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105833-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id q17-20020a17090311d100b001dda3f5eddasi8902083plh.76.2024.03.18.01.48.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 01:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-105833-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EzivUTTJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-105833-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-105833-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EB109B20BE5 for ; Mon, 18 Mar 2024 08:48:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE8DF2C19F; Mon, 18 Mar 2024 08:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EzivUTTJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D1028E26; Mon, 18 Mar 2024 08:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710751670; cv=none; b=AQXh0E9T/HGOEVrCOkyi1uf4L/Uyy+Xl6LtmIpKB9O15neHq9Ib9TT5a6jQalMfjGC5S8w3Ip+x6u3dQNbiER4jdaVPlS1bRVzSSLOP8GHIwtdx9KIjEN0fupHwqbe1gv4zM0eGIZTxMQA/ca33r3ON+RMthUBHPtJCBjHqoI1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710751670; c=relaxed/simple; bh=Ew2uVxn7vsJK/JFcU9zZaMqRiK9DDlzk08Afo0ps6tI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p93WRwniWv6hKPAUHh4ZTrZqQy9FBq1d97ZSfsvrUWhTrgJHKcqaicin6t9Sfm7hm+UDoMqMZCMF5Kqpx1xsco0gdnRL1zrTJhHECuFGerwBRD5AQHQBJM+MMeE+e0k/KoFp1nHog4vzrbniVb3TqeN2WIVH4f61sb5af+D/ACs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EzivUTTJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C5EFC43390; Mon, 18 Mar 2024 08:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710751670; bh=Ew2uVxn7vsJK/JFcU9zZaMqRiK9DDlzk08Afo0ps6tI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EzivUTTJsOVwzxrrjAi8avkIKYnbjeM4XRGeAWhECQodhvZC8kmFJWqaTzdz0pxWC P+u23knAXSnKZzwSijQvwcTp1Y6yj9Th6qF11ie0hubBxxB/lbWkBb8wG8INhF5gNt SD/6DmhfAK68FbBlHwoFcGYdsPbAjZTJXaQyWLRyUrU+DDiNfEIrK2L+dTACporQO1 s0fBVumxqULEsAVUSP5Pg1kqLtxW7KR2VmNF4ZEemUk1fWUFSssa5XNq/GleRsKDdw aKUJD8WTFNE0x9UTeLrBts8E4bqGm+jegR21ZVPowPivX1mVBWpcVQmkp0orvcL5Oa eTYI7PqVNFLMw== Date: Mon, 18 Mar 2024 09:47:45 +0100 From: Christian Brauner To: Cyril Hrubis Cc: kernel test robot , oe-lkp@lists.linux.dev, linux-fsdevel@vger.kernel.org, lkp@intel.com, ltp@lists.linux.it, linux-kernel@vger.kernel.org Subject: Re: [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail Message-ID: <20240318-fegen-bezaubern-57b0a9c6f78b@brauner> References: <202403151507.5540b773-oliver.sang@intel.com> <20240315-neufahrzeuge-kennt-317f2a903605@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Mar 15, 2024 at 03:49:03PM +0100, Cyril Hrubis wrote: > Hi! > > So I'd just remove that test. It's meaningless for pseudo fses. > > Wouldn't it make more sense to actually return EINVAL instead of > ignoring the request if readahead() is not implemented? It would change the return value for a whole bunch of stuff. I'm not sure that wouldn't cause regressions but is in any case a question for the readahead maintainers. For now I'd just remove that test for pidfds imho.