Received-SPF: pass (google.com: domain of linux-kernel+bounces-105851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <89231582-bc4e-4729-8dc1-bac190c28e00@linux.intel.com>
Date: Mon, 18 Mar 2024 10:12:37 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec
 driver
To: "Ding, Shenghao" <shenghao-ding@ti.com>
Cc: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
 "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "perex@perex.cz"
 <perex@perex.cz>,
 "pierre-louis.bossart@linux.intel.com"
 <pierre-louis.bossart@linux.intel.com>,
 "13916275206@139.com" <13916275206@139.com>,
 "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
 "bard.liao@intel.com" <bard.liao@intel.com>,
 "mengdong.lin@intel.com" <mengdong.lin@intel.com>,
 "yung-chuan.liao@linux.intel.com" <yung-chuan.liao@linux.intel.com>,
 "Lu, Kevin" <kevin-lu@ti.com>, "tiwai@suse.de" <tiwai@suse.de>,
 "soyer@irl.hu" <soyer@irl.hu>, "Baojun.Xu@fpt.com" <Baojun.Xu@fpt.com>,
 "Navada Kanyana, Mukund" <navada@ti.com>,
 "broonie@kernel.org" <broonie@kernel.org>
References: <20240305132646.638-1-shenghao-ding@ti.com>
 <2efb5250-25f3-465e-81fc-cb885027b481@linux.intel.com>
 <4e2006ff96a446978dd1996eeaa42099@ti.com>
Content-Language: en-US
From: =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?=
 <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <4e2006ff96a446978dd1996eeaa42099@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 3/16/2024 1:44 PM, Ding, Shenghao wrote:
> Thanks for your comments. Kindly see the feedback
> 
>> -----Original Message-----
>> From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>> Sent: Wednesday, March 6, 2024 12:05 AM
>> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org
>> Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com;
>> perex@perex.cz; pierre-louis.bossart@linux.intel.com;
>> 13916275206@139.com; alsa-devel@alsa-project.org; linux-
>> kernel@vger.kernel.org; liam.r.girdwood@intel.com; bard.liao@intel.com;
>> mengdong.lin@intel.com; yung-chuan.liao@linux.intel.com; Lu, Kevin
>> <kevin-lu@ti.com>; tiwai@suse.de; soyer@irl.hu; Baojun.Xu@fpt.com;
>> Navada Kanyana, Mukund <navada@ti.com>
>> Subject: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec
>> driver
>>
>> On 3/5/2024 2:26 PM, Shenghao Ding wrote:
>>> The tas2783 is a smart audio amplifier with integrated MIPI SoundWire
>>> interface (Version 1.2.1 compliant), I2C, and I2S/TDM interfaces
>>> designed for portable applications. An on-chip DSP supports Texas
>>> Instruments SmartAmp speaker protection algorithm. The integrated
>>> speaker voltage and current sense provides for real-time monitoring of
>> loudspeakers.
>>>
>>> The ASoC component provides the majority of the functionality of the
>>> device, all the audio functions.
>>>
>>> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
>>>
>>> ---
>>
>> ...
> ...
>>> +struct tasdevice_priv {
>>> +	struct snd_soc_component *component;
>>
>> Apart from being assigned this field seems to be unused.
> This field can help to get the point to "struct tasdevice_priv" in tasdevice_sdw_pcm_hw_free,
> tasdevice_sdw_hw_params, tasdevice_mute
> 

This field is unused in those functions, in all of them you get 
component from dai, via dai->component, and tas_priv from this component 
via snd_soc_component_get_drvdata, which is wrapper around 
dev_get_drvdata, which just returns dev->driver_data.